From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE101C6FA83 for ; Mon, 12 Sep 2022 19:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A8468D0001; Mon, 12 Sep 2022 15:46:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 456D06B0073; Mon, 12 Sep 2022 15:46:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F7E98D0001; Mon, 12 Sep 2022 15:46:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A1FF6B0072 for ; Mon, 12 Sep 2022 15:46:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DBF92A118E for ; Mon, 12 Sep 2022 19:46:03 +0000 (UTC) X-FDA: 79904464206.03.DD51DBA Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 53E9E1C00AE for ; Mon, 12 Sep 2022 19:46:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D159FB80CAA; Mon, 12 Sep 2022 19:46:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 742D5C433C1; Mon, 12 Sep 2022 19:46:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663011960; bh=htxr92E1RnmJ8ugZTVZs+mTLMDTYDJ5hbF5R6VSrAX8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TMPdY9IStJBssLKeDMviuOwyv8zfHnUp8z/pm+d2f4MS1nJfqEAOJCXCeMggl2tnk iIR59TXFcSROOcvucsw9/+hKlgYqB3dgePKlzm/Z5cNCfVRnf/d51C4ZK8L43TB3u1 /3PPpoE7L4hnsfzUe/FhP1j1K04Sfrb5jMdJaKa0= Date: Mon, 12 Sep 2022 12:45:59 -0700 From: Andrew Morton To: Yu Zhao Cc: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v14 67/70] mm/vmscan: Use vma iterator instead of vm_next Message-Id: <20220912124559.f1f5c26b882325fe5e5c5cce@linux-foundation.org> In-Reply-To: References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220906194824.2110408-68-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663011963; a=rsa-sha256; cv=none; b=lm5xEzseaWb0/T/gEybVZC7g5tgUlXlvFkB97/gVJXQgo4QkWOiMsP60hvZgKXvoz9Poc3 upxV+Ewy71P69F4RZx8rCJdNOlKQwMr5oouh7VMXT4NFJgPOEGw+KfTDXYpd/EMCOYoEfy FdpQ3BrT9aq9kY+gaeVZHopj6nfbjxU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TMPdY9IS; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663011963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KNqJY7zkqnmjnFC+r3/17c5allQsj0pVHYdLnLjlAnU=; b=ZVAIkwc1OoanowlstcLw/R3zjoUcP2p3R0DFQT4eh91pZACCqqr6DoGouX7ADU9Xu7POuf xZpVK1ssrdkd3/BWjcrM/1/mWHgrD/M+mwbn1xxrAU00TpyQDg787hQoGlDRh6IbXL0b/v 52QqvPhTk5URH5J1aCnd/gSfu2K4V54= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 53E9E1C00AE X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=TMPdY9IS; dmarc=none; spf=pass (imf20.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: qr536nmjcdd1w3umnme47zsdcwombkkz X-HE-Tag: 1663011963-641814 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 12 Sep 2022 00:55:08 -0600 Yu Zhao wrote: > > The following should work properly. Please take a look. Thanks! > > --- > mm/vmscan.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 11a86d47e85e..b22d3efe3031 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3776,23 +3776,17 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk > { > unsigned long start = round_up(*vm_end, size); > unsigned long end = (start | ~mask) + 1; > + VMA_ITERATOR(vmi, args->mm, start); > > VM_WARN_ON_ONCE(mask & size); > VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); > > - while (args->vma) { > - if (start >= args->vma->vm_end) { > - args->vma = args->vma->vm_next; > - continue; > - } > - > + for_each_vma(vmi, args->vma) { > if (end && end <= args->vma->vm_start) > return false; > > - if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) { > - args->vma = args->vma->vm_next; > + if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) > continue; > - } > > *vm_start = max(start, args->vma->vm_start); > *vm_end = min(end - 1, args->vma->vm_end - 1) + 1; What does this apply to? It's almost what is in mm-unstable/linux-next at present? static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk *args, unsigned long *vm_start, unsigned long *vm_end) { unsigned long start = round_up(*vm_end, size); unsigned long end = (start | ~mask) + 1; VMA_ITERATOR(vmi, args->mm, start); VM_WARN_ON_ONCE(mask & size); VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); for_each_vma_range(vmi, args->vma, end) { if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) continue; *vm_start = max(start, args->vma->vm_start); *vm_end = min(end - 1, args->vma->vm_end - 1) + 1; return true; } return false; } for_each_vma_range versus for_each_vma.