From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFE2C6FA83 for ; Mon, 12 Sep 2022 21:03:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F47D6B0072; Mon, 12 Sep 2022 17:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A3206B0073; Mon, 12 Sep 2022 17:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86BF58D0001; Mon, 12 Sep 2022 17:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78E186B0072 for ; Mon, 12 Sep 2022 17:03:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F17D1A06A0 for ; Mon, 12 Sep 2022 21:03:41 +0000 (UTC) X-FDA: 79904659842.11.7836A56 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id CC55320083 for ; Mon, 12 Sep 2022 21:03:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6281AB80C9E; Mon, 12 Sep 2022 21:03:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED1F1C433C1; Mon, 12 Sep 2022 21:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1663016618; bh=QxeY48qWmriggvsOyHNPWAgUKEIV8SqgZoGQWtuS5Us=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZtSG5aBaVkC2Akw+OB723wIAYcK9/Hf4iA7iHPCpxz5j95EcbMMWlifVyJNWhjzVk 3/6eAK+s/LNSLbjPHF4gu7ZJH1LN+Du4UMKYgkavS3QZaeGmoyPtLJdHCc2irrJNjM O2nmlvB2qHGGINNX8jHL4dt9FDcsYAbxp5UhPA3E= Date: Mon, 12 Sep 2022 14:03:37 -0700 From: Andrew Morton To: Yu Zhao Cc: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v14 67/70] mm/vmscan: Use vma iterator instead of vm_next Message-Id: <20220912140337.cccdea4cf67e4c4126ae158d@linux-foundation.org> In-Reply-To: References: <20220906194824.2110408-1-Liam.Howlett@oracle.com> <20220906194824.2110408-68-Liam.Howlett@oracle.com> <20220912124559.f1f5c26b882325fe5e5c5cce@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663016620; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L2S04DM8pqGE7CMnDMKQI+boVQKOm+pETDhU8Qp4Yog=; b=Ir5X6eVOJBSd+qHQEMp5xRxqc+ZrjeMJFdLcCWN80Aj/uo7rUYb+5LiCdUZKc6wWnSQUG3 gCFt02RB4XhqK6EAQQTJyBX+fVXiTW0l9AwlEVz+Dp5gic2ILRcq4RZPjrswncKOuE9jUG ONjmHnk7NkjKM9nj3TOvdYLN3QnS0eI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZtSG5aBa; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663016620; a=rsa-sha256; cv=none; b=oaNROZF+58Fs0aTgifgsNDE26fW1oPI77KgtgTfVVnAKe5FvIL+w57qtFne3UGRWkhydqf lEYS62IgaTly6k1hUuUYIFTIU7O3/rt2xQmobSRRyuIrEsN6VPZfr3VW1j2Nk6Bu9PcEQT UYLINzxZ2fdlZMP7A7llUUYaKAqfswk= X-Stat-Signature: mpgdzioc5imink8am181bsse9554suxe X-Rspamd-Queue-Id: CC55320083 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ZtSG5aBa; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1663016620-403029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 12 Sep 2022 14:01:28 -0600 Yu Zhao wrote: > The diff between the original patch and this one, in case you prefer to > fix it atop rather than amend. Always... > diff --git a/mm/vmscan.c b/mm/vmscan.c > index a7c5d15c1618..cadcc3290918 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -3776,7 +3776,10 @@ static bool get_next_vma(unsigned long mask, unsigned long size, struct mm_walk > VM_WARN_ON_ONCE(mask & size); > VM_WARN_ON_ONCE((start & mask) != (*vm_start & mask)); > > - for_each_vma_range(vmi, args->vma, end) { > + for_each_vma(vmi, args->vma) { > + if (end && end <= args->vma->vm_start) > + return false; > + > if (should_skip_vma(args->vma->vm_start, args->vma->vm_end, args)) > continue; Thanks. I added your signoff so I don't get a nastygram from Stephen in the morning. Please send along a suitable brief changelog?