From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7353FECAAD8 for ; Sat, 17 Sep 2022 02:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEB648D0002; Fri, 16 Sep 2022 22:13:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B098D0001; Fri, 16 Sep 2022 22:13:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 988C38D0002; Fri, 16 Sep 2022 22:13:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8A8278D0001 for ; Fri, 16 Sep 2022 22:13:18 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C6FD14073C for ; Sat, 17 Sep 2022 02:13:18 +0000 (UTC) X-FDA: 79919955276.03.1C95300 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf02.hostedemail.com (Postfix) with ESMTP id D2DD6800B2 for ; Sat, 17 Sep 2022 02:13:17 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id 9so11794755pfz.12 for ; Fri, 16 Sep 2022 19:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=O/wHfSygLsTDmbVML9jL5HVnMqDKxLwyjweHfisFexo=; b=hkpFE9dY8zc+Tj/9KFsk0wgqf7HV2Vezb5hXqx4WGnDt6gWbT8Oo2Mm/WniNar0pjZ axB4dbEGB4QUVsmTeFErEpIpUoOK+9fHkROm67WOLblpmqgjMoGBpUNsaB/0cWDEcvZP 6Jw8EIKe/7w3+jCTuy2gt1cMlwCaMbzVBkDiMMSXFmlXRauiQpcRy/XIwSiT6QtelneC 8LEfZwtbUlvV6Jpb7W9DxRKSzG3oTthsYAZmAsV9bEyQpF0sXHtt5ham7Da91bzhppLx AY6DtdzzaUHtLmU5YIVJsCGL/x3G2wGU+3xq3Ckv7QU8hzbrDXe0LNWaClm54Q35Rp3B Wp0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=O/wHfSygLsTDmbVML9jL5HVnMqDKxLwyjweHfisFexo=; b=xpQydaDFrB80actPn73ZvlYRK32uuUJUpAkSjmUYFbimSB4bIjvYwN9wzmaMmDfsAc oONbOgyU9P2MBK2m5afOH4Oq7CfTpJ3gONejNtBjqK0HfvU9sbkSiTxsuGwwhma/N2Lv hnQMcHohCwZyuvBJzP/9N4LHlzYKeHdzZ8cOqJi1Yqkrfz+Gwu3cSgRh37VUNZe2bpb5 /gtks5vxsOH4BhGiXLyvxO4Z8b8cDuPmOBomFAp5MsiBevOmsY4/nO7UZQHdSksanIde 9mMarwTJ+RgBsaxHb6ZGhG0SgVkGYkuurPvEGzjS6t/AepjpBwnZhrxtDxvodYF1O7kg Wtpg== X-Gm-Message-State: ACrzQf2nO63vMYMawfWoBX9tY02M9zFPG5Anf4MHnSXMx/OmzdFP+Ejk javp7hCXthJsKMvwhaXKEKA= X-Google-Smtp-Source: AMsMyM4wSunl1Ehj83giXSNRzm8v0AxUUnGmsIK5jCr7OOe0AbFT0IYYcCJ0U4URWNWErqSPiRxzNQ== X-Received: by 2002:a63:1349:0:b0:438:fa5a:b6f1 with SMTP id 9-20020a631349000000b00438fa5ab6f1mr7201270pgt.250.1663380796804; Fri, 16 Sep 2022 19:13:16 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id oj5-20020a17090b4d8500b0020263b7177csm9753575pjb.3.2022.09.16.19.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 19:13:15 -0700 (PDT) From: Li Zhong To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, Li Zhong Subject: [PATCH v1] mm/vmscan: check the return value of migrate_pages() Date: Fri, 16 Sep 2022 19:12:57 -0700 Message-Id: <20220917021257.3840548-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663380797; a=rsa-sha256; cv=none; b=i5cc4oXFB8AJCKcnem+rhGlXlyXbKKWla4u9ky3G2nXxe0UZKgZGT62FMFcnWt3SH7dl4m f9nCbRtqlwTwXX8C/z47mh7VrP5+eMKQI37tOidsNRNere2Nb7DGd+vxDI/h+XVH7i+19l Mp7/96AQQsoWv0Y4txyJ8Cqp3kJC3GU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hkpFE9dY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of floridsleeves@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=floridsleeves@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663380797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=O/wHfSygLsTDmbVML9jL5HVnMqDKxLwyjweHfisFexo=; b=xg5ehR8k6gRoT5l0tf/vdiAaiQYXNBNjG8cmmW6LIq6tzjUc8TgB9qBrz6KMRos66W1EbY LeMpfE80DFGRUcF/ScERzoLy0Ozm4gO1WhHMwfCFlngLrzLiOR7LcsEzpc3ZW+BdaLyk4O tih3Up6XWIDJtKAtCLR9ZbwDxfp1wfc= X-Stat-Signature: pnk4ga95oq7eisbbg15oqi5w591b8soo X-Rspamd-Queue-Id: D2DD6800B2 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hkpFE9dY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of floridsleeves@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=floridsleeves@gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1663380797-87674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Check the return value of migrate_pages() to check error exeuction. Signed-off-by: Li Zhong --- mm/vmscan.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b2b1431352dc..50aaaa9377e2 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1547,6 +1547,7 @@ static unsigned int demote_page_list(struct list_head *demote_pages, { int target_nid = next_demotion_node(pgdat->node_id); unsigned int nr_succeeded; + int ret; if (list_empty(demote_pages)) return 0; @@ -1555,10 +1556,13 @@ static unsigned int demote_page_list(struct list_head *demote_pages, return 0; /* Demotion ignores all cpuset and mempolicy settings */ - migrate_pages(demote_pages, alloc_demote_page, NULL, + ret = migrate_pages(demote_pages, alloc_demote_page, NULL, target_nid, MIGRATE_ASYNC, MR_DEMOTION, &nr_succeeded); + if (ret) + putback_movable_pages(&pagelist); + if (current_is_kswapd()) __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded); else -- 2.25.1