From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63254C6FA86 for ; Sun, 18 Sep 2022 20:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C92940009; Sun, 18 Sep 2022 16:48:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2432940008; Sun, 18 Sep 2022 16:48:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C618940009; Sun, 18 Sep 2022 16:48:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 83C90940008 for ; Sun, 18 Sep 2022 16:48:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 56C79160302 for ; Sun, 18 Sep 2022 20:48:03 +0000 (UTC) X-FDA: 79926393246.17.71A4C37 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf04.hostedemail.com (Postfix) with ESMTP id 135CC4000C for ; Sun, 18 Sep 2022 20:48:02 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id u12-20020a25094c000000b006a9ad6b2cebso23623206ybm.15 for ; Sun, 18 Sep 2022 13:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date; bh=oLphItSceKYTp0uPvFiu9gpbpwSB2H2p/Gmn36qHs5Q=; b=Gr2Dwa6beWc7RsEPq11s6/aXuhMiGVUf5rv5bcGpTulgEyMysSFBYN+ACqhwRxusnw BmwHxlF+9qPIFPwwHUCau/CQ5YI7KgA7+DQQZosSJusDEjd5gZnOFgH/2hUQQXcRk5yv qMTWCIaaqZkh33z3ZBqAvCvqVk2tYhjseyAQQE03Pm+XnmLf039IEVeiyuH/zb5vRsb/ 6yYBvOEMaHNGZPc4sX/XvwgYPXO+g+mPkeBAO9bJUB1J7rvIj6dQ0e2+MEZn36d0vmT6 fRfrwl15mOtf+5DJrhNgE+Ct/amOGR0GHwtckx73xKP0fgbKA8t0daE8tOJZSPS4d1X9 3S/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=oLphItSceKYTp0uPvFiu9gpbpwSB2H2p/Gmn36qHs5Q=; b=BwQGwbABxCbhvjJAIzk5TC0SmRtyUiqFPHuQzxC7Osdb6Wibd7R18OGxr+taFENJs6 p0HyOVmU8eiXdWWuo5NDjfI0lsfxreZxruvqT1LBDz5c7o1crlN/2LxRz/JcUQktN82C G/m2F2GElmTe2YTje035maxNLpHlOWtuU5Zr/UilBbOicgLr6JWD8WHfoucsB0GTGTjR 33rDbtEpK5IXkDEAHS3d1oS6nT4SKs/8EP1aB3+uwVbU5GPSitfdaPwMnNyMi58UgJvX WCDJB8Pit0FpAmk1lX9+U1a9sj41H/ZvkgK67ObtkX73xD1ofh4mxBMHOWgyK1Doyx00 6rdg== X-Gm-Message-State: ACrzQf3jI0LJcFidYT3pUxIE6rh0Jx85cjfDN3B9PZ7ch5B7QBFqdceA zKpQkZypqSmeMhqbWpJCkyLzkeeQj0Q= X-Google-Smtp-Source: AMsMyM6ofQh0byKCv5h0Eeua94mtAvgxlikfbLfXlDuMWYponQOZBI6ROWGKX6HvRMrEnKjIlLRf6Q1GCEk= X-Received: from yuzhao.bld.corp.google.com ([2620:15c:183:200:ccff:7b62:4ed6:2946]) (user=yuzhao job=sendgmr) by 2002:a25:6c3:0:b0:6b0:4336:9d81 with SMTP id 186-20020a2506c3000000b006b043369d81mr12177705ybg.119.1663534082383; Sun, 18 Sep 2022 13:48:02 -0700 (PDT) Date: Sun, 18 Sep 2022 14:47:47 -0600 In-Reply-To: <20220918204755.3135720-1-yuzhao@google.com> Message-Id: <20220918204755.3135720-3-yuzhao@google.com> Mime-Version: 1.0 References: <20220918204755.3135720-1-yuzhao@google.com> X-Mailer: git-send-email 2.37.3.968.ga6b4b080e4-goog Subject: [PATCH v14-fix 03/11] mm: multi-gen LRU: warn on !ptep_test_and_clear_young() From: Yu Zhao To: Andrew Morton Cc: linux-mm@kvack.org, Yu Zhao , Nadav Amit Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Gr2Dwa6b; spf=pass (imf04.hostedemail.com: domain of 3AoQnYwYKCMcB7Cun1t11tyr.p1zyv07A-zzx8npx.14t@flex--yuzhao.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3AoQnYwYKCMcB7Cun1t11tyr.p1zyv07A-zzx8npx.14t@flex--yuzhao.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663534083; a=rsa-sha256; cv=none; b=Cnfrhw90n2MsECmZT/b8XPaVwDLgwLJbwWRf5r/u8hIAHJIbwYlAWy6ThLPcqI1r8zxq7F 289hxHV6O0vOPIwAeo3T5p2fFP7QO7FFeYepMMkDOfFEMHsco/cfUgh2ofqhpW0+8cKsd6 zr/HXNCtkj0tC38J+i46MeE8EUIHM8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663534083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oLphItSceKYTp0uPvFiu9gpbpwSB2H2p/Gmn36qHs5Q=; b=CQrOUuq8iML+pWaJ/spdwo6UKiA354czpmlC8oQj9e0V93uNYav/2ANGWyGZFpq1L1i67B +pwVunzbb99nCMWWqMZOeAph9A1Yiowk9sKFpDkeR2ZVIUH0UK2jx7NARnrc1bQWEHqzJB x7SbGHlYg7qADOOc0l/kZS1q7E38tEY= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Gr2Dwa6b; spf=pass (imf04.hostedemail.com: domain of 3AoQnYwYKCMcB7Cun1t11tyr.p1zyv07A-zzx8npx.14t@flex--yuzhao.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3AoQnYwYKCMcB7Cun1t11tyr.p1zyv07A-zzx8npx.14t@flex--yuzhao.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: 696zhkqtb3nky4ipmhhhcyorayz4ab37 X-Rspamd-Queue-Id: 135CC4000C X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1663534082-659046 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Link: https://lore.kernel.org/r/0F7CF2A7-F671-4196-B8FD-F35E9556391B@gmail.com/ Suggested-by: Nadav Amit Signed-off-by: Yu Zhao --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 5c4d9d0867ec..629518813b59 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3904,7 +3904,7 @@ static bool walk_pte_range(pmd_t *pmd, unsigned long start, unsigned long end, continue; if (!ptep_test_and_clear_young(args->vma, addr, pte + i)) - continue; + VM_WARN_ON_ONCE(true); young++; walk->mm_stats[MM_LEAF_YOUNG]++; @@ -4637,7 +4637,7 @@ void lru_gen_look_around(struct page_vma_mapped_walk *pvmw) continue; if (!ptep_test_and_clear_young(pvmw->vma, addr, pte + i)) - continue; + VM_WARN_ON_ONCE(true); young++; -- 2.37.3.968.ga6b4b080e4-goog