From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECAFC6FA82 for ; Thu, 22 Sep 2022 08:10:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F5E940008; Thu, 22 Sep 2022 04:10:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D83E940007; Thu, 22 Sep 2022 04:10:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 079F2940008; Thu, 22 Sep 2022 04:10:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E976F940007 for ; Thu, 22 Sep 2022 04:10:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BB893813BE for ; Thu, 22 Sep 2022 08:10:43 +0000 (UTC) X-FDA: 79938999966.16.85E9C6D Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf30.hostedemail.com (Postfix) with ESMTP id C8DB980013 for ; Thu, 22 Sep 2022 08:10:40 +0000 (UTC) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MY7Fj0JwPzHpmF; Thu, 22 Sep 2022 16:08:25 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.63) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 22 Sep 2022 16:10:35 +0800 From: Zhao Gongyi To: CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 0/3] fix error when writing negative value to simple attribute files Date: Thu, 22 Sep 2022 16:06:48 +0800 Message-ID: <20220922080648.254312-1-zhaogongyi@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220919172418.45257-1-akinobu.mita@gmail.com> References: <20220919172418.45257-1-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.174.63] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663834242; a=rsa-sha256; cv=none; b=kx89/92vHrkQ/sCCaIRwocZHA6PhSeO6t46LeMf6NMMEFGswwQf66ckfW6humuTiuSRC2N EihXfu6S87CKXVVTC79bP2LCedVZGt6DyZkk7+UZtcvOFC3af2RHes+3Ud/sLeNtRdepQL MIaz8VPtGvkbxccylHm+hTV1I/GCZ7A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of zhaogongyi@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhaogongyi@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663834242; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IzkTkDPm7uE3+JAxpxR2fFQh2EliK6y/5/m4V5NEDdk=; b=Iz1omIqJivILH53WI9I/5KTRB1evekFsvC7ExkCwjNyqEjdxQjrbZ3RG7GOaQOZyOt5m9D iyJdLHZ0HwYmfvo83FUo7hdZl30O2kpXQ4y0USZJ43A2Q27+Dsi2c6XodV7NyXFK1xhhro TNNsPnH+61VREyz0tZ6HSEpmdauMULE= X-Rspam-User: X-Stat-Signature: mu83shaqprzt3i3i9dx45q9584gmmy8g X-Rspamd-Queue-Id: C8DB980013 Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of zhaogongyi@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=zhaogongyi@huawei.com X-Rspamd-Server: rspam07 X-HE-Tag: 1663834240-489494 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 20 Sep 2022 02:24:15 +0900 Akinobu Mita wrote: > The simple attribute files do not accept a negative value since the > commit 488dac0c9237 ("libfs: fix error cast of negative value in > simple_attr_write()"), but some attribute files want to accept > a negative value. > > Akinobu Mita (3): > libfs: add DEFINE_SIMPLE_ATTRIBUTE_SIGNED for signed value > lib/notifier-error-inject: fix error when writing -errno to debugfs > file > debugfs: fix error when writing negative value to atomic_t debugfs > file > > .../fault-injection/fault-injection.rst | 10 +++---- > fs/debugfs/file.c | 28 +++++++++++++++---- > fs/libfs.c | 22 +++++++++++++-- > include/linux/debugfs.h | 19 +++++++++++-- > include/linux/fs.h | 12 ++++++-- > lib/notifier-error-inject.c | 2 +- > 6 files changed, 73 insertions(+), 20 deletions(-) I have tested this version, it is ok. Tested-by: Zhao Gongyi