From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A352C54EE9 for ; Thu, 22 Sep 2022 15:57:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03D72940008; Thu, 22 Sep 2022 11:57:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F086D6B0072; Thu, 22 Sep 2022 11:57:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9F3940008; Thu, 22 Sep 2022 11:57:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C46C06B0071 for ; Thu, 22 Sep 2022 11:57:49 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A09561608D6 for ; Thu, 22 Sep 2022 15:57:49 +0000 (UTC) X-FDA: 79940177058.20.3D29845 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 606E12002E for ; Thu, 22 Sep 2022 15:57:49 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id w20so9158137ply.12 for ; Thu, 22 Sep 2022 08:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=DFca6W2geua6z8QZaei3L7obYL69ycUV+0eXMSxJFmM=; b=jvl2IXIRx3EhOhhqaTOf5Lt+fk9xx9Irq6xcu/7k7oCaAudZivnlCg4zfyCIBsgQa9 qBtVWGjfuRNfAqWNaj6IsSNxrO0lvCUNMMis5T9m3env78npe1AQYwW4n7mGlSRQHwQP cG9vbxRd7c25yIHtYw1xafxyLneU1vdiRP2x0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=DFca6W2geua6z8QZaei3L7obYL69ycUV+0eXMSxJFmM=; b=LWDvgWO7qdFLQAKF5w6B7caCh4bTX28fkFn+j2LMW1GAU9adD4zPTl6Anx8iJBM/Rj a+UolmcaQoXvP3kp/R1wS4JhdI2saEqg+ThI2wWE/27dCFXIrOGyYbzunyNL/+kFzfJX 3P4tFiqwKqnP+PL2z5NPTQdbmVYuEiSsV9h5ytSPo3H3P8zDWrwbc4ze5pwUHwU+/Qc/ uoYzO1pclz0naS5QzIkhicf2WZl7l+K0PcCHg/bnThPodX/aMmyGGfwJDQwEfz4lJu1N jGW4ffNRLzD0UbuWP5ZONTZWiYAAmBk/2YiIoAu51IOlXaENxbXzXk6gKoEwQkVPI0n/ dmeg== X-Gm-Message-State: ACrzQf21jNiTmzC8JFIMb96AtsVIQ1+6ivbG8TPF2ToA5FVgFo5CiPvg 71cvrI2yqlC39n7ofO1t9jxmlg== X-Google-Smtp-Source: AMsMyM4DbOcH8T52s44Y0t4Ur0sebk5QTw9RJNQKJ+FFAkxJV0gLFIOVmBX/n1oFJJpAp4+llFExqQ== X-Received: by 2002:a17:902:e848:b0:176:c746:1f69 with SMTP id t8-20020a170902e84800b00176c7461f69mr3892270plg.125.1663862268452; Thu, 22 Sep 2022 08:57:48 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p63-20020a625b42000000b005367c28fd32sm4575617pfb.185.2022.09.22.08.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 08:57:47 -0700 (PDT) Date: Thu, 22 Sep 2022 08:57:46 -0700 From: Kees Cook To: Alex Elder Cc: Vlastimil Babka , Alex Elder , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Greg Kroah-Hartman , Nick Desaulniers , Josef Bacik , David Sterba , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , Jacob Shin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 03/12] net: ipa: Proactively round up to kmalloc bucket size Message-ID: <202209220857.A6EBCF031E@keescook> References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-4-keescook@chromium.org> <4d75a9fd-1b94-7208-9de8-5a0102223e68@ieee.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d75a9fd-1b94-7208-9de8-5a0102223e68@ieee.org> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663862269; a=rsa-sha256; cv=none; b=Hi3tUI3FdmsuZ0DyzyON6RyJLhxnYimoWZoTHO8wvlGY/M2UuDqJDpmuFF59FgDv2lulxj w3yVq/P/+DSM1bB6CKbp9wFsEymily7RJXZ/R2K/s155DHqBZ2GGKlNf/hs8yagX0P3xRg FNF26NgZ4Jcu6DQDrp5/CmxbTyxx0EU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jvl2IXIR; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663862269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DFca6W2geua6z8QZaei3L7obYL69ycUV+0eXMSxJFmM=; b=J/sSHgXHA1bYGz89D2AFUKvdnAGGuNUuey1i6RJmyFiQs4pf51uWqYPCj3l3lo7saWzG8K 7PH/zRy8kIeoCL1NrpBHEpKqTpl8xz9/VB2oVw3xeyr4TQ6/40IN4YisAY5UZN1ahUTOdW aA4E9q6xXliGhSwtcjJyaJSiGALwtec= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 606E12002E X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jvl2IXIR; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: 7fzrsqr1e8i9ggf49nwcdwpahca3f68n X-HE-Tag: 1663862269-844151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 22, 2022 at 08:45:19AM -0500, Alex Elder wrote: > On 9/21/22 10:10 PM, Kees Cook wrote: > > Instead of discovering the kmalloc bucket size _after_ allocation, round > > up proactively so the allocation is explicitly made for the full size, > > allowing the compiler to correctly reason about the resulting size of > > the buffer through the existing __alloc_size() hint. > > > > Cc: Alex Elder > > Cc: "David S. Miller" > > Cc: Eric Dumazet > > Cc: Jakub Kicinski > > Cc: Paolo Abeni > > Cc: netdev@vger.kernel.org > > Signed-off-by: Kees Cook > > --- > > drivers/net/ipa/gsi_trans.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ipa/gsi_trans.c b/drivers/net/ipa/gsi_trans.c > > index 18e7e8c405be..cec968854dcf 100644 > > --- a/drivers/net/ipa/gsi_trans.c > > +++ b/drivers/net/ipa/gsi_trans.c > > @@ -89,6 +89,7 @@ int gsi_trans_pool_init(struct gsi_trans_pool *pool, size_t size, u32 count, > > u32 max_alloc) > > { > > void *virt; > > + size_t allocate; > > I don't care about this but the reverse Christmas tree > convention would put the "allocate" variable definition > above "virt". Oops, yes; thank you! -Kees -- Kees Cook