From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DFDC54EE9 for ; Thu, 22 Sep 2022 13:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E59580009; Thu, 22 Sep 2022 09:35:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6947080007; Thu, 22 Sep 2022 09:35:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55C7180009; Thu, 22 Sep 2022 09:35:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47D8980007 for ; Thu, 22 Sep 2022 09:35:49 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2240D1C5EB0 for ; Thu, 22 Sep 2022 13:35:49 +0000 (UTC) X-FDA: 79939819218.22.34F07EF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id AED31140009 for ; Thu, 22 Sep 2022 13:35:48 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 312D81F8F8; Thu, 22 Sep 2022 13:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1663853747; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=XihVZkR0NFlKaTEY2REooJ4nnysnnfLcvjy51KzgHbSW+oLtMuf9IonwLm/KkASRNsstRo s4Dx+Q4cpaICoaXsH0DUfapvCIci0Ubcv9A9s0vR8XX8+NUFKAnyoOuIT9zDwNjs4dr4X/ qezh4tAzHSN1OltdzTUMbRixdeL8EVg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1663853747; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=D4SrbPeIUjJXDbzN3l/v7S9Ic5eD5VW9j9nh63nD86Qj+hCZa1n0PAF8TSLqyf+7TdxxOs g6cysoCnwD04I3Cw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C8F513AA5; Thu, 22 Sep 2022 13:35:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RvYRFbJkLGM6egAAMHmgww (envelope-from ); Thu, 22 Sep 2022 13:35:46 +0000 Date: Thu, 22 Sep 2022 15:30:14 +0200 From: David Sterba To: Kees Cook Cc: Vlastimil Babka , linux-btrfs@vger.kernel.org, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , Jesse Brandeburg , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , Jacob Shin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-fsdevel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, dev@openvswitch.org, x86@kernel.org, linux-wireless@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org Subject: Re: [PATCH 04/12] btrfs: send: Proactively round up to kmalloc bucket size Message-ID: <20220922133014.GI32411@suse.cz> Reply-To: dsterba@suse.cz References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-5-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922031013.2150682-5-keescook@chromium.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663853748; a=rsa-sha256; cv=none; b=0mWcA3tN4WW6FxMhpqD6eXPF8oez1T92yVIkklcP7/mD9qPPLKLKUDe3U7dk/U8+ZzID9N GGH9KCV0hxRYPJ7Lr9Rccrs6kIRVrCL5HjAqfWRh3vduxQWlaIH+XrZ9xFoC5LAQNXMlei sUEhkG5hLJ5F8dOMnEk6Z3t8aVnaW+I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XihVZkR0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D4SrbPeI; dmarc=none; spf=pass (imf23.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663853748; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IwL9ZLjfbaspCU82c8med1UAPhmCPx1OWhj8R1+9qNM=; b=T58uz0OgSHXsFJLjPo/cazLJeJiVuhMIzU211/yUNF28vcjK5iTZkCrW6uDMydRMHEJxG5 xTFoXrJtd89AqB3Ue++zKox3SAkZQJJk8/Ub7LGAEmhvYVyw+TgGdaVEeQkVZ7uOLSvDJr AmGCRPrV/77tjiCDbVYNdAMoYDKOD9M= X-Rspam-User: X-Stat-Signature: gwoinh3s8yaka3u1eaxq47oaw1s6ms8m X-Rspamd-Queue-Id: AED31140009 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=XihVZkR0; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=D4SrbPeI; dmarc=none; spf=pass (imf23.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz X-Rspamd-Server: rspam07 X-HE-Tag: 1663853748-534472 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 21, 2022 at 08:10:05PM -0700, Kees Cook wrote: > Instead of discovering the kmalloc bucket size _after_ allocation, round > up proactively so the allocation is explicitly made for the full size, > allowing the compiler to correctly reason about the resulting size of > the buffer through the existing __alloc_size() hint. > > Cc: linux-btrfs@vger.kernel.org > Signed-off-by: Kees Cook Acked-by: David Sterba