From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B36BC07E9D for ; Fri, 23 Sep 2022 18:50:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2256580008; Fri, 23 Sep 2022 14:50:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D49080007; Fri, 23 Sep 2022 14:50:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0754B80008; Fri, 23 Sep 2022 14:50:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ED3C480007 for ; Fri, 23 Sep 2022 14:50:40 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C1495402CB for ; Fri, 23 Sep 2022 18:50:40 +0000 (UTC) X-FDA: 79944241440.24.AC626FC Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 39FCF18002D for ; Fri, 23 Sep 2022 18:50:40 +0000 (UTC) Received: by mail-pg1-f170.google.com with SMTP id s206so1059112pgs.3 for ; Fri, 23 Sep 2022 11:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=soz+B5vr0YawBrGLCJUIfst1rVPegj/kO945i6tNuu4=; b=OTfy5Nwpn08IcUaVlU1KJ27X+N3yWZ/VpCrAZjSpjUbsjTe/slddbrLCSNWyrUEUf+ hKFo3f2nFf90BAG6jEHb+7lo8EJfEwNPirhgwBNLji96jC6KqEyl6t0+uMZVhfPqRt/6 nRku1i36Slqm6llnH2++9t4exlSoETdRFUkh0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=soz+B5vr0YawBrGLCJUIfst1rVPegj/kO945i6tNuu4=; b=FL/XMpWeFqfKe5qeMsdEznWsKA4uQIKw0nBZNFCDjApvqK0wISX5dxgf0acpJOQjC+ ihZtF1QMy1quMMt2ceiinyE6Q4bKBU455z3quf4ek5X5+juhD0iNkJdBhO0whuPn01ZE SsGsOmDeHn/uHmRg0/a4O7w1qiKRwDefhsm/VS0mZGeWEYMwb2QmHRLB2P8RkHwiz+jx lJwEfVzPM392FfxKiZ/0sAAds14V/6Qn0+9WAOb9XPgcu5eZFrm+4VccvYwenCFE15Ng apC3lf27MwE30RZMCDPs8D9w6siHYkiXG3imZknOZ8QMb8dERiNuxfc4QUKwZCeKXFtI tkDQ== X-Gm-Message-State: ACrzQf0pFE/LOxcwIURQqL05zHT0qbRyHEdxgbOWUG6B+kbT9mqsdpVk qTkcg6KuGqYRktDETfrHW55YqA== X-Google-Smtp-Source: AMsMyM5BOkxT7dmLhP+9f8RXqZTh1AjF61zhu3wqGKFHMmPuMGgEdboAX7cqSq5H5AVVbN7wJUrI2g== X-Received: by 2002:a63:6a47:0:b0:439:be00:7607 with SMTP id f68-20020a636a47000000b00439be007607mr8719395pgc.301.1663959039042; Fri, 23 Sep 2022 11:50:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f13-20020a170902ce8d00b0016dc6279ab7sm6423837plg.149.2022.09.23.11.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 11:50:38 -0700 (PDT) Date: Fri, 23 Sep 2022 11:50:37 -0700 From: Kees Cook To: Feng Tang , Vlastimil Babka Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , "linux-mm@kvack.org" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Nick Desaulniers , Alex Elder , Josef Bacik , David Sterba , Sumit Semwal , Christian K??nig , "Brandeburg, Jesse" , Daniel Micay , Yonghong Song , Marco Elver , Miguel Ojeda , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , "linux-fsdevel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" , "dev@openvswitch.org" , "x86@kernel.org" , "linux-wireless@vger.kernel.org" , "llvm@lists.linux.dev" , "linux-hardening@vger.kernel.org" Subject: Re: [PATCH 01/12] slab: Introduce kmalloc_size_roundup() Message-ID: <202209231145.7654767ED5@keescook> References: <20220922031013.2150682-1-keescook@chromium.org> <20220922031013.2150682-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663959040; a=rsa-sha256; cv=none; b=mO786qsqBnTlmtUxEbw4r1bXtWRrfrNBKU7gI81gog/g+g2nYCGkz54hV8np7mRsHfm9n/ AGCicMyxEFFOA/eBW2PC0+dthgUDBv3a8lzAnG3mt6TOK5cbrPTba3NgwGfw6uMIItXVIj +nz9W0RJOxIP1qsCbI3KX12zP83hqkA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OTfy5Nwp; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663959040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soz+B5vr0YawBrGLCJUIfst1rVPegj/kO945i6tNuu4=; b=AG8ARqfUulXI79tAEbsMMiI+Ua3R6+COo18JEXNcEP5WvzZXYMQ2bJ/htbjZRJTBPWm/1s acYU7xzCeqnVuIyJvH8MBDiSuyqz+eydQLGi5picYpFZIreRq9iq9jUNZoKMH5tbkaPLsY rDo72UzpKFEhkx7zMIKDR5FEHylWkRk= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 39FCF18002D X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OTfy5Nwp; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.170 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Stat-Signature: 4d6nj4e6dxghi9mxyurphj5nydfqzmbo X-HE-Tag: 1663959040-719740 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 23, 2022 at 09:17:25AM +0800, Feng Tang wrote: > On Thu, Sep 22, 2022 at 07:12:21PM +0800, Hyeonggon Yoo wrote: > > On Wed, Sep 21, 2022 at 08:10:02PM -0700, Kees Cook wrote: > > > [...] > > > Introduce kmalloc_size_roundup(), to serve this function so we can start > > > replacing the "anticipatory resizing" uses of ksize(). > > [...] > > > > This looks okay. > > [...] > > Cc-ing Feng Tang who may welcome this series ;) > > Indeed! This will help our work of extending slub redzone check, > as we also ran into some trouble with ksize() users when extending > the redzone support to this extra allocated space than requested > size [1], and have to disable the redzone sanity for all ksize() > users [2]. > > [1]. https://lore.kernel.org/lkml/20220719134503.GA56558@shbuild999.sh.intel.com/ > [2]. https://lore.kernel.org/lkml/20220913065423.520159-5-feng.tang@intel.com/ Thanks for the feedback! I'll send my v2 series -- I'm hoping at least this patch can land in v6.1 so the various other patches would be clear to land via their separate trees, etc. -- Kees Cook