From: Florian Westphal <fw@strlen.de>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz,
akpm@linux-foundation.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org,
Martin Zaharinov <micron10@gmail.com>
Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC
Date: Fri, 23 Sep 2022 16:54:09 +0200 [thread overview]
Message-ID: <20220923145409.GF22541@breakpoint.cc> (raw)
In-Reply-To: <Yy3GL12BOgp3wLjI@pc636>
Uladzislau Rezki <urezki@gmail.com> wrote:
> On Fri, Sep 23, 2022 at 03:35:12PM +0200, Florian Westphal wrote:
> > Michal Hocko <mhocko@suse.com> wrote:
> > > On Fri 23-09-22 12:38:58, Florian Westphal wrote:
> > > > Martin Zaharinov reports BUG() in mm land for 5.19.10 kernel:
> > > > kernel BUG at mm/vmalloc.c:2437!
> > > > invalid opcode: 0000 [#1] SMP
> > > > CPU: 28 PID: 0 Comm: swapper/28 Tainted: G W O 5.19.9 #1
> > > > [..]
> > > > RIP: 0010:__get_vm_area_node+0x120/0x130
> > > > __vmalloc_node_range+0x96/0x1e0
> > > > kvmalloc_node+0x92/0xb0
> > > > bucket_table_alloc.isra.0+0x47/0x140
> > > > rhashtable_try_insert+0x3a4/0x440
> > > > rhashtable_insert_slow+0x1b/0x30
> > > > [..]
> > > >
> > > > bucket_table_alloc uses kvzallocGPF_ATOMIC). If kmalloc fails, this now
> > > > falls through to vmalloc and hits code paths that assume GFP_KERNEL.
> > > >
> > > > Revert the problematic change and stay with slab allocator.
> > >
> > > Why don't you simply fix the caller?
> >
> > Uh, not following?
> >
> > kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again?
> >
> <snip>
> static struct vm_struct *__get_vm_area_node(unsigned long size,
> unsigned long align, unsigned long shift, unsigned long flags,
> unsigned long start, unsigned long end, int node,
> gfp_t gfp_mask, const void *caller)
> {
> struct vmap_area *va;
> struct vm_struct *area;
> unsigned long requested_size = size;
>
> BUG_ON(in_interrupt());
> ...
> <snip>
>
> vmalloc is not supposed to be called from the IRQ context.
It uses kvzalloc, not vmalloc api.
Before 2018, rhashtable did use kzalloc OR kvzalloc, depending on gfp_t.
Quote from 93f976b5190df327939 changelog:
As of ce91f6ee5b3b ("mm: kvmalloc does not fallback to vmalloc for
incompatible gfp flags") we can simplify the caller
and trust kvzalloc() to just do the right thing.
I fear that if this isn't allowed it will result in hard-to-spot bugs
because things will work fine until a fallback to vmalloc happens.
rhashtable may not be the only user of kvmalloc api that rely on
ability to call it from (soft)irq.
next prev parent reply other threads:[~2022-09-23 14:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 10:38 [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Florian Westphal
2022-09-23 13:29 ` Michal Hocko
2022-09-23 13:35 ` Florian Westphal
2022-09-23 14:43 ` Uladzislau Rezki
2022-09-23 14:54 ` Florian Westphal [this message]
2022-09-23 15:10 ` Uladzislau Rezki
2022-09-26 15:03 ` Vlastimil Babka
2022-09-26 15:28 ` Sebastian Andrzej Siewior
2022-09-26 7:49 ` Michal Hocko
2022-09-26 7:56 ` Florian Westphal
2022-09-26 8:57 ` Michal Hocko
2022-09-26 9:30 ` Michal Hocko
2022-09-26 10:08 ` Florian Westphal
2022-09-26 12:02 ` Michal Hocko
2022-09-26 13:08 ` Florian Westphal
2022-09-26 13:38 ` Florian Westphal
2022-09-26 14:05 ` Michal Hocko
2022-09-26 14:20 ` Florian Westphal
2022-09-26 14:32 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923145409.GF22541@breakpoint.cc \
--to=fw@strlen.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=micron10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).