From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8E53C6FA82 for ; Sun, 25 Sep 2022 23:43:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B7D58E0025; Sun, 25 Sep 2022 19:43:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 567128E0007; Sun, 25 Sep 2022 19:43:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42EE28E0025; Sun, 25 Sep 2022 19:43:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 344708E0007 for ; Sun, 25 Sep 2022 19:43:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 081C4803D9 for ; Sun, 25 Sep 2022 23:43:56 +0000 (UTC) X-FDA: 79952238072.16.03F4AA3 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf05.hostedemail.com (Postfix) with ESMTP id C3EEF10000D for ; Sun, 25 Sep 2022 23:43:55 +0000 (UTC) Received: by mail-pf1-f176.google.com with SMTP id a80so5082507pfa.4 for ; Sun, 25 Sep 2022 16:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:from:to:cc:subject:date; bh=8l9SZEXeOGAHPaBYKpiKd2zRj1VQl6STNmYmUqvRW6o=; b=EyhErhjnZzbiLOtmYu3OzBfUaJ+feqdxAletymaonCXsf+pm1aB2w/8bIpcfolRMxH yl4MqdZEeWSJK5ecwsBqwQ1GSb+NJe3L1xK/y3A/+Gxe45ksPFkfOvjCfQJsg13cAX1l 3dnDDAtXAkww1in6A5oXz3v+vizcKoIN5KyM8bDxf5Pk3sd/b2OQy+ZHyt5rc0O2iXDU JVyK8PfhGNlIHf4SPLVqQNk0lsm7qz8RMw+PrVY2iB05gKj+iu7y3i5/BR+XUc/DO9Ol yDmZA77oCNugezpHy+BoyOLqltTFYj9dfrD03uqaC+NczdzL7R9rAGgNWjYbF4HsR7z1 zk7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=8l9SZEXeOGAHPaBYKpiKd2zRj1VQl6STNmYmUqvRW6o=; b=AAvBo0FSGF/Vb3rq24Y5HjGtOG80bgqzOOtYxy+qHPE7ckan0k+52KFZXQvRJsMFSw oOFfEmr/O/L07hZtkjxL7kVsn3IrpuTzDXVmryX+/l+5yNxSndRdgDEzk5KMJFJTbww0 EYb7Y/R/bUvCiiBMqm9x42bC3/ElhTOyiDjD5ssX67njBXzxhtlcHO+ZeIQH7JeLEM7f 1sIfeC2YdZQBtrycq8tLpORX9IlXodp+Jc7F1hCBqCamRaO08g1zn2CEcvTNnnz7FPAE jS2BwK/uDu8dTpkdqjRwF42JexgpRAKu0zzCy1/N9Ngwod4tqIw4H7pbkD50k0oSZeGG aOyw== X-Gm-Message-State: ACrzQf3Pt1oQRLrKzFKCarLDeVmzsfqJGtKOib3GOdImo5bsxqozsfo2 GyDsnGF2ZF6iXzXS9BOTM6w= X-Google-Smtp-Source: AMsMyM6uzBRZ15WrJyfwa20zTjvFCI+XZgR3GbQDEivislkxCI8uEecVmp+gG/ojWfaydxhxOTL3Xw== X-Received: by 2002:a63:8b42:0:b0:43c:ab46:7963 with SMTP id j63-20020a638b42000000b0043cab467963mr3360140pge.385.1664149434662; Sun, 25 Sep 2022 16:43:54 -0700 (PDT) Received: from localhost.localdomain ([211.226.85.205]) by smtp.gmail.com with ESMTPSA id f3-20020a170902ce8300b00178650510f9sm9814238plg.160.2022.09.25.16.43.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 25 Sep 2022 16:43:54 -0700 (PDT) From: Levi Yun To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, Levi Yun , stable@vger.kernel.org Subject: [PATCH v3] damon/sysfs: Fix possible memleak on damon_sysfs_add_target. Date: Mon, 26 Sep 2022 08:43:27 +0900 Message-Id: <20220925234327.26345-1-ppbuk5246@gmail.com> X-Mailer: git-send-email 2.35.1 Reply-To: <20220925140257.23431-1-ppbuk5246@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664149435; a=rsa-sha256; cv=none; b=u2XScPvj1Jyk4l3yZEOf704/wPBvHHTXaHfRHofM5lkDbyNFj8NR88EL7xzXx3SlYyaZn0 yyX5IEDML4yd9UtxM9G+MjftpjGfzeOxvCsEByD/XkNJ9Z8pXGvidQO6Rj6QLCxBZsw4Ws rmIBa/GL1gTx1OzMvXXywxfEstiT5Y0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EyhErhjn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664149435; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=8l9SZEXeOGAHPaBYKpiKd2zRj1VQl6STNmYmUqvRW6o=; b=qZU+IMl+ry4FLwzgzawlGV1KkeaHmX/KZFqOZm5jE87TzVxP5GDZmmMikigHLvTw+GIcmf rl4xwtkiaB4UghzxQEfUcCdepxQxNRGE8P9hVSUx7hcLb5qNkHA6uHGvaML2cb5z3qby71 vdZ/0kdx5BjX0YH1LE3jL1DeOvX7Nh8= Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=EyhErhjn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com X-Rspam-User: X-Stat-Signature: px58ohzwgrym8q1ui6t4t9q81ng1jisy X-Rspamd-Queue-Id: C3EEF10000D X-Rspamd-Server: rspam09 X-HE-Tag: 1664149435-196963 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When damon_sysfs_add_target couldn't find proper task, New allocated damon_target structure isn't registered yet, So, it's impossible to free new allocated one by damon_sysfs_destroy_targets. By calling daemon_add_target as soon as allocating new target, Fix this possible memory leak. Signed-off-by: Levi Yun Fixes:74bd8b7d2f8e7 Cc: --- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 7488e27c87c3..bdef9682d0a0 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2182,12 +2182,12 @@ static int damon_sysfs_add_target(struct damon_sysfs_target *sys_target, if (!t) return -ENOMEM; + damon_add_target(ctx, t); if (damon_target_has_pid(ctx)) { t->pid = find_get_pid(sys_target->pid); if (!t->pid) goto destroy_targets_out; } - damon_add_target(ctx, t); err = damon_sysfs_set_regions(t, sys_target->regions); if (err) goto destroy_targets_out; -- 2.35.1