From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12837C07E9D for ; Mon, 26 Sep 2022 07:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1B94900016; Mon, 26 Sep 2022 03:56:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A3D0900002; Mon, 26 Sep 2022 03:56:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84539900016; Mon, 26 Sep 2022 03:56:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6DF64900002 for ; Mon, 26 Sep 2022 03:56:42 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4B8481C39A2 for ; Mon, 26 Sep 2022 07:56:42 +0000 (UTC) X-FDA: 79953479844.08.DE31235 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [193.142.43.52]) by imf08.hostedemail.com (Postfix) with ESMTP id CC3ED160016 for ; Mon, 26 Sep 2022 07:56:41 +0000 (UTC) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ociyl-0002ma-7Z; Mon, 26 Sep 2022 09:56:39 +0200 Date: Mon, 26 Sep 2022 09:56:39 +0200 From: Florian Westphal To: Michal Hocko Cc: Florian Westphal , linux-mm@kvack.org, linux-kernel@vger.kernel.org, vbabka@suse.cz, akpm@linux-foundation.org, urezki@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Martin Zaharinov Subject: Re: [PATCH mm] mm: fix BUG with kvzalloc+GFP_ATOMIC Message-ID: <20220926075639.GA908@breakpoint.cc> References: <20220923103858.26729-1-fw@strlen.de> <20220923133512.GE22541@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664179002; a=rsa-sha256; cv=none; b=bzLGSYxUwBcCSQj4/Z2/xFTZU5axPI994+YWcLaOXlgwzIcTSHcJtKU8MsuQQAvJtEvLhT PEekY6NzSot9hCqz30jcMOnZTfPUo4bHzzMGDDla2JPOjM2H3X3MiwoxZ0NApDQ7mjil1B sU1rzN6NZYWYXlKYe3yLR9p4Pxoq9Y4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664179002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CjF3Gy54fRvoPqQakPFQ+kdzkfju16v2ClrMy7QPlzs=; b=f5dby2kHjOHvlzLH0+lpXv896e5yykXygiIzJJrKZh8bdDwrdNNiCJ6XD2Pu6zAgs0ik+p nWF9NmaPQQsSC7vdEG26oQCR06eNl3MxFuHLnpGj5fEtkiYMCFQSAhOWdaan1cUtpX9Kus zXqUkJiimAMRMAbqbu2I5qtSd36LU+A= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CC3ED160016 Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of fw@strlen.de designates 193.142.43.52 as permitted sender) smtp.mailfrom=fw@strlen.de; dmarc=none X-Stat-Signature: 3wy16emiiu653y3bamthfxp3j437m1tx X-Rspam-User: X-HE-Tag: 1664179001-832343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Michal Hocko wrote: > > kvzalloc(GFP_ATOMIC) was perfectly fine, is this illegal again? > > kvmalloc has never really supported GFP_ATOMIC semantic. It did, you added it: ce91f6ee5b3b ("mm: kvmalloc does not fallback to vmalloc for incompatible gfp flags")