From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E63C6FA86 for ; Mon, 26 Sep 2022 11:56:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0D378E0040; Mon, 26 Sep 2022 07:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBC5B8E0039; Mon, 26 Sep 2022 07:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B84CC8E0040; Mon, 26 Sep 2022 07:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A85B18E0039 for ; Mon, 26 Sep 2022 07:56:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 80E491A08D6 for ; Mon, 26 Sep 2022 11:56:34 +0000 (UTC) X-FDA: 79954084308.11.37BAAAA Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf02.hostedemail.com (Postfix) with ESMTP id D50E980014 for ; Mon, 26 Sep 2022 11:56:32 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id w20so5990445ply.12 for ; Mon, 26 Sep 2022 04:56:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=g8La9o/nNfleZYR5eX/LnvX4ayFeiZcwHVO0isJ+H6U=; b=653Z3bdEfFZWr6su4Ly2EQIg7sAvHMvxMW+IG/F+c2HogzXzCBn4Xe/Ac8eQeFhkjU Emw+pN+IbxpuUdYvoCsotI84upTXinNu3/QQ3h3JT/J4TOFATjMIftG9dxJEhYWYm4jw w6vMY/Alz7QsjbScSbPKy3JRodqTL3GcBky7/n6K9hSm7BmDKzmk1j3f+PTcPYw1pize sPXoAYa5B9/n95NwXUgyooPcpxaVLZt+VTEgH5XSNe3u0xoLLLRSZQDivonRUpkcCV1P gxDVWPklnjYq23SAH3RiiyDv1x3BkUA4vqp3D1rvKUnqEVmZhnISAsfxgQrct49vSiiw DDUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=g8La9o/nNfleZYR5eX/LnvX4ayFeiZcwHVO0isJ+H6U=; b=Y7qHxS5MPXTOlAFBxhQUZ5HOoI10dlZaCfrph+mwTCAAz440BA07bLD7DjxGav4Upq V2n+MxW27kttFGFjOxYAdk5yGmokyhFIPgwRtZyy4tpUf7DTj/uF6pl8B0A/Qb5S/sDT m8CqxtzJ0o4p55IQkM5xPnzkZnHs3nnf2O9ZICSTggZmLGiNV6zX72rpLioNwLN6CZnB LPcjhrq9+158bOjE0odYg0gT9MsBekE6ACvbPRCrQmaM+kjWcnHQSUrixpQp6iyfm7Cb cKHkBkAXEfAUFOp6V950TU0Dsq0VWSZbmpd7r/BXf+m0tEGUBtkyYpV7iL4mwi87vQ2H YtAw== X-Gm-Message-State: ACrzQf3JvBwnu2m6+NO9Wh790Q9e+gc4vSM0NjK1JJAXyg6awKj6375S 4xw5TgaztP/xdccxE1Vafo+pVA== X-Google-Smtp-Source: AMsMyM4ejO3jvfuH7QursZdDdLIy877QhdZW4S/PDlLZkDWt08ZGYbD0N8Mry4T6PJ7Hw7YVH4g0vA== X-Received: by 2002:a17:90b:3510:b0:202:f18c:fdb6 with SMTP id ls16-20020a17090b351000b00202f18cfdb6mr24321795pjb.122.1664193391562; Mon, 26 Sep 2022 04:56:31 -0700 (PDT) Received: from C02DW0BEMD6R.bytedance.net ([139.177.225.232]) by smtp.gmail.com with ESMTPSA id 128-20020a620586000000b0053ea3d2ecd6sm12157057pff.94.2022.09.26.04.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 04:56:30 -0700 (PDT) From: Qi Zheng To: akpm@linux-foundation.org, muchun.song@linux.dev, david@redhat.com Cc: chris@zankel.net, jcmvbkbc@gmail.com, maobibo@loongson.cn, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng , Muchun Song Subject: [PATCH v2] mm: use update_mmu_tlb() on the second thread Date: Mon, 26 Sep 2022 19:56:21 +0800 Message-Id: <20220926115621.13849-1-zhengqi.arch@bytedance.com> X-Mailer: git-send-email 2.24.3 (Apple Git-128) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=653Z3bdE; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664193393; a=rsa-sha256; cv=none; b=XHy25xthcUoMWfRj96Gbu+vacukcXxoPLgBX6v4Qr4zodxijKRL00yi3I+lo0+9ffWfQ9C HCZ3Wys4cJ3oLizJVr75ZdQhPl3V0uHulGG2wlS/40R84TXyQgkQgxUycIvuE03FNHRVBu sW+AmZMMaCS8it1Fq8G2/huFgYtgt5A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664193393; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=g8La9o/nNfleZYR5eX/LnvX4ayFeiZcwHVO0isJ+H6U=; b=SYJmcMHLSYoRM3/x4SElMxf7G2wL0Abrz1ohiVtIpnL2vuPCNH0Wqmxf2/G+QCu2Kr2woX WLJVIgL3Jnt2yIfgjSSDu0b+mYSOr/47c9LkS8SseF0A+X4Ed/ABOZxj+Zr/5BCauc+Q8J ujtJx29Ys4BV5Dd60tbMwWVd+cb3oXo= Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=653Z3bdE; spf=pass (imf02.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Stat-Signature: pcqij67qr9hzpyynnrziy3xz8g8pmu1u X-Rspamd-Queue-Id: D50E980014 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1664193392-460830 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As message in commit 7df676974359 ("mm/memory.c: Update local TLB if PTE entry exists") said, we should update local TLB only on the second thread. So in the do_anonymous_page() here, we should use update_mmu_tlb() instead of update_mmu_cache() on the second thread. Signed-off-by: Qi Zheng Reviewed-by: Muchun Song --- v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ Changelog in v1 -> v2: - change the subject and commit message (David) mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 118e5f023597..9e11c783ba0e 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, &vmf->ptl); if (!pte_none(*vmf->pte)) { - update_mmu_cache(vma, vmf->address, vmf->pte); + update_mmu_tlb(vma, vmf->address, vmf->pte); goto release; } -- 2.20.1