From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B10C43217 for ; Wed, 12 Oct 2022 23:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9092A6B0071; Wed, 12 Oct 2022 19:33:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B860900002; Wed, 12 Oct 2022 19:33:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 758D66B0074; Wed, 12 Oct 2022 19:33:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 63FC56B0071 for ; Wed, 12 Oct 2022 19:33:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 27D44C0A72 for ; Wed, 12 Oct 2022 23:33:06 +0000 (UTC) X-FDA: 80013900372.26.2585AF4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf17.hostedemail.com (Postfix) with ESMTP id 9717440028 for ; Wed, 12 Oct 2022 23:33:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA2AFB81CAD; Wed, 12 Oct 2022 23:33:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EFA8C43140; Wed, 12 Oct 2022 23:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665617582; bh=2Q43OD6ELjO061ruqIM9rlIj6RE37EF7791n2YoQok4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BJHMm2+JGCrZkkkXFcE+oWTKipjRdIU5JJxgbankq6nNuQk7d8hYuaNRINumrQmos ArgGoad04753zZFQZkEzJpG0rFKM3b6062n+MG0f/VFUKoxCk6+sB0r3DQwBkuxHdp Fv9J37lA7Mhc6oZLUZ6CYzHLP3anao1k1bLM4AP+RjeX8RmCgFDOziruJBItlkG3U+ FnHEks/27iS777oDY4eYuGX/eSckqCbE+8OMhS3A6ViE1oL7mnJn06oPc6VmgH773Y uQeF8Y4jW4IsBMF8OojmQG2KTb6+sWPOUMneGGy94L3FbLlS1JyegVEy9xfaZmwgUa c09+by+jC6I2g== Date: Wed, 12 Oct 2022 16:33:00 -0700 From: Jakub Kicinski To: Wei Wang , Eric Dumazet Cc: netdev@vger.kernel.org, "David S . Miller" , cgroups@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin Subject: Re: [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem() Message-ID: <20221012163300.795e7b86@kernel.org> In-Reply-To: <20210817194003.2102381-1-weiwan@google.com> References: <20210817194003.2102381-1-weiwan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665617585; a=rsa-sha256; cv=none; b=heAU1koxHkrO6IZcamfzBdTKV5DHPp9m2+RJ/Cn6XebtWCtLSd8E0ZmrXskGuuStJ6kyFY eYhTXGxhAFCuVIrLiVJZxSENr/c+gzcbtQqfEOc6eG6QA6X4/k06QgK3vtgrpvvVVv6PCy EXpMN7slQ/6vwktivw8nEINCr5ZDAwc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BJHMm2+J; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665617585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gdvLLu8/OH6S5DLbSJb8nirQlrO6sDGvdA5u8ljDL00=; b=5IN/S0/BSkJJIyDHhYl3ddBU99qcoWF3wrr1QGZ36VESs6xoh+CdyeZ+pCXVh3lsrgksYb OtPl7bsOemLRETcTDfp3C0hQiA7PJBQVOo2Pe3VZqSIij7L2NbbongBIfpb9ZEaRptfEqZ MuLcKFWILEFROctzz35IMLGJgdGEIOw= X-Rspam-User: X-Stat-Signature: a35mafecyzfz8gjp66gifwn1opug4bud X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9717440028 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BJHMm2+J; spf=pass (imf17.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1665617585-5160 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 17 Aug 2021 12:40:03 -0700 Wei Wang wrote: > Add gfp_t mask as an input parameter to mem_cgroup_charge_skmem(), > to give more control to the networking stack and enable it to change > memcg charging behavior. In the future, the networking stack may decide > to avoid oom-kills when fallbacks are more appropriate. > > One behavior change in mem_cgroup_charge_skmem() by this patch is to > avoid force charging by default and let the caller decide when and if > force charging is needed through the presence or absence of > __GFP_NOFAIL. This patch is causing a little bit of pain to us, to workloads running with just memory.max set. After this change the TCP rx path no longer forces the charging. Any recommendation for the fix? Setting memory.high a few MB under memory.max seems to remove the failures.