From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1588DC433FE for ; Thu, 13 Oct 2022 01:40:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F98B6B0071; Wed, 12 Oct 2022 21:40:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A9786B0073; Wed, 12 Oct 2022 21:40:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 072C36B0074; Wed, 12 Oct 2022 21:40:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EA9C36B0071 for ; Wed, 12 Oct 2022 21:40:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C8AC4403F5 for ; Thu, 13 Oct 2022 01:40:53 +0000 (UTC) X-FDA: 80014222386.08.F4EF2D0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf08.hostedemail.com (Postfix) with ESMTP id 7F750160029 for ; Thu, 13 Oct 2022 01:40:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 81720615AE; Thu, 13 Oct 2022 01:40:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E8E9C433C1; Thu, 13 Oct 2022 01:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665625251; bh=3ZCGToPaazLxSo8auNDegz7ZNYJoaGHGQK/xLD/k5Yc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cAqYNXvo5FQ12eE1mxDNT5gXxmkTLytoDOpPo9g0aqYCJsdWxA/DaZBASaBYKlRnp 82Ml9I7x46PwbneRMgA+JDoQlT5D9elUmpV2dHCfvFDfSHZ+W4MNnuORvj3hTL8QnV fx1lYjFEPbYOV1F8An+ZsHF9SLuR+qBZnvdo1B7mepPnKUdx8hsQ96jHn0r2KLbQYF Uy1QgQ3Jbmpib/p0R13uw5SmVGv9/l0PynGEiomvK30DmPCD1YxTHirgDW4VWLS85a GlNqljtHAtSliG/bxK156q5pu/oaSG8itOlMPdyywpGzP6YcSC6jyatydVie+I7js3 4gXeBnGxmwRJg== Date: Wed, 12 Oct 2022 18:40:50 -0700 From: Jakub Kicinski To: Shakeel Butt Cc: Wei Wang , Eric Dumazet , netdev@vger.kernel.org, "David S . Miller" , cgroups@vger.kernel.org, linux-mm@kvack.org, Roman Gushchin Subject: Re: [PATCH net-next] net-memcg: pass in gfp_t mask to mem_cgroup_charge_skmem() Message-ID: <20221012184050.5a7f3bde@kernel.org> In-Reply-To: <20221013005431.wzjurocrdoozykl7@google.com> References: <20210817194003.2102381-1-weiwan@google.com> <20221012163300.795e7b86@kernel.org> <20221012173825.45d6fbf2@kernel.org> <20221013005431.wzjurocrdoozykl7@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1665625253; a=rsa-sha256; cv=none; b=xTj3WnuENMwn5oWFD9+pf43q3sH9D/DG4v33DYPwKFi7zEZ87Xc24MZ21NWknfxSyqeDJd 2J89iEa4jjn080OxscxU7X73QK5YOI4q8FabJMmLUT2/N023EqJRXpWMnyu9qGzQG1EtuX rclBtC0KFU2sYSacAUSIXuhunwFDC78= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cAqYNXvo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1665625253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+GvMLUyWQ8VuQULCaUjL0ERYvr48v5bfpt/M7ICYaI=; b=fGl5LXuzHsh5Z216LptkXEXVK/FW19gH+7BakG/rIV7ic/KVWpoIVPg6PQ9HrcjrltbEFd xGiODqXET+0eWOPbpYOZI+nkBohgQ9xdYMh7Rz27B5ePA1DnxPQBV2dN/40/vgUBQunlDG Hefg05aWe/aOuvkx+LpbmUFkv0DMvMQ= X-Stat-Signature: kifpg68pq5w7s18hs4x9zahz1roaey3p X-Rspamd-Queue-Id: 7F750160029 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cAqYNXvo; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of kuba@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kuba@kernel.org X-Rspam-User: X-Rspamd-Server: rspam03 X-HE-Tag: 1665625253-969786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Oct 2022 00:54:31 +0000 Shakeel Butt wrote: > So, before the patch, the memcg code may force charges but it will > return false and make the networking code to uncharge memcg for > SK_MEM_RECV. Ah, right, I see it now :( I guess I'll have to try to test (some approximation of) a revert after all. Did the fact that we used to force charge not potentially cause reclaim, tho? Letting TCP accept the next packet even if it had to drop the current one?