From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF3CC433FE for ; Tue, 1 Nov 2022 03:23:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 020896B0072; Mon, 31 Oct 2022 23:23:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F124F6B0073; Mon, 31 Oct 2022 23:23:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDA096B0074; Mon, 31 Oct 2022 23:23:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CAD506B0072 for ; Mon, 31 Oct 2022 23:23:07 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A6B25A09D1 for ; Tue, 1 Nov 2022 03:23:07 +0000 (UTC) X-FDA: 80083427214.12.A4AFDC6 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 30967C003A for ; Tue, 1 Nov 2022 03:23:06 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id 128so12381589pga.1 for ; Mon, 31 Oct 2022 20:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hev-cc.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Ajwzvd2DlEsNlYdjJdz0Y0c5HDcHrscw3ru/rbvL1jE=; b=3zuavuORWtxjRw+Q79i7DMV1b4sy0ONQE9C0hGlSokrwUUqRfjWavq/CHhstsrJy+2 31q14t1hUHIozFlgaGnqE0SLzcvaohRJ+gc9ZdvHZcigLC2NKuKhQBnO0VGF6pnRv3Wl gYWSXZ02B4RymV54dkOZ3n/GBMj0y6Dut6MoZgMRU8v/mbtrAe2wQ0m9UzSDyzewKBV5 3+mx1ecLA+XMzgpgX4/udgSdEVOLNMWMaZSnQabnAoIwuncT4/Gs3RStim6wJOE1C7pZ nb0pM1E0ZdZUx0jMi4ngwEABGaDeGjKOS/L68P3G5dp7Qas00Iyp9IDI5z//RJH3QHXA FG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ajwzvd2DlEsNlYdjJdz0Y0c5HDcHrscw3ru/rbvL1jE=; b=4qZ1onTLj1PhdmC2qVP18C9T8yO3WeZCpGkRbIao/3Q1q962+MiwTBz0LMz09rdIV6 Rmd79X/u9keopUbs3r6rSblW2ts3bZySkKKC5TfhDl/mFfTrPk2WoDz7fcJ/+iR9SiyV /aZF7pgxutp/XZG4Ke5OsEOI7Yk3ZoIx+Ln1QlvteJN7KB7aStpuWXrmHAT1oNit8SA/ ETiRObrzd+BrW1/yC72WSHkbOksZ9Bkgb2AU5wIYeYF7qKfgVI8WUGscBT7v/84rd6nh 3En6gmAdWVFTvxtG1eWX5ZJAMk0BeHyCO/oJEWyhdzhlRCcW3NgjKJ2LWDMpMZrwE0Gg 64ow== X-Gm-Message-State: ACrzQf0wh55c6UnadQUmk72KsikVHtkjhN3Okd1sAa+AoohCiXwTnLO7 otPwxIKZLsU7AidHMOrDkdFGrFy+yT1Z9snMscg= X-Google-Smtp-Source: AMsMyM4tvd8J/G8vWWVacveLakR4PWeLOcvsHVzFQi5KcGxeZ8vao+4F9G6X4V9Z0UV0p/2P5kXJ7Q== X-Received: by 2002:a63:d211:0:b0:46f:6229:c380 with SMTP id a17-20020a63d211000000b0046f6229c380mr15252522pgg.621.1667272985753; Mon, 31 Oct 2022 20:23:05 -0700 (PDT) Received: from localhost.localdomain ([193.123.241.4]) by smtp.gmail.com with ESMTPSA id u12-20020a170902714c00b00186881688f2sm3417440plm.220.2022.10.31.20.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 20:23:05 -0700 (PDT) From: Rui Wang X-Google-Original-From: Rui Wang To: linux-mm@kvack.org Cc: Guoqi , Huacai Chen , Rui Wang Subject: [RFC PATCH] mm/shmem: Fix undo range for failed fallocate Date: Tue, 1 Nov 2022 11:22:48 +0800 Message-Id: <20221101032248.819360-1-kernel@hev.cc> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667272987; a=rsa-sha256; cv=none; b=itAhrDSYTKzrtPoMDCAFe3OJx1W+UkS7xOQptSJUIYr4NRVfPFijw3MToMj8euod2Cla/V Qk2jftlb69ErlZtMIrhkljyMYshzWxZfvJOc5/JhW6obee3MQI840p7lvUn/t+LVZqKl1R 8gLELrpSHFgbLmDs+wKd49HrV+JH6C4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=hev-cc.20210112.gappssmtp.com header.s=20210112 header.b=3zuavuOR; dmarc=none; spf=pass (imf10.hostedemail.com: domain of r@hev.cc designates 209.85.215.171 as permitted sender) smtp.mailfrom=r@hev.cc ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667272987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Ajwzvd2DlEsNlYdjJdz0Y0c5HDcHrscw3ru/rbvL1jE=; b=EiHQaiQ1rqXthqXwmCdfZtAAVQCzqEbYlQTQnqL+MBwKSdO8DlMMpRyeSWfiNOrt4pjiUW CFe6gvgBm8cBcBs4GqEKLCLXMBdMZWXSuO+fBuqrEbROAG351R8Yf1MxELzaZm5f5wzHMN uy3qOgFLWdYl7rNWc3eSPRaQJ8prtKU= X-Stat-Signature: n43nu3o7fzk9rujtxanqzn5rju1fxje5 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 30967C003A X-Rspam-User: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=hev-cc.20210112.gappssmtp.com header.s=20210112 header.b=3zuavuOR; dmarc=none; spf=pass (imf10.hostedemail.com: domain of r@hev.cc designates 209.85.215.171 as permitted sender) smtp.mailfrom=r@hev.cc X-HE-Tag: 1667272986-303358 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch fixes data loss caused by the fallocate system call interrupted by a signal. Bug: https://lore.kernel.org/linux-mm/33b85d82.7764.1842e9ab207.Coremail.chenguoqic@163.com/ Fixes: b9a8a4195c7d ("truncate,shmem: Handle truncates that split large folios") Reported-by: Guoqi Chen Cc: Huacai Chen Signed-off-by: Rui Wang --- mm/shmem.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index bc9b84602eec..8c8dce34eafc 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -948,11 +948,13 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend, folio = shmem_get_partial_folio(inode, lstart >> PAGE_SHIFT); if (folio) { same_folio = lend < folio_pos(folio) + folio_size(folio); - folio_mark_dirty(folio); - if (!truncate_inode_partial_folio(folio, lstart, lend)) { - start = folio->index + folio_nr_pages(folio); - if (same_folio) - end = folio->index; + if (!unfalloc || !folio_test_uptodate(folio)) { + folio_mark_dirty(folio); + if (!truncate_inode_partial_folio(folio, lstart, lend)) { + start = folio->index + folio_nr_pages(folio); + if (same_folio) + end = folio->index; + } } folio_unlock(folio); folio_put(folio); @@ -962,9 +964,11 @@ static void shmem_undo_range(struct inode *inode, loff_t lstart, loff_t lend, if (!same_folio) folio = shmem_get_partial_folio(inode, lend >> PAGE_SHIFT); if (folio) { - folio_mark_dirty(folio); - if (!truncate_inode_partial_folio(folio, lstart, lend)) - end = folio->index; + if (!unfalloc || !folio_test_uptodate(folio)) { + folio_mark_dirty(folio); + if (!truncate_inode_partial_folio(folio, lstart, lend)) + end = folio->index; + } folio_unlock(folio); folio_put(folio); } -- 2.38.1