From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A147C4332F for ; Tue, 20 Dec 2022 07:29:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1152F8E0002; Tue, 20 Dec 2022 02:29:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C59D8E0001; Tue, 20 Dec 2022 02:29:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFE18E0002; Tue, 20 Dec 2022 02:29:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB3468E0001 for ; Tue, 20 Dec 2022 02:29:18 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BBA8B1601CA for ; Tue, 20 Dec 2022 07:29:18 +0000 (UTC) X-FDA: 80261858796.30.5C1A809 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf24.hostedemail.com (Postfix) with ESMTP id B750C18000A for ; Tue, 20 Dec 2022 07:29:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lgr0UuGP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671521357; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tc9tut3jvpo1xnKA2SPLUBExCXhvJ8ZV5noBTcvwQNY=; b=lNrmY41OXG8AOoQVZtaZudX0tJQMMbxugZ3/iTYvy4o8kqL8d7agxcZ6xBmTzO7PTz4pDf 4ky/ZlDMKt9zx2g3pbUyZHiJKpvXzYgUqtkboqFLsnOTemGapzsY9C+f8+03x3U0dELjLE NDrNtNHeql14lg3bQ+FY+MpgN6XK3aQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lgr0UuGP; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=chao.p.peng@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671521357; a=rsa-sha256; cv=none; b=hn2/5QnFFsp5B6QDSPpV288wnvDUUDC86d8HT8izNYkqpbpSfhyKp6Rz1ZbOeGiOrSmxB0 7dhrn4HuRZPQU4e5bhpbtnQGsB0Gtj726hCWXz6pNmt+lWqzagUwCgPJscYc4uBNfzWAR/ XhSP9wzOQZXipDd2dm8uJ4bVeoSmwCc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671521356; x=1703057356; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=fjNSa0+921I8s8ST66iQKKAKKNcHFJo2C7vp0DyF6bU=; b=lgr0UuGPx70LuoildilFsFF9BtJE5S5wnA+VUepf1VCrkPWsm53bOats sz60KiD9EpjCXYOPoD5CMg0h42urhtT2zprOJw9+1GzFjq7Qp5jSQuwJh V6hB2sBjZ9zVDdLRA+Ooqmel3Wss4tsKJb08AYP1km23WQf+59RRydKXQ VR0LS3xwtlm23HL+YkB3rTb/z2P+M98JNRZuOl2h9lkyMkpKe72D9qgtU 5V4xtjor5uU44gb4TsVR9emv8xJAQC69t7Oig8nYYNkEQpfMZnxICyl8Q k3wMyoKk20h56vaReb3iwXLNP/tyLb06AhxEblZAMymUGGjYm7HioE2wR A==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="307230630" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="307230630" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 23:29:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="775191645" X-IronPort-AV: E=Sophos;i="5.96,258,1665471600"; d="scan'208";a="775191645" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.193.75]) by orsmga004.jf.intel.com with ESMTP; 19 Dec 2022 23:29:03 -0800 Date: Tue, 20 Dec 2022 15:24:46 +0800 From: Chao Peng To: Borislav Petkov Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes Message-ID: <20221220072446.GB1724933@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-3-chao.p.peng@linux.intel.com> <20221219081532.GD1691829@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B750C18000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: i5kk4zsedqm6hgimyc1kwmt9z94ohgdt X-HE-Tag: 1671521356-99923 X-HE-Meta: U2FsdGVkX1+xekb+31VBYOlUHW0nRdC4GHl1DFKee6LM5vxi33Xl44eHP1uQP3OY+9nhQYY7DCfOWeN/r7TY2e6lHL3gY5Ts6ILqCu0SwYUeJT31bhQ8bD5xBzxzYXxPR2AIi8lYXJHT+28zGLvGYxD+hiBoXNK1qzK2T8kFdcVP+lybPxG4JdCsOpCEvdkALnjsNalG2zDRdYdJwSQe1EQiOVcp+6yMI0MqUDrHb9nuqEP0Z7e9b+ey+iLfTB49ZFM6pAvaFR4TDn84v1uBBa90E+CPTIzO7xAV+J9vQ+RpeDxrHqoPAiH24te2PhVj5BdZ/k7ZP4vyl0bFvyYrYOpoq+6LMV7j9XRl4zREddD9vYHK1CrHysiPgzNejV3igGfYxJm0yf8AHQObMZvPqIWhkHBIi4/knX/K0R2o3I0KeS/IIfAAO89ZomkmKWu0T/Zjwggr1Kd+N8SVZZSPDgbhiCs19FR5V+Rj9Pi7CEwmbuTRsb8O3JkjfpIoYqtScOAgDXYtAL/6XkapQaBbq6yzgx8wtPPpmvPf70gizf5/fHxmh9lsF6SFyamlTuQHtWe0sxNmoTHM6j1ugiUn7MVUj1Dd0C2GXkeHOvXGkVyRhCP4EUFdMCKxHGeQ72MgBeZThO3jKagPiRzH0FpLLHfwQncTv92Ur5jttCVWmB1lc5UsJFzVeA3+DEAlz4NLUD7ai3GFbZQ2+V8qogu9KomUw9PVW7F2zd+YCBt1GReHer46p+lqaaRF3uwHue9etEkQCn/LFFVFuTjIohPkU2zpjaUWtM5jtkSp5/bCZlwGXrXg+8UkHk2cF6nVOrSxIAcR924k8GLkxS7fquXjgcSSTTYv4RtClV6B8qorohCFlt8TTzmSrchi1ArQQVulJmBvheT821eIHRpBYuw3tuadlVDmeuEpA1dbT2OXJHjDrXJTzHi3nOtY29v+eKdg6ad1UruI3d4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 11:17:22AM +0100, Borislav Petkov wrote: > On Mon, Dec 19, 2022 at 04:15:32PM +0800, Chao Peng wrote: > > Tamping down with error number a bit: > > > > if (attrs->flags) > > return -ENXIO; > > if (attrs->attributes & ~supported_attrs) > > return -EOPNOTSUPP; > > if (!PAGE_ALIGNED(attrs->address) || !PAGE_ALIGNED(attrs->size) || > > attrs->size == 0) > > return -EINVAL; > > if (attrs->address + attrs->size < attrs->address) > > return -E2BIG; > > Yap, better. > > I guess you should add those to the documentation of the ioctl too > so that people can find out why it fails. Or, well, they can look > at the code directly too but still... imagine some blurb about > user-friendliness here... Thanks for reminding. Yes KVM api doc is the right place to put these documentation in. Thanks, Chao > > :-) > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette