From: Liam Howlett <liam.howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
SeongJae Park <sj@kernel.org>
Subject: Re: [PATCH] mm.h: Fix "mm: Add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma()
Date: Tue, 10 Jan 2023 14:14:29 +0000 [thread overview]
Message-ID: <20230110141421.o23coymw44jga4z7@revolver> (raw)
In-Reply-To: <20230109151512.6d06b1d73895414885a698d7@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> [230109 18:15]:
> On Mon, 9 Jan 2023 20:53:22 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
>
> > The extern definition of __split_vma() was removed too early. Re-add it
> > and remove it once the users are all converted.
>
> I think I sorted this out.
>
> __split_vma() can be made static to mmap.c?
Ah, I don't think so? SeongJae reported an issue that I caused by
dropping this definition from the header before mm/madvise.c was updated
to use the alternative. I think it needs to be in the header and so it
should just probably be there until the function is dropped entirely
later in the series.
next prev parent reply other threads:[~2023-01-10 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 20:53 [PATCH] mm.h: Fix "mm: Add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma() Liam Howlett
2023-01-09 23:15 ` Andrew Morton
2023-01-10 14:14 ` Liam Howlett [this message]
2023-01-10 15:06 ` Sven Schnelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110141421.o23coymw44jga4z7@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).