From: Liam Howlett <liam.howlett@oracle.com>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup()
Date: Tue, 10 Jan 2023 14:21:15 +0000 [thread overview]
Message-ID: <20230110142109.gphhirh7jo67br6x@revolver> (raw)
In-Reply-To: <20230109234317.1408-1-sj@kernel.org>
* SeongJae Park <sj@kernel.org> [230109 18:43]:
> Hi Andrew,
>
> On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > On Mon, 9 Jan 2023 19:22:48 +0000 SeongJae Park <sj@kernel.org> wrote:
> >
> > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
> > >
> > > > If an invalidated maple state is encountered during write, reset the
> > > > maple state to MAS_START. This will result in a re-walk of the tree to
> > > > the correct location for the write.
> >
> > Can we think of a Fixes: for this?
It wasn't really an issue until I wrote the vma iterator store
function.
You can put this before (mm-unstable git id..)
9df3d25a97ec ("mm: expand vma iterator interface")
> >
> > > > Link: https://lore.kernel.org/all/20230107020126.1627-1-sj@kernel.org/
> > > > Reported-by: SeongJae Park <sj@kernel.org>
> > > > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > >
> > > Tested-by: SeongJae Park <sj@kernel.org>
> > >
> > > I confirmed this patch fixes the boot failure issue. Nevertheless, the 'make
> > > install' issue on my system is still not fixed.
> >
> > Is this a mainline issue or an mm-unstable issue?
>
> It's mm-unstable issue:
> https://lore.kernel.org/linux-mm/20230107023954.1841-1-sj@kernel.org/
Yes, just mm-unstable.
next prev parent reply other threads:[~2023-01-10 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 16:55 [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup() Liam Howlett
2023-01-09 19:22 ` SeongJae Park
2023-01-09 23:40 ` Andrew Morton
2023-01-09 23:43 ` SeongJae Park
2023-01-10 14:21 ` Liam Howlett [this message]
2023-01-10 23:18 ` Andrew Morton
2023-01-11 1:07 ` Liam Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110142109.gphhirh7jo67br6x@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).