From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE811C61DB3 for ; Thu, 12 Jan 2023 20:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 770048E0008; Thu, 12 Jan 2023 15:15:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F86B8E0001; Thu, 12 Jan 2023 15:15:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4611B8E0008; Thu, 12 Jan 2023 15:15:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 286C18E0001 for ; Thu, 12 Jan 2023 15:15:14 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0A516AB56B for ; Thu, 12 Jan 2023 20:15:14 +0000 (UTC) X-FDA: 80347251348.22.B8B7509 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 5820640004 for ; Thu, 12 Jan 2023 20:15:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FtR6V7iB; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673554512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=Xy9+JvHHctWh2TNOLRKTbmGfpkTQoSEdFlJnj8l2Ws0=; b=Qh7k076C3UidII23vH5C6+O0fvX0flPX5kQKMTsAblLdoO5Fjb3pwrsJaNSfvyefIX9nPT 2QHOZW8ug1Nj++1bZHlQNECmYES0861U/FtCA+2q9HGlULVrsGV0BrvUBlAjmGe5uURqm4 PnugniIpMDMTidL08y8DODMw5IKSZgk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=FtR6V7iB; spf=none (imf01.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673554512; a=rsa-sha256; cv=none; b=JffFa2mOCnrKdp32zG0mXoKatWxO3vBp8Qpts0vjXRG2BuUo+ow3qMQEMuHSIINz0bY7P6 RV7mWhS5g7y0ivQWlWxmpBsF6x9PEI/MrH9qJLIZGr+/zHOj6HY7c7dpbcRazAF19hWZZ3 rrAvCXJLFGgz806UJwapgC1DLpzADcU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=Xy9+JvHHctWh2TNOLRKTbmGfpkTQoSEdFlJnj8l2Ws0=; b=FtR6V7iBnq/tJFzxTCM/j78unY /49Ec+SxLqZvSLDvUDxP80BJ6CshhnFTYKUGLWe52tbZI+g3IT66NcxuF4QJLpXQFqUnB8IYsx7tx rvkkcM1E63xXLT0vxkkEUcwCp+mVujqeEfWYa0bi1HB5/HtroXhr9t67Q2WalkYHntgPdGa+81VAW CoQSxFuXnJjq3lUVUMtBhxrXycskxIxMnWpscRtmQgQtCtsvQQolDB8Is0Qb3ixSa2+dLSsu8VyyZ Ux3DSJ5librNMIilmqzR2tChKdku7Xq+k9WLJD67Xsi7/M3iylmdycXuodbdivvM3FwM/ipJb4qqQ fc1Tmr7Q==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3hX-005OcM-HX; Thu, 12 Jan 2023 19:57:27 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E0BF73033B9; Thu, 12 Jan 2023 20:57:12 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 996452CCF1F4C; Thu, 12 Jan 2023 20:57:07 +0100 (CET) Message-ID: <20230112195539.576412812@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:18 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 04/51] cpuidle: Move IRQ state validation References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Stat-Signature: 81w5s9mjsy1fwf1tziysxoae7t7d8brs X-Rspam-User: X-Rspamd-Queue-Id: 5820640004 X-Rspamd-Server: rspam06 X-HE-Tag: 1673554512-927362 X-HE-Meta: U2FsdGVkX19D5VpoyO6m18diqv1p2z0m/4pmFVNRIV226x10cay9cRocIaEj+oAW9nJ+RzLOi2TvqsU9ynjMwLuggyHzctwxGy2HbL+GdGtKV9iun0xWX4q+ZjWuHVyJbdE45D8tauw4op51PUsY3/TT1oj22YZlbjl15lLVfD1r/4x9MPe6LWD+eIlIMC7uxl3605jBvIy5LXC3mFDV2rfQa0yG+9kgyngB/OiZC646Teg2INyzoHpekA+CU/r43ysVgzQIBG3sOxoIkddLyddeRnu1fQ+zDEqB9l1VgV8OJvzukwZ8BRRqVbJbXY0+wZgIr0olWe+zkhDxacBb/C6CG4DLJKJDxJmQTEmfWzZW31DDqmHH41tATA+k2qtJktjhtblvA0Z4j5aIpcStNwl4FhsRD2giJvcM5hMnkwSLBRTF66ugUgR8rhMJ3Tq3urpbIQjvmI6QQNu6OcdjXiDxczdcq09wqlTLTS24hMQgJRYNKqSEBAYBmXoP7DkjGlyYx4B0Vm14YwM12m1weNT5HsJnUWokoP0XoPzeRw5+TpPmtI/tCav4K0yViDPJ8MeSrV2ctkvzT0LeIvlzyti2oAK64ZjJdoiohHFn681PKEZgPsafnzrpjAPVDVEs4twoQaotRcHLiH4WtWBSNymceLA15BH7DuxyPgxiaaVA229NZpECnMcDGVtZDtupkfirKMLBc+qoeIfa2pygO0UQSvmdElpMVIst7Az6A3jSqs4hVp8UKHZFSiaCLoJrSqp9mcItyus5V02JjtwGPm45bRpT7MEGAbcWdvseQ4DDWmX+IifNM4D/BUJWK0mquZqFpwChAa8z/M24TxAR8sBDrsTIhQ/z4uinsbwRxjxAnPwG0EnDlVtgccjtQc29f+Npq7b0zXoye95ff8JI/xKMT4TbCusnyDlwOE6QZP5F3k3CNi5JO21NFIziIKDfq93snr/3TTZaVO1aKA4 idt2JUwv i/s7AWUdbDqBwU8/8wRTGhLOfnEcyzygJV6TD12IVzH9UYFdmtY/aesXNGZ0LwrEcKBSuoxKcGikv1eQLemirH/F5G9Y1lcT/mU3kxi9QiYz4kQKBjpyhmFwFUmYEFboe9iNv6fZudisEU9337wdPnA87wVyGFNavOEjnWfSNyGtASRlFwSTw5YtrQ8AuX/Au10A9gzQwxx7/1BfEX+u8i8dU8wTst/0Cn26tZWjQdN8OLEBGlVr0lPBqIoRWay9peHb0jaGbn+iHH8bjsOEAEAQBEFcD386HQ5QX8K9RnGdC5d3Rc277kWK0k06VN7z90PjgESP3CQKsKFy6Y0+JOSNLwkjgDZpN8ABpZem5BhJY11i61wMdDa7/cTSt8l2MEtCUYLqflt2oWQQlk5C3aJZE+KodCHHMJ6drpRAKPlc3KPODuJSre+SThGzmiU7ZkjMdjhS/ZC5FQMqVKsSMfFf5ftC6EKV+pncTq+qJ4Pg90OCeuZpsfNb5xe6cH20JwWC/1iXEV1biGRFfqovQIcKEZ0E/0M5Yh1W5zUlJhQeBr1xmklaELNs6mh04k0U9VoBmymRstQafdtG/EZN7gwxXPCt2NUd/50kX8rLCmiLMNAzB/P+llQBRb4ANwlsiU9/oKlbg/loZcshemsbbU8/hdcssDwYEAirMx1qC7RUEAr9k4JW1lKwx3rJiOCk38TvNAsKOD3zKnxAhCVxvQrt5EWhdt4mwP30tE4RfCArwnuwFqLZNlebkeXtyFv+uB/mNnPjIZ93iPvXR3Jd9YeR3Pv1gGMXnm4EvojSXO7PFHF9qymAjiTIGulmRiQuuyRxf4pdIPyZMH8nYAizJFpzh9MzmvGD4GCZ2LtQzV37FXYRNCtgo8WurYrPROAOac4r1bxVPNaaTc/PXRwMiNzEq8kcCJN+nKguRLOO36YwD44svY9M/cbmK3Vd36mRhoqIOKjO6AM2QHs+H/0gYLWystQKd TCDKbO1y DHtmmedp9k7lLDoN0zuz8YRKpkqrgq7rRJqyhQY1lPsdG8XIzPhDsWy41OG5cuxBvFjGo15I0B1iDdCZDQaT8BnJbCzyyqXmiVwHu1XkyaxLesQyHt27TVXMGrVnVpDspbr1u3VczKx/u3xbdHlwK9pCh8vLEBYkXM2F2+Uz4WabfW4BENwfp3w1xYl6dFq/+nW/Squm8zIzdm1DtQhAmz+29upaPopQQLlNkFwYzhwjaQxcsPvGECFKyGIXJpGWbve53MYzem7SNz9gyr9N9zRhxNdAgyxYYd+gDeeAGDW7RmL5s6qOuLyeutr9D9YtCGpcLULyfW2t8sv03/K5OEMIo2MMnCZYu42EpYfAMijwb9qD90HVOUhuFntc41Q8MGDrm+yQ4qTcGEwinlDG4w+BSU6tjG25IKl/aGTdp7Py1aG7w7i0qdPpvAseMOVps8QqtZPlhWsh+k6cHt9gHwhNzhwkm9Gwz7crnCPPm77xYOoFzJy+GUkIH6zGrGwvC3iaPtoxgaX1R4Ep+ZXy9h0/fWpupOtivcb1wUeBPhM3s4qDZDqINtHQkOGLL9nvRxkxRjWeJ/4NZ59TkOsVepFsiYqTmGmMnMrBuj1xqVyS7rZ7PTLFxjvhEeVcxKp7BIpT+l5zp6IkgUokk2byyY38TXIinH2AONsa6I50dNQwxwGjLR11cMV3FhlCY4VkyFc9NzsIsnZnZRkISTbLkilQqZw6OrOn6l5aTsNTp3j9U0xv76XQgETNWIq5gCwXiyTLfJGUz06PgHl5ZUUVACNHqom/R2ekwPMUX3A5Rmgt9OSNAaLywbsPYLZ7+AB8Btarhu3YdVWuooxo94wJ8/3UYgwNdRZuPOHGppOpaGJqjucDqEyz1rTJGrskafAbTJHgDbX010vOf0KZWrqZa3bnld7Y4iIf2/Ulv4VvaDqz12DN3Yjpdz4SbZDtsqyR+QpHvU86IDlSG0QUXxalzAhqtloSb 0TZ9hrhK HVFMdbLkg3LHilRa7xnFLY+I2qz3JYvJQm2AA75LURfucxRas9cBHVnX68e6zWk1iIrVMiGaP8rJdS6qM5OBOP1kbYKK1+YyLNtsEk+GGAZQEw0Xj2Jckhex2K/es3o50KEKoyyt9GOEwa/wtzygfJEtsbYK7Cf7yzeanNBOmn2P8YHXrBPeJzQJ2SxKFw+fy691/B1V0n8xJbDJCTVjDOcR9/6MkmY1HGJXFyIVXg//YI8GO/yPD00WTEYLq2aHVkQsRwFDRWj2bzBvB3DrYPGKhFzb3VKSvXkPWBxtmBruNWIDwiE/CK4XnLbZ0CCs9TKpKdwEhUjRfdr1tPrXdhP2s4FJx5OWRYy1aw6K60vf+PhuUNUX+mD5hyKTbCEA+5KGnu0RW9jKuTTU+AWETcpCJeiuosV0fpk3SDN+ojz6AUvvgjW/6z2hJzbvOMXU32bVlBe4K2VeZSp9O8mJtRihg6yZJl3DCCo5F0jzt9aNjtrmrRgfzFcO048c9QMtQUT7CaR+hqsUySB5Ze4aAtTW2pIxZgOIHsCPS1QDhHUVf9M8IQEJSLM+T0gDC6OZdnc+VHxPn4M7b1Xt7QxSUE5Ubm6KOZL6ajzKnQnDo3kDwKLNG5W1LrsfxbsqfNVnIxX5iHrIVebjMpkevqiEohGJkM3JJou3RIEXZgVPY7OP7HZOSl20mtmyizD3TLpo1meH0ZLyZCKKt+56jh/07BXdkCjmv0d44MO/Srf1a6LOH7oeAsoASnDRvyIbIngKiWRKFHAkmu59FVqmTVCuXk+629p2r1DWBW8llANX6f4Ox0OzAqfcVxhhUK6/EcwWw93D8TYEoc0OZRrCR1sZiF/Z+n33JqMgS6fE4Qm1REC9YQVZy39GnIAF3GrfTvdLSNGCjrTyaI7MhXI9AlJcC+BakZnKQid3m8Mk8JJHg6NR5a2hZKPKosfJh54NuBlr15e0M7WxnhPjAXxxRjEgsONq5hTW5 KsgKLLZy 0HhPlzbD9f2Tm3o3ySDlCR2sgCmaWzudA9YJT22qH92cKAktQmuR/O36DF8EuR/8GORQ+SjgKqNeeIYbpx2isnhyyY+mka3Py4VSyqYGPs1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Make cpuidle_enter_state() consistent with the s2idle variant and verify ->enter() always returns with interrupts disabled. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- drivers/cpuidle/cpuidle.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -236,7 +236,11 @@ int cpuidle_enter_state(struct cpuidle_d stop_critical_timings(); if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) ct_idle_enter(); + entered_state = target_state->enter(dev, drv, index); + if (WARN_ONCE(!irqs_disabled(), "%ps leaked IRQ state", target_state->enter)) + raw_local_irq_disable(); + if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) ct_idle_exit(); start_critical_timings(); @@ -248,12 +252,8 @@ int cpuidle_enter_state(struct cpuidle_d /* The cpu is no longer idle or about to enter idle. */ sched_idle_set_state(NULL); - if (broadcast) { - if (WARN_ON_ONCE(!irqs_disabled())) - local_irq_disable(); - + if (broadcast) tick_broadcast_exit(); - } if (!cpuidle_state_is_coupled(drv, index)) local_irq_enable();