From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2816C61DB3 for ; Thu, 12 Jan 2023 19:57:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47B6E8E000A; Thu, 12 Jan 2023 14:57:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D79A900002; Thu, 12 Jan 2023 14:57:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B72BF8E0009; Thu, 12 Jan 2023 14:57:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 80D5D8E0006 for ; Thu, 12 Jan 2023 14:57:25 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 452A11A0E0D for ; Thu, 12 Jan 2023 19:57:25 +0000 (UTC) X-FDA: 80347206450.13.797C2B9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf15.hostedemail.com (Postfix) with ESMTP id 2161CA0007 for ; Thu, 12 Jan 2023 19:57:20 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gQ7Q9Sfc; spf=none (imf15.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=Hsr5V6aaf/kVSU2t73jNDRAWfLY8tgaZMY/8xmM8jWo=; b=Wk8A4dbC5ljozANN/2b0LY9cxKOalXaZMFxfp13dE/0uL6Db9hTfDUVE9heawdL2Zm2YIf GTjBaC+CkakyVqqnrijcPx/OY8C6htcBWr+LUmr7LIuELOR7TlNVRxr2WpbywmuW/soHCG MjKtoRlBkpkLePZu0nym2W+hdMQujkY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=gQ7Q9Sfc; spf=none (imf15.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553443; a=rsa-sha256; cv=none; b=ZAv/C/z0OQ9k+ybuVpnPNTB8uCvikz1/a8N97DdMEKVYI0uMzMXtLoqZymBpgDLWQjNbDa r5Nyy6tdNQJ03/hnMbVmq/zc7FeNY/qE5bG283kDG8qLL9M4RjxfWLMZlyedsOSp3aBszM cpMNf7DdObHvuP+3mYtFH2owekxh3bA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=Hsr5V6aaf/kVSU2t73jNDRAWfLY8tgaZMY/8xmM8jWo=; b=gQ7Q9SfcfOCGLlvaFWMPSlQDV4 uKjocE/2Y34Nr3Jz761/H3K8ref7D/RHB23EoGkYYy1xOk3Feint61cmEzrTeJs9pKFsRiW2qqfOc a15g0aXUVDz0ZDo2MzRyxqBDaXdm6wfbxfKkhacFzf0dnqhRTBbnGYC0Ol79TQuuLMUcvUsmgrQsq Yw8OLwDnAiMOrgLy6Ivt5nddQwxIy8BHKaVFy+WqtLrCrntFsEUj0zjrnvFhZolV0YjTu4WNDYy9/ lDKMy9PbKPpnqJnECPubZ+WdVv92KEL7klGQq9pXFCJdS/Q4cXnTA6nMiHYLM5YqQGCUzlZ7euq5h XbhFNewA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pG3ha-005OeK-VA; Thu, 12 Jan 2023 19:57:31 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 7A97530342E; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 09BA02CCF1F7F; Thu, 12 Jan 2023 20:57:08 +0100 (CET) Message-ID: <20230112195540.743432118@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:37 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Ulf Hansson , "Rafael J. Wysocki" Subject: [PATCH v3 23/51] arm,smp: Remove trace_.*_rcuidle() usage References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Stat-Signature: ar9rek37hyykg6puyypidfmzhg3sxkup X-Rspam-User: X-Rspamd-Queue-Id: 2161CA0007 X-Rspamd-Server: rspam06 X-HE-Tag: 1673553440-63017 X-HE-Meta: U2FsdGVkX187wj70Tj60q64pOSZ6B/qsYG4kc6ZPqlFTP5nscehcXgPTaoaWdD+6RzwpcHUrHGXySJDfo2Hi6apvS2Ti5c9GfDXvt12Kr4zH5MdwdGkji9mzigr7l5ZA+Gve/DEKkzEDGFajeBdP/9OgOCm2gyDVAtDtIGGyrcYDBVJtV0DxNYQLOCdqz7rAKwx9m1DSvXrDydGAFVRUE/H4bLXX4t+qG4pRoZeacBPNie9YRvOgDNu1przVuVg2gYqe4vTNMDKuoEgyHfzIw3hgDmpkQ76WuoIsyrouCtYCVw8EUQZV6qNGKgKydFpA9LupTtdD3QplP83iXvb0WwTF03ipYblrlc36qUQVKDA3VurFqzYCMc42JDtBG6P2SZdJz9ENT23BzIP6IJ3RQrTX9BjXHpWLFtfD16wSa5bthsP8/1OYtjcEEfIgdCyZ/yP4Cxwjk2cV/pt+fhMqTHv3RwpnR4kVqzTW+q9DlwPnOs6wKv8J55JGax6UJFPx/anb/37zCAzBNcoGRhP2su52H4b8JSP+nfCciBGUaiy0Gaykf3zfC8VJQORnJcxM916lprUNoBsDXYw2ClMsBtFJGH0afhOQQcn6Bi9JiKR8MMVwUAOEzJJbwRCMC4s6JRNJllymSpje2AQABL9dnbFrspbt9DdCq8Ch4NGFNaBMm+h20OQ4GKKa3qNWFdPxQ1g4/XsZEAyLmETAjTXRouxuCujZzWuhruYa76g1wncnEGz5aEtlOg0mM7NXVbeFPx/wKItYnj4bFcrxw9rhZ5g4pvvsI2p+Sa+Hp2hfwzKwyuc4jHZVoGPT6Yqb1w3rN/7vdMJx/VnoeWzMJ8MbjkL9UjkYav4BhzwMe5aJOiSDAHpkMgOw/4SCGU3WC9/DV265JyQvJZrO5x7Wg+DCDPUT6tR5fpi/j9jqQ/zN+5sLx+v5gPmRW6DwMq2vf6FTJy5KIKwJS7bu9afNfy2 WT5Cy8hP 6hf1n0+MCTXI6HIZfJ3u5ozhOvqXAY9O7JUyfrCZTisbACH7ivKrFRQvyWhCipRED/79zV0xPtzzi3xhQQ0D0rHWdUC5JwCLiCUeFB+28g8sCwjNMUPmhrY5LV5d38Lg45oTW08iJ0vJPEpaYeJpSDAIly8LbObtbVZ5xcMDVpQN6pATn7kKPw0sH3GcAhGhd9v+9e0kItMr/es7M2r2mRUkKCR1mPcpZi67NKxsBo7WEAYPFus3wmKxvnL6veF6fANwG8u64gi2OWNJMw0zOPpRDMPY22OQRd6dOEmh6agOG5cbARWrd4jmcQ8u/0e57/Ww+V/HvPEUGvkw2DN4Eew4XgzxHJw1XqSDWqWvO4yWpoi/YrxNT3tOFSzTAQTLEQTJtgPMvL9xWjmCJA0htrdtrsXugQKAeGtJoEnokivARpcWJl5qA8O5A01b0NGSW8ktWzWK4KLYZ7lIhayweGcqRcs0vjtp+wiETBAoRyxxyfszIgTc+pvlgGetSYEhkW6Rb8pYa6m7bY7VwyowIQ2vgGlvX6JKBokoHaWkColcTSk8i10w+iBPwYemahltaiivWDXo5T9qyrqVWI95tYJNFlO1zhIZ+7x0eqvAQKgp+kfbfHQKE3LBQuz3YyPu7y6V9HKd8Z4P9tga2TvpOrJD7vSqJiUqB7LUsPD/FR+0v3xJNM0QEi0vVQWpqJBeMwK9R5QblzD54fIJVBSF83mtLsNwf+k9+6/5nHnAQqTvKASoz27EwQCnUkoXUBlfHNkO8RkqzQJ9VYsOStw2SPPmV3y/PwCnA+W8LVx6FL8/pWMf445aP2n1S9zX4BCoAH4kbXEHfMUz1Z46oayF9l2DHMMtnl37wJPH1C8SVY1exzva38jTDbdnlSmPkiCFhGUTJg+M3oheRh83Br4X7XFtmBHyORDMgrKW9M7fGq200i2Lchj5pWhu/22iQFqB3LnJXZpM7e42mVLe/WhiVhQXgdKKj lPFtzSLc H93c93YWWEhg5gOzAix+MH/jycIFZzXI2Te3O8kz/UsMEar3g/nOPXEwfhEOmMjbSsf2hsT8eE9XuGcR7OzIU1j1gdWiO0P4D7MGKEDGbf/mt1T8IDcnqAbADUgDK4YRtg6dEPe0uLX+3ShPW0UdZlhHl1co9xIZlCV4b5+d7q0bVru9vCR/uc0ke9rHHf8VQwSPt9+IREFq1llDnPVcu2C2/aHRgsKmnxSgabqvw5eJmC+B7TZ8+WbuGhH45xQd+t4g2X/8rWsO9aYz62etd2mumaP4DIhPCFBQQqIHEYdawjPjr3/ERNbVMpH4gmNXA9FNxugezW4maCT+YbIxjwX/XN7FuDMsOWVGqfBoqGuNj+a7wy5RoLuYdLLScyF4yX28OTIOUxdCltKkjXqDlkNawWXocadppctjeSDftBh2W208RP27v77lSzAjWNUTRktr2yI9MZAuomB2ASC99GWhvCR6GAQ/SIWbbniuaMOLuBg5mchCrR0d4+gvIRZwfGDTZA8KKIiyv2J0KOvr3zVOJBQ77F/vMQayh0agmNG120zmrS/PmLCkenuqCPCgt7zqjLn2E7/aPgc4bD+D0bCdi76QPLOnUVEpF4iuSGY8wZn0t+qkAsMdb4wo5acX+XZnVJWVI3H5AJS4tdeyBXi92+/dajb6/mjkNGg2R9pfta0GYnkvJdRj3kyEK27nLk6eBIeNW5+j/GmaXW7ZakpPwF1VWzgi8NnaSyxHB0Ulmq87SKNHufSNiblgZz2LR9qcCBOZukD1zkstvsyUuPtZ8IpM/KiNXvTZRXngidjOP0C+jXYoTpr/Ip1AHvNXVUF7wbMFG35g9m9+n1Nu/zBcMcrMaQ0okGKwcy7j+n0TqDMS9dQmEhLP/SbFpjdTNWSvUCYXtZFYWvmyCVKdgk5hdxzX0ZGc5L7OlXZzUimnIW7Hvj8PskPejZNfztcEgne+JbjOsNKXZ+o5O52Y6tXz4Q6gD 1V0P9Opv zgA5a7Url3ebFNk8UUakeG3B2t5utadDf/rMHCw8wTjaEXj3dJLXAYEVUqTryIn+/Cw7biOEiZ8IHyMa9sIgxj58XWc/HJ6nAMpDnGDeqMS46ugpZZeKwcvSdWPAyq+HtJUOpkOBkHSXNDvcMjpTOiMV/a1XmjNvOsNZj9W4A+0UaJNXsxQqfbXgF4fQykIkIbt9jE2xZcMry1aHnQLsb+77JwnqnfCwJpzyIBnIS4tCkhQrkMiKw9MwWt4+yQKk8+rSF435DaZ2Vx2332eteauUDF5gBNjKdydHE3Cr5zxFvwi0UHyqxqcVexrE3b2DJorS20SfA2u7lUnrjSAZpdyPsOONf3WZzk3kgDLyV5wfjQaVJFularc7F6QLBM63TstlXZBJeF63YrdW+G4Xivz7haCTiYe3eqwpG8x86QkjV9kbBUEuPZdpmW3hXgoKmtKPAGBKiuv1Clw8I7fR4CuPo9E1Nt06mnH7j0NwuCdbimdvcWOTch7T+CAFAs1aRFY6HoFKmUfu9UcFjcdfV45a/4MPmFWLpMFcXjumidoaDPoWkNxP1+lQ7kr3Ew8Qd7f9443rU80GTmFGiGhfDL6LCN0mWD5MHJ+x/Wmprikhlxq+69fswOsbJ1ov1s8nm3PkJ+tXs1bS58ZW4LdCnJnObJ8jucpOLCHuRWAncdIkS8jmfmP6p2ch82jREDVp9+tEmCfUkPSmSjcXYyhOtR+K5VmSPq+XgeMdJmQ5HBmgsV6a86rYXaaGF0xAFvNCoAMd6PNKpqdTapGSjSFWx9b44imiEavcbVj6MiLHjaDSl8GyHWL11/mOtjyvXSj7R/HAWio+nUSlagz79DLW/M2Z7k7Y5fE4sKozAy55YSA105SMbY+HNUvYmCFBvuBAQomCdWUHagYrjfNbBrOf+6geF1MkQ2OaDlOmJJ6pq3f/E6RHHotWl04UkMeQdbHJgOpvYBMd0rZf2YJVW35KG1Y6vtbxr s1aEgxu1 Obpt3VQ+BfzFBf4Xx7obVUTYewT2mMHRR6BaGJZprvYCcBzgCi3VY21Rf8NS2mCMw6S0ntl1WX82rVP3e/TP1fOKbaSIZmLnfiu4xzXXKS0CXoT4JWYJTpUY6Vg9yg5cX7V4SVUyUADexoT0Py37fH X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: None of these functions should ever be ran with RCU disabled anymore. Specifically, do_handle_IPI() is only called from handle_IPI() which explicitly does irq_enter()/irq_exit() which ensures RCU is watching. The problem with smp_cross_call() was, per commit 7c64cc0531fa ("arm: Use _rcuidle for smp_cross_call() tracepoints"), that cpuidle_enter_state_coupled() already had RCU disabled, but that's long been fixed by commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the idle path"). Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ulf Hansson Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- arch/arm/kernel/smp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -639,7 +639,7 @@ static void do_handle_IPI(int ipinr) unsigned int cpu = smp_processor_id(); if ((unsigned)ipinr < NR_IPI) - trace_ipi_entry_rcuidle(ipi_types[ipinr]); + trace_ipi_entry(ipi_types[ipinr]); switch (ipinr) { case IPI_WAKEUP: @@ -686,7 +686,7 @@ static void do_handle_IPI(int ipinr) } if ((unsigned)ipinr < NR_IPI) - trace_ipi_exit_rcuidle(ipi_types[ipinr]); + trace_ipi_exit(ipi_types[ipinr]); } /* Legacy version, should go away once all irqchips have been converted */ @@ -709,7 +709,7 @@ static irqreturn_t ipi_handler(int irq, static void smp_cross_call(const struct cpumask *target, unsigned int ipinr) { - trace_ipi_raise_rcuidle(target, ipi_types[ipinr]); + trace_ipi_raise(target, ipi_types[ipinr]); __ipi_send_mask(ipi_desc[ipinr], target); }