From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8973CC678D7 for ; Thu, 12 Jan 2023 19:58:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FA1080019; Thu, 12 Jan 2023 14:57:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F234880017; Thu, 12 Jan 2023 14:57:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A698D8001A; Thu, 12 Jan 2023 14:57:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68E1A80014 for ; Thu, 12 Jan 2023 14:57:41 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42CD7AB06F for ; Thu, 12 Jan 2023 19:57:41 +0000 (UTC) X-FDA: 80347207122.24.0113AB3 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf29.hostedemail.com (Postfix) with ESMTP id 9172112000C for ; Thu, 12 Jan 2023 19:57:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=H7KH+Z08; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673553459; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:references:dkim-signature; bh=BAfnvD9cLrzo61xSnZTsQNCRnrvqWps/XpXHA7FoM0k=; b=VcbuRFPxS3GMyamLQPSya1KHD9ig8WTxIRsLx0zX7sI0s+qiOhl7/LtONvcqPIsVtQDlCG y+Z8uvuyITAcLVlYMjaHlEZwsbQ2fr9oTD2MKzBoAYUHvp0LqYJKBiazgwpO7Ll0Dkv53y DtlYa9CtOLt5O4OLNHIgW4c7i231Evk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=H7KH+Z08; spf=none (imf29.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673553459; a=rsa-sha256; cv=none; b=zEEs1tUCNr+0Ley9Nvea/ElM2u8tYmREyB/U92MazgRjkTlQeAUeAKO1sCbOoMHdn7J9G2 oPAas5Ct6YEieP/eEjmQGb3ulum1Bs4AWMk0x9g3ePfrUyquZ160a6+g/BL/d1fis4iZRU Q+iADnNogsL7m7nH4bUDb6CJ00Jpf70= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=BAfnvD9cLrzo61xSnZTsQNCRnrvqWps/XpXHA7FoM0k=; b=H7KH+Z08RTaT/3t06vLCizvkOG Nl80fuaYr06fmNux1Mx9qtYbuwqPX3UIm8aftX5Z28NOSi2Mj7BunBpu5fAFoNnbe42np6v2RdXQ3 SsfqtFqcG9qi0lyDVOoDELfYVw4hTQlnjw9EXtt56vdDtyaKEp2Xa2RVM+DXP4oJW61oMArRyeeJ0 ilQmOrnOonRkmnKqBoOTtnaRQcwrM4jm6DFFkWE7NCRk2QdP8h1Fs9cERrbXc91ROvdPufdHKZpV7 QvcZXHXDtmJlQQByg/agmBAC+3sVjR/N/VTls/IF9+ePAkX1RGUky+6xWZXvuRPrOisPJZlzBILYP znwmGuiA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pG3hI-0045pX-32; Thu, 12 Jan 2023 19:57:25 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id C4CD6303453; Thu, 12 Jan 2023 20:57:13 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 0) id 364D42CCF62BD; Thu, 12 Jan 2023 20:57:08 +0100 (CET) Message-ID: <20230112195541.416110581@infradead.org> User-Agent: quilt/0.66 Date: Thu, 12 Jan 2023 20:43:48 +0100 From: Peter Zijlstra To: peterz@infradead.org Cc: richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, "Rafael J. Wysocki" , Ulf Hansson Subject: [PATCH v3 34/51] trace: WARN on rcuidle References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9172112000C X-Rspam-User: X-Stat-Signature: zaxr488ciuaj4f358q9jfcf36tb3y8o4 X-HE-Tag: 1673553459-811201 X-HE-Meta: U2FsdGVkX19B0vlPi4UWYIrtf8VOD9qRsJ6qmfPph00ZlS2bdpcdJI5NhzrkClz/0SWe78EqcTzpjYVGFTWX+sdaVSA9Xd+UZHkR1Vc2B7jaWZ+jIGijgj9ycIsfpJicBZuTdqzqkkKcePeUUw1ZriiwmWk9hKVPot9Q8BvU7k/W8FQB36dWVc9r8qAUv3KgFJeSdqJVkibG+um6Gxr11NU3YeefAqo/hcdqyeLTP2KYoL+7F9GlHNuSDJ95v128v7wb8v2dml9yT8+5yoskwpwstE5ZMIvZIHJpXP1gv5DgVyut4tXaGumP9srHJeIsDPtExN61kzHmTvW1n6CCNNDWEjryZFr2IWvRSO6mMDo05FTJBB33UC0T5/RUOhc4rYApOjtcl/6DaS4lbA9OZ+Qtn7CRVG/gSjgXwFe9F17vog2aR1LgDAFKJUu8i5d+fyqbrOeTJMCMo9sPKsxGLIiboOnouF8Ml1Rv+ZYOUb6Ss2Crky3ibEGi23XZm4hhYZ3My9R8a74k2YfjzoDAh4BXme+eVvXQ9KMgYge5U0/ol9L2dC2Lea+tKu/NsYXmj1hL+eGpygmKUFNZ537/E4tqXpyezaHWmPgbWW0MMT8i/oxuvQiP1arVlyQYX0zvwbvqp/WXeNcFCxU/LbZZxvAO/RAjbtYH7h34+wO9ljevjHTEuK3iA0L+ENMkKHEzgfvF/9pPHS7/kXxEFE/BlOkZBQ1lcFossnkRsfI/uqTecoTj0WbCCbLimB+j1WxZkIPAa9beZvLR37k4BUs/kq1jd3oZL1WfgALnQ1QhWXGcLEd4tDtTxBm036uhwBL6+oA/FbJbslLENMfSxkRsZI58UaYU3x4TtC0VmMTrJYISOMdyCv+SmMuVKng/hr8DJFadYejsp4KXqqC5mpyYg5eGTfugvhKb1ZvrQM6Ut2cNPQinPS7F2H+sl+Zs2X7DlNuPkibHxASJ9ELpguR zjIJKidD 0poAdPzHqA4QHr/I6wu2WOtVfwG9xrRKQMeaKXzjeKTJsbM30LoZkVwhCQlHPYcRKndzMNrRz604MwBYo1MfsCY6UX87Cy27p5vP8WgRxp5Zf8JTzgWE4jMPFa7mWPWRL0aFLk993IiX+B/LOXj9tN3WHQUEHbG2OH59TEb8bOGvF75FU/THYh6rq/M9j1T2aYlERqKsDzRpqmRorBFGFlg2P1URyl8DjuFA9C12y9RdeufXQR5JmfmOSegnywozvVG7We2tysPEJTKdUo3utgaQmqpSWOdDNql/yA7JbLxFKNyYlEvgO/ihcmiSorF3ChsNLtCfV9tSOYVWa2s20jsaMJcym854/nbtDo3lLFlpwR+cmnFf6vF524Dmdo2FdYrbRZiVIUYx0QMC31XGUOcYdiDwpP9XMCaHS7rGxc127L7CSz2xH0SPU1PXB7PuhVYqn/SC2Keyx1FKojFCrtvpFLXEWl/m1WOAciR5mso2I5tTFsqulIz0aqroAbUbgTBQCATniBp6Cxr0pWcKhFvawrATsdPCnO+GcNLYr7ENyQzm+Ad3/1M0uyvvyYg+tbleCsqIa5i1cl9pdYM5yzIwegG8P+KQS21PUIt5vOCEChSAhDOvfHTe6Q5swX3ozsr3Z2FRBbIFbzM1oXZ2OMvxc6irtXYZTkKj99omQRWBbVREefduCTAdMXFmtyRzQ0KnkoiDT6IL+cZG53bjJ5nqnANlQF8h0get3FochZr+LPL3EB9/alxa2HvuX2Di7IJSgmkv8Uskk2roPBOB7ePJJVoRHuVlqoWKWZQNRBREy+CmuAnmFPZlu54xwFlw9BLubruuVqawTNdIFtKQpz/WNSITUMHxmcwh4jRWT9/6lROJd2kP7ZTl/RjO6fsDBytqjLzF8Vaa5obKDvlCOBq+Y3A4fgioAYvBqzuoRj9yzWfemYS3D4fwW6mvr4PUYjfDOd7+gI+s0yYvzCmCpRXwpiwdL Nw2GYTIA pFYEnEKYPM8AX4E+HL3w1NtUh0gIcmI4ltsUIfhI68S5Imj9hSUkeETxDLKwH/bTWNHr+8jbmUTw0z3KTKQcUMuBnHzBpK+F9EMrTgmHKKos/JcI+JyDLwB+Z+A7gfRRJ2PJRzR1MBY0U+JrvYxSrN5DioWxzGDAu3lEKJ5HsSbGumXVKmSwrx+wagoudARw4zhJOD4dOe5ErSBu6KK83xYRIH9fqOfDPAF1qpSVJxf2MY+ikmyrBALpDebDk3L+r113g+111xqDZQj87t4BTDE9uFUBkeWGA7m70bQhZ/IRO999X6NYQ96wuhRfJbtMfaJKfjOfekEzoulKZzSvC5aMADLBitfHGxyrB4P7pgQLKVkk1mhcNyoX2KyfHuYI7t7pmub4N15VBm/qdjPCVMr9QJhr4/CtGVhy1s1t9xHfFCHN+BNORZKkRqhahJTjay4ibfutHA8GlrkWy1BzXNBRqX8XWJoLCztqg4vP1ozf5HrkJsRtVMNwZfnJ7gfaHDs/1sR1zcsIXRvXI8EPGqTiu58jP15wwF4dN3jsF2RTyr0dKJpEl4jCRt6oW/Ev8zY5KacAzeTzrejjrH+r6psqTB1xwxJnknslK8sEioSSfm9rSvVq0vaidFUHBGKe2FHexTQuUj7Q/pIhYJ0KmhnyVgzZAMNHpw16epm9snineAYsnzbOXEP7LOSliMFX7s1+OWm+LSUhLez5FXAQus6+NNbO5TbEIv5G9hE9Kf/DhMd8TWyuZAs54gEwTjHtXO9s1aynNzPAmiccLqMxiTC01TVWojtIxKElNMeuD+jZUq5jOcCBqUg3oPJYJ1IW2fzdXxvvE3RpdqBUXhaGgUyfNFVjD8p3pyfFT6WiWSfuukV2ephZqrk1ONz6yQar7+usXpw2WKwsL2ZwhZX2YHLjSLTYfV06/czeOczdCrOVgqPCGc0UuiVB3WEiul+3IasBNFHW4X0rhH2da9heNhLTBeRg7 241m+3b3 OD/iTg1bWzl4iIOnfbtnzlNsPhoKu2ekQ8rz5DlUpBu/EOjcYci7O/NKCKap7NuALekR7hRHWAtJW35FjFUvHXJDWT9IRqggJMvhTVsg+5Asq775YdWW4TWaemfRu0JroaKa9ypprRjy6DoBPBBR94ysQ2oUAHt+G4O51lHuFF9N0elDF41xaJ+Y8hpeCFLcHTUlG5/o8hnPpGjNR1qsQO4kBt7lTUHdlE0zyvOV7CQwJplbQk65g29n6pv2kpTVl1SvKTv36r687jVBQP8iVFDiEgIhQhJRZKHQQMRgp2KdYvmU/O5z1DIMywGlhVEsU+uaIw5p5gpKMfrKY4sujnP1eeIC2pP/7jYQnLmkQik/b132Eo8pc7L7nAKzFREicub8Is/r+nANf9UwF+PMZ6Sd8GwKfEUNlAxzl5W400+vPP9mHu1RT6+8eDHCWPbr6C15S71zXS3PQUp3QkN6e8lZb35uf6wEefhqoZWZdjXTRn7hdXTku+sD71antRt/K4gGCupAmKviM4zKkpA8RPq7l0qWjLvh0MP0Bvhl00fIoOBJTyAMBGUNN2WWvaPstaAi3JbkN3wGfk4px5eMQdkuGhtzkFaz/c127P4g59PbdDoZmEvtdbFE3in+ab9HjYikyNKd01zaYo0x6wPjlhTy4Eoqebgf3Lefc/jaV+k6DJNWmOjszgoa6BBycXzJf4+kTiQdXBOLJ3AitEqr+moTnYzQQ7qaVx+f744/6SvQdqus236Ioqsu6F8yC4DDNUBxOaZqtheA+sGC7HZx8d7B1ZLHm9VIsKOGEPh5THHN4hYhFpoKVP9I51WGfiF9q2jvKHYhO0XqruDta9/kbMGXruJfYug7B9j9x006TguKsDufLk4sdNVXEQGm2Ha6pg81FWQ6LrtvG+RID46cAiVQdvgwW9uekNcp7YQGdKCRX0Kf1Kqp81h1x5cQ3Zym2px2s9+VTj2B083ytL60x2OyFeA5w IOiojb86 b4km8rEMTfvieXfW2beuPrNd7501LACxXZ9qVCoyEhoDtHuKgmSnzneKf1idc+hAiCn3jPTIyLZO2rTxcFwhjKIfCbM9vtjapqCb0Axf4MWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ARCH_WANTS_NO_INSTR (a superset of CONFIG_GENERIC_ENTRY) disallows any and all tracing when RCU isn't enabled. Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki Acked-by: Frederic Weisbecker Tested-by: Tony Lindgren Tested-by: Ulf Hansson --- include/linux/tracepoint.h | 15 +++++++++++++-- kernel/trace/trace.c | 3 +++ 2 files changed, 16 insertions(+), 2 deletions(-) --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -178,6 +178,17 @@ static inline struct tracepoint *tracepo #endif /* CONFIG_HAVE_STATIC_CALL */ /* + * ARCH_WANTS_NO_INSTR archs are expected to have sanitized entry and idle + * code that disallow any/all tracing/instrumentation when RCU isn't watching. + */ +#ifdef CONFIG_ARCH_WANTS_NO_INSTR +#define RCUIDLE_COND(rcuidle) (rcuidle) +#else +/* srcu can't be used from NMI */ +#define RCUIDLE_COND(rcuidle) (rcuidle && in_nmi()) +#endif + +/* * it_func[0] is never NULL because there is at least one element in the array * when the array itself is non NULL. */ @@ -188,8 +199,8 @@ static inline struct tracepoint *tracepo if (!(cond)) \ return; \ \ - /* srcu can't be used from NMI */ \ - WARN_ON_ONCE(rcuidle && in_nmi()); \ + if (WARN_ON_ONCE(RCUIDLE_COND(rcuidle))) \ + return; \ \ /* keep srcu and sched-rcu usage consistent */ \ preempt_disable_notrace(); \ --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3119,6 +3119,9 @@ void __trace_stack(struct trace_array *t return; } + if (WARN_ON_ONCE(IS_ENABLED(CONFIG_GENERIC_ENTRY))) + return; + /* * When an NMI triggers, RCU is enabled via ct_nmi_enter(), * but if the above rcu_is_watching() failed, then the NMI