From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A738C63797 for ; Tue, 17 Jan 2023 14:22:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D0176B0071; Tue, 17 Jan 2023 09:22:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97F846B0073; Tue, 17 Jan 2023 09:22:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F9E6B0074; Tue, 17 Jan 2023 09:22:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 723846B0071 for ; Tue, 17 Jan 2023 09:22:03 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3097B120B18 for ; Tue, 17 Jan 2023 14:22:03 +0000 (UTC) X-FDA: 80364505326.14.5755D4D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 7F9E84000D for ; Tue, 17 Jan 2023 14:22:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of sudeep.holla@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=sudeep.holla@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673965321; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7+kFAh0wnPL2tfKa1ef1/Kgl91+ayvD2C78qXGWHpos=; b=V+1u+CvHOUsVAEMq2CA4b7a6PGKcwIX+NxwNcimdGOy0uQhrMMQCeCc3zex1uU/pTTW+kI EmeBEx6vuk/gjW0XnEcsaA5tp0mTCLB0ZWUYnr7/8WznmksCgEfpzUfQtwYz1whZ5Z7eB4 X6GlDJfuDFNfZjC2GjRwqJ8I94qQOiQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf11.hostedemail.com: domain of sudeep.holla@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=sudeep.holla@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673965321; a=rsa-sha256; cv=none; b=0W17Bq516dGoqGWUsTUcIF2N1pgJduDv0+wEtAdoT7HHyFL1t+nXMyc9mXYn2N04U/c6Kt xGVBZiF3sv25x1xW6hhI0tAK1w87VTizdeeH+VdTiIBUkRjQElj/Lo3jQvNFR/MS1K+Uwd lijBBi+rWUlvGb/NbKG/fzAbNvfhUng= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E24DC14; Tue, 17 Jan 2023 06:22:41 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B3A83F67D; Tue, 17 Jan 2023 06:21:43 -0800 (PST) Date: Tue, 17 Jan 2023 14:21:40 +0000 From: Sudeep Holla To: Mark Rutland Cc: Peter Zijlstra , richard.henderson@linaro.org, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com, brgl@bgdev.pl, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@hansenpartnership.com, deller@gmx.de, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, atishp@atishpatra.org, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, dennis@kernel.org, tj@kernel.org, cl@linux.com, rostedt@goodmis.org, mhiramat@kernel.org, frederic@kernel.org, paulmck@kernel.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, Andrew Morton , jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Sudeep Holla Subject: Re: [PATCH v3 00/51] cpuidle,rcu: Clean up the mess Message-ID: <20230117142140.g423hxisv7djudof@bogus> References: <20230112194314.845371875@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7F9E84000D X-Stat-Signature: rhhxjkzk3yfkaohape3niy6pjooje95m X-Rspam-User: X-HE-Tag: 1673965320-680453 X-HE-Meta: U2FsdGVkX19EYcDKMwcu7R/z9dPIrvAML+7aL9WORwvgg3LVrQSGj/ZyzVTCqUf01vHCrZ52UNOeRmJx2ERB4yszHEafMCHI2JXeQ3YRHTRUAjwU06/spHGIMj7EpBA6qDi6YTgk3LNrj29xuYb4KVmfT+NYGYeX1rHCk9IUefV/GgpoBreyVC/asE94A4gUPDqB5pN4xx7hGRBARMD+7orCO7Q9rZCQC05gGs3lgACe2EJWKbsTr9oB5dTFWEMLIOGMKRNY/arZZrruAADIld83ntN/Xk3pJ7PuIxAPIYYcQe1jhBox3eANwNUodYMS7C7jV0J0c0aEIoXjV18eDP98bc0KU0dfMReKafhCEbJsS1kliU8cPtwVeuhn1osRgdz3nqdYmkSyu/u/JNkIZ03YUYu81i4TYiYlIplcNttxLEnLdFjDRvfnSZWsGry0xvfRhKUAvxU7MkCR1A7EURZNoUUHno8eLE9Gysu1Vb0Q5zsLj6VKedr2zBYpIjXWmBBT603K1TrTFa6+ax7C4WS8GsqMlfVx6WalsPO1iRHMLTr/Dutr7HNKYHtW+fiRXgYJDkiB5JOaOa//YYyflM+qOacKvLjMDAAQhhwAhwBDJVULgstykjNpJ0Kj18y5JtG3xE7aGhG2qHzLgIZl4yoAtzo8vbx24R+EE9zbgjVTjEIOyFevKFaPTALubOu0LpbYsWV2q8iradfa1rx5aqVNqV6RRYtuhkVvmLVjSJTSxVQL/iUdPxGUaLu1z6mHeb7l2aOeawW8VrvEuTYUeGZr1FDb8DxqcX+aPSfujloMaF/tLfqTgCsbtDZYkc3M4IKgfiAVzm+j+m22CYjCrf//cXdqTOXva9iQaEZ1+4yNTeUKF7RM8GHNOVdRqpUQKNhiPTVxcH6aKh3OlY9DGOHRYpmzHH6h+caV5IDk4Q2Em7tHaQHaB5mfjSUOc4l4RCReOXnbsFrbRw8QzIz QEM1lYKa dLPUtUlLlGDTzVnoHaJVAxpLxmCjvzde+pYZG5zUSGOUxP/l6HIsu/Sw4yZHNgRKyMxcMi0breAbcBXa22ro9hmSkw2S+YX1z6httbqL+CbUluAcSLcj4sflMboey6KiNa9a97YWP/Brsg4FqL7P1b6rEEeDCK2xAPpCUmQywhQtDzbCkQR/5+b1TxhawUI8nzry+mcnmIId+UScqSVTkf5t9vegi2KSxki50vQNRSg+Lk7SB0y/VDuMdiHaVGuy2g1+lwijmT1u4es+l83aIIj1eHqYt53l3WLw2UGujI1yAmaBeZ0R2fz0ILKRv3CpEBAUpwvz7uLoqyAEWlEmrDF+YoOYRohie7R44yGwj2VWmlT3bI04/JcNhXyyprNhDLgy/Gst+B7vMHbuKmnbZbH9nvwVnP2l+IOy6EwUXYnRXhGyks8UicqqN3L5TNoI9RM2DszNOd2PHqWIYwIQ+4F68RT8aqZunKId6nNPpC8Qdtz0Z+yJgA0kX8syF7kzPpH85U85uEekb1WGnT9HtcTE1+jkjXeNq29LBfyqDOh5Cf59Khq6OR0j9y9zCB6bmIMZgE9X5AhlrTaiTqf9yb4Y3Dr544kMCPUI48euW5iKpwZ+Rvwh4oIzkd4iwYIeUKze40ldjjU46qZrXPIC+mc7Ao77uAPvLQl8OYYwDBxvxBS9L4WWcwPaclRnGBGdP1/huy8bU9OtF6V7FSDNfv55Jrg7fm7Eev2ClKA4FpeYfmCNa1HDbAy99plYnJ0hccTo8gZlJKdTXIQNH8ssFTtCEJHPzLxVdXRg38eunfYbxscVXL75Gv7Oig416h2+v3S5C7zqYOGawgCKYAabBcVhXbXeAhSa+fHMlAQmRtICLoN+A+XjoZpg5ImN5BPg7rDj/w8XamRrpql0Hw4DCTHdpTPfylIlqwilXSgj4yi/rglB0nnxqQ7RjObH4YFyaviBu8rjXX/vbMmOzMateyCWpS3AH 2D9W9HK/ iCfmp1a0asrXCRLfeQJnpd0Dl+f0w6jXsOfrHhxUaHrBRyQSvBocTILabv8ET776iLqxSBkNpmttDS2UolUB7BYgL4Tx4fDrIov3X0/X+jvtIcqDV/P/InTL7JfbTl7B+iy+oeTspwcKg860aFTruFBSF5YOXHFpn+UigFViD1QJ6j/bfbdPcT9S3h2GxgFH1Ull3xWL7AFkFgSgHXzA+asqftEOtT6c8guzSD85WIF6IFTjzzlB09gGUoXg9wARGNMpKQeeFFFgSkjR36vH83TcF4UV9hUa+EqBXD+YVFKWQ4GagqGOm13yc8Srs9vfGGVWG25d6qU1puXcqXFpvDf6Fu9obnQUV9FuRLbW24B/l0j3KJ9KfbP89bC45zFZSfo5zucJKYXWRjWuNSJzVilvLOyKhoiAWnlmDYX/maDhGVwlH8wvKSWAsddxrjIErrnxid0SHK02B6m0tEjfKLfanmfA9b3WK79HPNi71yTQ71sTFLJPcUWjb5+NtwOYOIhudEpqE7OUj5Qoa5sNUVwWxQlv6z+pEV1ctqGTOwrRbP6JSMJpjSJLTmqkcM/ex8GDE5tQD/NXtBljIQvwAOXQljO1tHTPywnHhV3beQYWMcTluiQJkJtxAtSrhNj05C1MmHB0R7k0RKvOWxwa6RA4Qn826CU4LEfsSQSWCfTFkbDdQfRqDYY90LOFLkSBISa4mu09iTChjeVy1kUggTDkNb/K+bV/pG3486jNdVuVt7TiMxA3Lp5tRcdAwQu0Nyyaik0/Zf+9Ql0QI/LAAhvvDs8DkSl97NRLHgPUIxQn9RJkJO2RqchQx2KP63GObffGXHuXYS28IEB8ASQZcb3V/6UB6h0QpSCWma6kGAoWrnMgBGEUChZc+OLKVqDdCrfO2WtWDYnnYL1UXDd3PjC59jfda5IHV+WMlGfrwOopyPPm1+BW0h1D/JpHCINYwIXhmK3N3n77vJgSIUEpq7kbcsj3w zEKdv6Yt 3d9k+SNXR3taTxESQJcQXhF6gvDM3zDsz1bU798y5sksw1nAlPZ/lAYlnDzHn6TcomN/NDDjuQdlwtO7AjdXeNrmIWzrhq9TJr0z42r4dgsntFsbr6Mo3YL1XmrqgR6PUF+g11EH9XFfEbqmX85CA9m+Z3v+dkydxeJW+CYbROJVy0K3oQW2J1nY/RU/tunxHarTbxd990Hu8hqlPdBrVVXXgUhTma6e7LRi2DIXgkJf/q4mbU8WTJxCfN5mathKaKK+lmpy+d36Sc0RHSIYWJygTjLvvROBoMrY5mpTH+iqP7BjrJK4y4ROYLc2Yee3TH7C8Xi5tZyOmowq45G3m9sZon9MifoyGEfyhAo5f3NU4IwGsfLYE714KHL6AVzFR2kqyfe+Q1tXmWh4zI7OPDtvc8wHIaPbP+f3rN6viVKzz0SbNAmpag0PmpYnc6aYLTnhd9dienbF4ECAyOl9KB3VV3nDAV/iwaW5H1UTFkia+1+M1Q/cpZXppzpLKMXwRE5E6gMUfsCRllYkhrmMz6HSNt8pJRvqVfyYBBxtJZeE/otA+z3awNiLK3cg9ZWriZ1A9IH1asTN75qNIbpTHI+F2SQ6oCaXIhaRuiD9D0gBz9KhI7GZoLnanIZ+LRhrQvZHubt54aiKfAeLvyFAvLz2VilCNYii3+bNl8OANIj7m8PvnjSm8XpbEBe0CVsoZ2stuZiPscN05E0/deDSrGcNgOKXKTfsQSk3PvW1NkekvIUDh/OkMADAxGPeEY8/T5ycf9QeKkCruGgTZ0GYMlEJD9bf3WI2543+hvW6yuXhMwa0R+Y8Om/kccLagchVgqCVWgB7t/UkqUA8jxfzgMSdNyP4vNLD3dG7KQL/NUF/tStAUopXbhJowsyK8wqOPyEK4IJ/DrgajorRp4SdfvETq4D8VxuyM72g5rr4pMzAttYc9BTXV0y/Rbc4v6eGpdFo8kBJUmICINFBHAlwjv6Vcnx8F Jzx2ETVL 3qzxQ351JK2SG0+XY5ax49d0bTCknvwKw4XWWwVW8m0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 01:16:21PM +0000, Mark Rutland wrote: > On Tue, Jan 17, 2023 at 11:26:29AM +0100, Peter Zijlstra wrote: > > On Mon, Jan 16, 2023 at 04:59:04PM +0000, Mark Rutland wrote: > > > > > I'm sorry to have to bear some bad news on that front. :( > > > > Moo, something had to give.. > > > > > > > IIUC what's happenign here is the PSCI cpuidle driver has entered idle and RCU > > > is no longer watching when arm64's cpu_suspend() manipulates DAIF. Our > > > local_daif_*() helpers poke lockdep and tracing, hence the call to > > > trace_hardirqs_off() and the RCU usage. > > > > Right, strictly speaking not needed at this point, IRQs should have been > > traced off a long time ago. > > True, but there are some other calls around here that *might* end up invoking > RCU stuff (e.g. the MTE code). > > That all needs a noinstr cleanup too, which I'll sort out as a follow-up. > > > > I think we need RCU to be watching all the way down to cpu_suspend(), and it's > > > cpu_suspend() that should actually enter/exit idle context. That and we need to > > > make cpu_suspend() and the low-level PSCI invocation noinstr. > > > > > > I'm not sure whether 32-bit will have a similar issue or not. > > > > I'm not seeing 32bit or Risc-V have similar issues here, but who knows, > > maybe I missed somsething. > > I reckon if they do, the core changes here give us the infrastructure to fix > them if/when we get reports. > > > In any case, the below ought to cure the ARM64 case and remove that last > > known RCU_NONIDLE() user as a bonus. > > The below works for me testing on a Juno R1 board with PSCI, using defconfig + > CONFIG_PROVE_LOCKING=y + CONFIG_DEBUG_LOCKDEP=y + CONFIG_DEBUG_ATOMIC_SLEEP=y. > I'm not sure how to test the LPI / FFH part, but it looks good to me. > > FWIW: > > Reviewed-by: Mark Rutland > Tested-by: Mark Rutland > > Sudeep, would you be able to give the LPI/FFH side a spin with the kconfig > options above? > Not sure if I have messed up something in my mail setup, but I did reply earlier. I did test both DT/cpuidle-psci driver and ACPI/LPI+FFH driver with the fix Peter sent. I was seeing same splat as you in both DT and ACPI boot which the patch fixed it. I used the same config as described by you above. -- Regards, Sudeep