From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2710C636CC for ; Tue, 31 Jan 2023 23:12:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D1C76B0071; Tue, 31 Jan 2023 18:12:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 381706B0072; Tue, 31 Jan 2023 18:12:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223AC6B0074; Tue, 31 Jan 2023 18:12:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 123016B0071 for ; Tue, 31 Jan 2023 18:12:15 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE5FF160D3E for ; Tue, 31 Jan 2023 23:12:14 +0000 (UTC) X-FDA: 80416644588.01.62C2B30 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id F058820017 for ; Tue, 31 Jan 2023 23:12:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ve2cEcLb; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675206733; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AMvOgqtN5q4OnsDOZTYOI0KlFKefWKj2jIM6GfqkqeI=; b=cIxwBB0g0ethZfGRvtEY59sNqPT75Uci0LPzWG79FxpvoxO3V32+ysl+IqGOO9oKG5yVhF nAp1IzMi1d6I8YGJF8JextU1FcHYPiCVH0V0wt15DrdduiaVogkrZuZsWGXL8XNU4FPjO+ 83L5+WY9PiWKzT/8n3pbvjorQPvyr+Y= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Ve2cEcLb; dmarc=none; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675206733; a=rsa-sha256; cv=none; b=WVm7RHjae3DDMOl3di2dxhNVbMGK8U0KE8shuzk3iIR4Dc0XEBNdpGDIcVQkisuCriRNYP om05+agu3HFE8urt3qtMBIi0Aeed7ZuyfuTkmZHSLY5M2HXvEU4jtAakDuiJcZ1j7q5Y4J faPbPAtP8+bZc03yB2HdRN0LbhSCgAI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1CB486173D; Tue, 31 Jan 2023 23:12:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 268AFC433D2; Tue, 31 Jan 2023 23:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675206731; bh=UD5aYgT6pPerwqmRX863s/i9h3g4RLRQIlQIVcQeK9k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ve2cEcLbfkgODWpke5wSo2CRG70LKa3nC9kSoeM1J6Qf6HyPThzORd9pAHW+/ObyJ vCHmRnUh+D8kgZIyNeYV8qZeoc3ilj+qhFfDGjLQUQZHVm2EV2x3+XEgXDtOKDRtmS RAr+qeOOsyKdPonLaBLNkJ9fISBaTBrXqLFvmr5M= Date: Tue, 31 Jan 2023 15:12:09 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls Message-Id: <20230131151209.d53ba65c3c065979808d9912@linux-foundation.org> In-Reply-To: References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F058820017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mupwww7zf3bquddmkenzfgnosy8sqkgp X-HE-Tag: 1675206732-831450 X-HE-Meta: U2FsdGVkX19uMHqSpSAwKdCcNlPDsniTW7svneIjMzXW0D3/3vw6y58HW21u1QWNIRdavpsmT115oRaozPR6Uil9LgNGDOUJQcWGKuwkjTeySI/JKlcloQuZ/ikS07BEVRB0Qf/mEkqaQEW4IgDNQEsVDtT9t5DN/IWVMVN+mnTvrvH+sS+TPhAXiw2zua7DKbWPVQXh8+Bp3Y7apwHwj30CJJ6PISi5m2az3NvxJYgGQGdFVTZFGlpZYAAYcj6LoovuXGkBfjJmiA+tRqI5BAZtqM6pu38N8jB+wUycD/rC9n2jCc4+6dFpEg1k9eYvDcB1ldEnAJcy+Oj0gPE7c+4IkAGhxZwDPxtlOKAoK1MaUHYkz5NnXT2ziEZ38A7dLvqwHRJJ4VczQspzP1qplaS/jLm/mPARHsCGG0mYXRobMQEkklnmcYTBtqejJW3d7n9eHWbFtT6OIHPYi6A/DGLct0DBlwDMzbJKfBpFx/U8N56JhtL6m2Q4QnJPTcM4ylToaZaWAjY9SGEXAns7AgRytweUCMyq8ZnP6yilBoYfKvzC23n1HE/9WrEZwxbtzaSbLSPJitVzI/cK4M3JMxuwrPXVHesPx5CRSx6/aiyLhn+sATNpaEMOVwYY2gBUFqcdtRxLqBVGHQJ+Kic/S9cQwWT+1lnwPaKYjbjZKmJFcZ5kazKK009oGv3WCq/OQ9NAism8sr+zuyJBoJS6Q9LUVbJ9wqXk4prEdzKA3SuntpsA3jsKfMbU9JNRWPJ24esV7R6WyecRvLpBeBTBcn659IEgHGj7FLDHvv2GQFpSwygpjhpqGsDxzPtHRsNHmCh1wShiC71dHapNCU+GrFGFJTZeY4vNgNi+InISb3HQrg5staytKNYhe50xo5sv26F4glZesSsxmQBNqsYldpvEKK8W7qQZz1E3UwkfG02F8VdpHY6+kBXqwOkSi6SA7yNEN2zkpSM4VOKckcr teyBHXon ZeJOJfxDrPe0G+HAZm2BxR5FXToDyqNVW9Dj4WCS4Jib9xNoUAAaXVjd176otyLOvoZU9+OrF+tEmq9MJ1bNdrDpsOdDhoqrvy+BNaIHykfwRkvjxYHExqIxVj1xd5DoQ4HO4+FX9+VV5otNxv5NuO35KNeH+sBaLDRpRPZXq6Hre1cCWZjPytVD0nt8grZJpqdD7fnYFt2NBDB+Y4wbYZ40PZhJop8YYFds6LNZzgvkaB46UYLjDsRzeOohbnw2JJn1ZU+M6moj/stNEtCal5PMXmr7JK5QUKaKgVgsTvvNE+V16g8dWFViXxKY5yUBBhk6PNsNwiQVoGzAQbm4LwmPgOAYcLI1H2zFUeUIgPY21kesqikNabN21jyBLNinY+BN8f0LCn1ZTdLdnbfIddK5+cWQm8kAhzmMf5ys62UbLYsk0e1jAAPWXGI0/WokXbwAN9yPQ6QcxWZ4c5TJd7mOg0JTix0WPHuOGITGK52jMGb9FjNf8Wv3uMZOtTJxTO1yRcLb8btbfqHgau5tYMH2BhpNN+hfNFAQdAgmFYEDvDHI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 13:08:19 -0800 Suren Baghdasaryan wrote: > On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton > wrote: > > > > On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan wrote: > > > > > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > > > } > > > > > > > > I think it should be: > > > > s/VM_MAYSHARE/VM_MAYWRITE/ > > > > > > > I added the fixup. Much better than resending a seven patch series for a > > single line change. Unless you have substantial other changes pending. > > Thanks! That sounds reasonable. > > I'll also need to introduce vm_flags_reset_once() to use in > replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send > a separate short patch for that? That depends on what the patch looks like. How about you send it and we'll see?