From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7499DC61DA3 for ; Mon, 20 Feb 2023 21:37:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA5F86B007B; Mon, 20 Feb 2023 16:37:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C55AA6B007D; Mon, 20 Feb 2023 16:37:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACFA16B007E; Mon, 20 Feb 2023 16:37:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9939B6B007B for ; Mon, 20 Feb 2023 16:37:15 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6AED4806B0 for ; Mon, 20 Feb 2023 21:37:15 +0000 (UTC) X-FDA: 80488981230.24.6DEE3ED Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf03.hostedemail.com (Postfix) with ESMTP id 765822000B for ; Mon, 20 Feb 2023 21:37:13 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K8zGSFBN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676929033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ntTegXxHE2C6Lp8xdtMzn8aIclw1LjjCN5pS0JeaA8A=; b=xruVxiizu17E8EsHeHTdlMkTRDW79MjopTH56Y83kI87+GxGpBs/f6YTtx/GA9owQIQOqr GLfAWIp/yaaH0wCptz7j9RKOoRUIRcBl7M74Hjax0uztDMoqvM3cGvP0Uv3qDceOvGrD88 mLqq8FzjCBSP1vtKiKpvotelYIVY1VM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K8zGSFBN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676929033; a=rsa-sha256; cv=none; b=PEQQlTCFDm8HZbiMVJ7zVyzxnJLr/mNNEcM8qwMMZYH2YDR1UTQFb1pl5ZxpBaHyrWKBdm dttG2i71wbh8WkBtsevLmb1iqVgkHtnWtA5Val0NNc0HRwRRKXpdjUcSUBLe3TWcYKhpN9 /7WmFddyaQ99N0KA0wWp1HURAqKa0Jg= Received: by mail-lj1-f179.google.com with SMTP id bx43so2251795ljb.12 for ; Mon, 20 Feb 2023 13:37:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ntTegXxHE2C6Lp8xdtMzn8aIclw1LjjCN5pS0JeaA8A=; b=K8zGSFBNI3bdU6J5gbrSYZcfL5sYsQjVxJTFkpIjhAqxR1Xxr817nUsCsnvL/JrUMp qoPWnoDVVtnpBTvblsnDdqASG0UQ7WxtCHGWIaD8xXMKvw5xxrEYv2zRrGw6EEzNHKUj UvEzax+npqRsxhJ8JA5VL57mkKzv9SPf0eqWr2PQ9wgxyXnOW9NxfdumExqueZbw8FsP wisNc6cs8i8MKfQZbkfwjawdBzTETXo+kIWV3oi/vN1tHuW82XTJjBjtLNQC8BQNNasi WK8w/uHuMYgkSPwZ4AYAG3k6i5mpyxrTtxYMwhqKcy7nCMpQ5pEsrC1o/nSFiQWyHmA1 CWng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ntTegXxHE2C6Lp8xdtMzn8aIclw1LjjCN5pS0JeaA8A=; b=AT8X9+XLP6S5Y4Bt+IqTfCjV8jsBXOGYtLW7Jw7IeLfUPksgYfLZdtAi4OnJlI/lXw rTs7MuWSes/Wa/fkq0LZPm/AKIzxUjLAhHlSxF5slj0+H+yqzA8gkaKkwJgvkrtGsYkf MnXyDNGXPOenpGZdszSEyNpqC/QTothMnoFNJ1UDfBv5I4zZqoXtfIzW51pMp+J7Hn7J wkqCr43q+3JVaSzbcrNZXG4dsDa4sWbDxLgaylF9LpsNZa+C0n9g97iRklbCLSzahGkk QBZZrERg3xh0BaaIfWTaeGbNBwbVTS0CSClbttN1yowQLgbACNfrRlSiPZF28SBP3esr jNww== X-Gm-Message-State: AO0yUKW1f0vGQr4FlAvUg+sm7NEfbxMbA0peUaTu4uxHS9ce0/5toQUL l9DGoIgeBb4tYll9ykqtLh4= X-Google-Smtp-Source: AK7set9ere6899+uPRGjAaNY74PLHi6orKNOrPSws3NLJTJtiICDHHa4uvOj8GLhs/n/V591Itkx1Q== X-Received: by 2002:a05:651c:210f:b0:293:52a4:9717 with SMTP id a15-20020a05651c210f00b0029352a49717mr1528073ljq.4.1676929031468; Mon, 20 Feb 2023 13:37:11 -0800 (PST) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id y2-20020a2e3202000000b002934ff9c817sm401104ljy.107.2023.02.20.13.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 13:37:11 -0800 (PST) Date: Mon, 20 Feb 2023 23:37:09 +0200 From: Zhi Wang To: Michael Roth Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Vishal Annapurve Subject: Re: [PATCH RFC v8 04/56] KVM: Add HVA range operator Message-ID: <20230220233709.00006dfc@gmail.com> In-Reply-To: <20230220183847.59159-5-michael.roth@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-5-michael.roth@amd.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 765822000B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z763ffodzb8jtm6qtwajcdg59y5yd3sj X-HE-Tag: 1676929033-638357 X-HE-Meta: U2FsdGVkX18diW+vMj9J7/R73ZpLYMonb90C+A2z3WxHpTPQACuSZP8e3yFXaQe0++E99MFNxdsf5XfbR4SXmKT6jxml0w96m0sv7JVPhNboToCjgINjmOw94mEu0dE0CoE9x1jqyX/JhObcWgwIktQVr8AAIZgiSWdIrqW/GM/m9zAOgMLLTyln/EQEQz0wCe00e0qJtGHv7XByiyHRVzpE1ziHnHM+URPV18ERfX2oJQRTwbehp9KTjmQhtCXAIvlnovasXRgdj9xF2Q1UwdOiNfTkluUkrlgsGx3AMjLswtGsXFmafn3P9MeW1kd9xH0kukaCUJ/7Zhd0TrkK5A8jAkmj6EGD9WviCvTICQzxPZzVSDyTxYQvAStsAqtPn3NK3iMLWQQrX3CnUTVLbIlO5F0naxKR4WJavdXrnvfMmXnj37pu6bEX6FE5koF1BbRRVcdifX83EdMe/raoxy6rfxoFCNbyq3XwL36HDUBYyfRMimIG9yayezKjJ5RjoczKObZXYs1t98Asr2TcQQcJ403MIGmrKscesQEtov/ckXXlFjZayYD2S02+TJZgLX/6SR9Z5dX4qfZ3apO7DDQYIUcdExENojGmVzhY5KL43pVK8ZOGEA/vMSXvZzeTdrYzAURpxp/WL4kp6J3BgAQ0oQZwsD6jn4K3Xmu0CTdNSRHXnroA3Sv3MqnaWItzCVb3+pZPObhlWnYmTq0ehedFlSUDRAO1pLs52Bd+vJlumTMHE6yB4hlioxKyDx6aw8umvdU1URHfkmn0DdlJoJd2XdIXJ+l0wENQykmIm92N1B3JYjQVu042OnYGVfv1y+CPJrCWAFI7WjtfHQUqEJHvhfs2acg/n/9acHogPs2QBZh+05M02c1d0cRlN/lLZS3chs2hdrNEv0v7I86YrtUIoW/ebj7hLffBDIhX8gFY7wiMTeltEom4Gx+X5pzvzUe8retf4e8R+2JPhec Lc3nBhzV qMrrNZhhepxFfbOPdoR/SWdOKaowCuid7FPfsJLlctnRbQS/nOvgIOvD9m4xWWVWXpCJrthwlldaSEvblNFfoMtGiybD+BGTYT7DwsfglQAOamgX8arQAuhFaotFvv5pys87cK5iHmfat3ArNMjTiw7wy2tccDr9MEqkbVGflknuhaa2mn4XrA7vcrcl1ncNIfvGLF2gkZDWPieTATMKT2OzQusQjhY6wjf/8dWnU6sKjl9S7ZJXPPMQYj53/Jn0TqVrHZtGkKeaf6Xh0OkkeJE2BjUo6qv3Q/aSR5gx40w8peusE6njvdLtd78KaBS6ywDGA5bLvktQkWn1IPA0/+niw9P1YSLC4MH9i9pr1vUdOfPYH/T1+A+uNxBcJ+2gj0WXBCwb6n5OxG89AEiXNqP//Di2tQ+4t5YuJpT1/64Xtgvv9emNuuVs1NxvZcoCLQKfhvsPtZ9xKyW0Bt0em22VMf5aTJcCsIRT8kWoIHHzGN6SSTpqXm/5FFE5LxVS9LaQfQWkXHQqaXTSdr8Ta7S/GTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Feb 2023 12:37:55 -0600 Michael Roth wrote: > From: Vishal Annapurve > > Introduce HVA range operator so that other KVM subsystems > can operate on HVA range. > > Signed-off-by: Vishal Annapurve > [mdr: minor checkpatch alignment fixups] > Signed-off-by: Michael Roth > --- > include/linux/kvm_host.h | 6 +++++ > virt/kvm/kvm_main.c | 48 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 4d542060cd93..c615650ed256 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1402,6 +1402,12 @@ void kvm_mmu_invalidate_begin(struct kvm *kvm); > void kvm_mmu_invalidate_range_add(struct kvm *kvm, gfn_t start, gfn_t end); > void kvm_mmu_invalidate_end(struct kvm *kvm); > > +typedef int (*kvm_hva_range_op_t)(struct kvm *kvm, > + struct kvm_gfn_range *range, void *data); > + > +int kvm_vm_do_hva_range_op(struct kvm *kvm, unsigned long hva_start, > + unsigned long hva_end, kvm_hva_range_op_t handler, void *data); > + > long kvm_arch_dev_ioctl(struct file *filp, > unsigned int ioctl, unsigned long arg); > long kvm_arch_vcpu_ioctl(struct file *filp, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index f7e00593cc5d..4ccd655dd5af 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -642,6 +642,54 @@ static __always_inline int __kvm_handle_hva_range(struct kvm *kvm, > return (int)ret; > } > Below function seems a reduced duplicate of __kvm_handle_hva_range() in virt/kvm/kvm_main.c. It would be nice to factor __kvm_handle_hva_range(). > +int kvm_vm_do_hva_range_op(struct kvm *kvm, unsigned long hva_start, > + unsigned long hva_end, kvm_hva_range_op_t handler, void *data) > +{ > + int ret = 0; > + struct kvm_gfn_range gfn_range; > + struct kvm_memory_slot *slot; > + struct kvm_memslots *slots; > + int i, idx; > + > + if (WARN_ON_ONCE(hva_end <= hva_start)) > + return -EINVAL; > + > + idx = srcu_read_lock(&kvm->srcu); > + > + for (i = 0; i < kvm_arch_nr_memslot_as_ids(kvm); i++) { > + struct interval_tree_node *node; > + > + slots = __kvm_memslots(kvm, i); > + kvm_for_each_memslot_in_hva_range(node, slots, > + hva_start, hva_end - 1) { > + unsigned long start, end; > + > + slot = container_of(node, struct kvm_memory_slot, > + hva_node[slots->node_idx]); > + start = max(hva_start, slot->userspace_addr); > + end = min(hva_end, slot->userspace_addr + > + (slot->npages << PAGE_SHIFT)); > + > + /* > + * {gfn(page) | page intersects with [hva_start, hva_end)} = > + * {gfn_start, gfn_start+1, ..., gfn_end-1}. > + */ > + gfn_range.start = hva_to_gfn_memslot(start, slot); > + gfn_range.end = hva_to_gfn_memslot(end + PAGE_SIZE - 1, slot); > + gfn_range.slot = slot; > + > + ret = handler(kvm, &gfn_range, data); > + if (ret) > + goto e_ret; > + } > + } > + > +e_ret: > + srcu_read_unlock(&kvm->srcu, idx); > + > + return ret; > +} > + > static __always_inline int kvm_handle_hva_range(struct mmu_notifier *mn, > unsigned long start, > unsigned long end,