From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A4FC7EE2D for ; Wed, 1 Mar 2023 10:45:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FE166B0074; Wed, 1 Mar 2023 05:45:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AECB6B0075; Wed, 1 Mar 2023 05:45:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E91BD6B007B; Wed, 1 Mar 2023 05:45:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DA07E6B0074 for ; Wed, 1 Mar 2023 05:45:22 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE9BF4159B for ; Wed, 1 Mar 2023 10:45:22 +0000 (UTC) X-FDA: 80519997684.05.0755B5C Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 870BB1C000B for ; Wed, 1 Mar 2023 10:45:19 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P7SSTk6s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677667519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HgQQZanRv5/alvxkVET4D6uB4QZkFnK7oJuTnwO/hEE=; b=7Q6r712hMXy5rPFhUtmAU4cj3cMKzELR68pbhHcCrn6Jd2GYXP1XKV+y0VwClHNLP16K0O JFBIzLBWs1u+hSqUZI/06WLRt/hEBjvVx6N6PDLR9KGHgwDmTC8mDDJrzPcx5ST3D9FeCR pNnRukXA7WJjrNXCEvdGESUXeYEHv5g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P7SSTk6s; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677667519; a=rsa-sha256; cv=none; b=Ed2wT1EQJznkfypUgTEVWyws5OQhmZO469zipYrd+BiO6hqxotmWWRHm9qn90WqFTNRoxi TtUfT3P7Uv3QFMdVdNOxOqY2RU8EOz19PX6LJQggalD7RsscHf4rEDAY+O7ZJtI8rV3gYr tXxsLfNzSjBgvorWnEd02dDMKLBM/a0= Received: by mail-lf1-f48.google.com with SMTP id s22so17015345lfi.9 for ; Wed, 01 Mar 2023 02:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677667518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:from:to:cc:subject:date :message-id:reply-to; bh=HgQQZanRv5/alvxkVET4D6uB4QZkFnK7oJuTnwO/hEE=; b=P7SSTk6sznBU59W8FIBilggNoPneO/753Y91fiXGPLcnZo+7vSp688RM2AEYDH7KHS Oe6Ac54VLqQqTSg9I80HwktZ3FG0ggZw80CfLRhkgsqAsu52TYikxNSjooJzTFicW5sH vwKPsN3AjYT+NcKd4RsE3ndx3CMxhQnu9JSc4it/+kxEwrpOrbfsnxRqNHKzgVeCjnB7 zDkHqnFloq2501FJaTMMlXxulgv8DLgS6APspZ30Pcw4+tXEcrJKn+NK83RWNJxXk3Fj 9fICn88zqCxqTvwKFaz5Vnv0SqDmkTZFcpqRA5y5uidc8eWLrUwwKEzOm92C5g5/tnIp 24Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677667518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgQQZanRv5/alvxkVET4D6uB4QZkFnK7oJuTnwO/hEE=; b=fyrGuhzyDN+RQhutEdAok+d5Ib/rNOwa/voErdV0EZjE+PDSsMB8K/JWnFjKpGlOML V2Lg2vaH4TMVzBqJkRFXMq1HAeHC7bOAJ4au/g4ySZRHUmMsfqdTuYny2wrMzJ3lHYT7 35yavu031TtStbrJxLcVIrCfHSrKmyWG6viTIecGnKukHu4JuFzbu8HktbdavaaNRBTF H4Jaol/Q6dUOz6ioLO91NZh1jL+XpBt0gYQnW2hTeZCnX8rTKi+QqL3cWuTzNWcKDopq X5hfJNCfGqiT+PFzAF1oOOM6oMno5ZYM+5FQo0wQuHCMlWT52CLHEWeTtN/RWarGYPeh xW/w== X-Gm-Message-State: AO0yUKWMGsJtKjgzAo2j9trawo09IObnqRX+560Z8FNGRoImGxnwl+Zp BGjakhcLp7Qhp+CeeSIYZ6w= X-Google-Smtp-Source: AK7set+HFf00M+CzlupT1bQM2ZRdW6de/txyzQjH6FxzfeDTmSWjvROAUCh9HT5dCKqG75TdwtvY2A== X-Received: by 2002:ac2:44a9:0:b0:4d2:c70a:fe0a with SMTP id c9-20020ac244a9000000b004d2c70afe0amr1344986lfm.2.1677667517726; Wed, 01 Mar 2023 02:45:17 -0800 (PST) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id r1-20020a19ac41000000b004dc4bb2f4bcsm1663800lfc.276.2023.03.01.02.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 02:45:17 -0800 (PST) From: Zhi Wang X-Google-Original-From: Zhi Wang Date: Wed, 1 Mar 2023 12:45:16 +0200 To: Michael Roth Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Brijesh Singh Subject: Re: [PATCH RFC v8 51/56] KVM: SVM: Add module parameter to enable the SEV-SNP Message-ID: <20230301124516.000048f5@intel.com> In-Reply-To: <20230220183847.59159-52-michael.roth@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-52-michael.roth@amd.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 870BB1C000B X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 886iqk8g3gzdebrmjb6ciheumgrsijsu X-HE-Tag: 1677667519-308876 X-HE-Meta: U2FsdGVkX1+cEoiDT7HBcEmboVv2yxZBQEs6+XK67bfFgqmoQJZGJi84F9ZC2jqSSbtX4MOS2jLRkSmBx318+VxQyWwkLschR3XmAbuFqCKwYcreHdTcYA58cacagl973tAPU71O3G97O5UV3SeWbk+x3M+NDzAsL2/4FLxh8uFwaowzAajbdVD1Xi517xsEU6tkEF9BaXOQFtBWWXacw4C0mqcy/4EV7BTKKbuV2iIAZ6mFbXUuk0kiKwsziRWws8ohWB8n6QcK7hvW/Usdxz4G/WFd7+EElnWcqRPEVNq2cHDYcfej/raC7PY/fimECwjGNsL/4LEGDS/2udkRxiRvNwvMcEuiLnV1wc8evUoMA0fhVqHMcy18JoCzlmuQt0PGRjLTeQFyPvRepSoMjgPrkTRXiFWKuis1E0Q0UkHudA2y02Cb3PqPt5hJfLFrr1GPQKp5W8rg0ntAtnhn8voz2L5/ihhSLt8y6fjANWEwbKBymEC+37MgzQmxbXtmPvTrw7DTgHXRfqht7Iv7AZ49BSH/0cWGRxNc7789go7jxCfJceeUsdxpvqtKJDK26hTie+qQ3qA5T6yv0ZYbzCD/2eVSFJDyvWbCWIo3O1NtZY5YZYAw8PRTqLGDCwvuw9AXWZ0SqDWyYR6rRU2HfNF6RUabn3bNHb55in75SDTbNURsSor8Ld9oNjb0601/Sez1bw3BIbDphT4uSrgaPE0T9zX+k5mQuPMThTARnAM6/7QGaGSP3YWgo0FvuFE8QmqhPyMHJctcdjhLXFXVoLMRTA0JTeCTkINqVb6ikyvu2MID7lhXZk+CfQJytG72HmwB9bLsLvb98EtjWoe941qdqt7A88dGL4LmAuh1DBYf1Ym0VyEDnaHDQYj/GYa53EH4aHMnrUVXUAqk+rJ/f7lzcGmKcwLIl0QW+i5KIJe+8TlYaum1RsTTNuEmNu1fNlciFG5HVBt4CnCeHPO CASHZTpa Jmr6nsFaCKRxUiyfqbCvTUZswqHgOy8Es8yvtta36E+r+ZlhzQEFGqbNM3NC07wMypCjiEYMjezQad0OBSxuQ86DuNuG2zMLpXO7rFYzj0XAE3LNzDTMoc901SET2OZ3q6Q0anBSuayRlkJLdcZxHixK9u4BuMRxvC1NK7FueH8clyQcTWBtKqyGrF/ZeRoc/jsxVTn6APgbHWZ9FmbYkSc4tQeaiPNpJEAvmhUOPQE30TBKWUJsXxoJlOAE4lnMYxjgvK8e1p00zSvmG6XhwiDH8XmduTV9+Px+BBINcOkqaucScMGYIpo9eEPyYMK3zEVXu4i0VTlfUVGeEZJYLY5/CutMvdMbMP3wSWk/sf7E75cCSK0O7PPeWgpWp0XbTxTzo1mWSMvEOKShysjmOg4ACQe0GvcCO57l34D691cRyqY2hFP8WnKaLt9vB9mgPXoipYpd2DgoFFYW4abg+7OMii933EDGowrR4R8Q58hgfgLtliJhygyzN3Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Feb 2023 12:38:42 -0600 Michael Roth wrote: > From: Brijesh Singh > > Add a module parameter than can be used to enable or disable the SEV-SNP > feature. Now that KVM contains the support for the SNP set the GHCB > hypervisor feature flag to indicate that SNP is supported. > > Signed-off-by: Brijesh Singh > Signed-off-by: Ashish Kalra > Signed-off-by: Michael Roth > --- > arch/x86/kvm/svm/sev.c | 7 ++++--- > arch/x86/kvm/svm/svm.h | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > index bedec90d034f..70d5650d8d95 100644 > --- a/arch/x86/kvm/svm/sev.c > +++ b/arch/x86/kvm/svm/sev.c > @@ -55,14 +55,15 @@ module_param_named(sev, sev_enabled, bool, 0444); > /* enable/disable SEV-ES support */ > static bool sev_es_enabled = true; > module_param_named(sev_es, sev_es_enabled, bool, 0444); > + > +/* enable/disable SEV-SNP support */ > +static bool sev_snp_enabled = true; > +module_param_named(sev_snp, sev_snp_enabled, bool, 0444); > #else > #define sev_enabled false > #define sev_es_enabled false Guess we also need #define sev_snp_enabled false. > #endif /* CONFIG_KVM_AMD_SEV */ > > -/* enable/disable SEV-SNP support */ > -static bool sev_snp_enabled; > - > #define AP_RESET_HOLD_NONE 0 > #define AP_RESET_HOLD_NAE_EVENT 1 > #define AP_RESET_HOLD_MSR_PROTO 2 > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > index 857b674e68f0..221b38d3c845 100644 > --- a/arch/x86/kvm/svm/svm.h > +++ b/arch/x86/kvm/svm/svm.h > @@ -694,7 +694,7 @@ void avic_refresh_virtual_apic_mode(struct kvm_vcpu *vcpu); > #define GHCB_VERSION_MAX 2ULL > #define GHCB_VERSION_MIN 1ULL > > -#define GHCB_HV_FT_SUPPORTED 0 > +#define GHCB_HV_FT_SUPPORTED (GHCB_HV_FT_SNP | GHCB_HV_FT_SNP_AP_CREATION) This is not related to the topic of this patch, should be merged into related patches. > > extern unsigned int max_sev_asid; >