From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDFDDC7EE30 for ; Thu, 2 Mar 2023 11:27:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 640086B0071; Thu, 2 Mar 2023 06:27:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EF926B0073; Thu, 2 Mar 2023 06:27:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B69A6B0074; Thu, 2 Mar 2023 06:27:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D1026B0071 for ; Thu, 2 Mar 2023 06:27:12 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0EDFFA0E51 for ; Thu, 2 Mar 2023 11:27:12 +0000 (UTC) X-FDA: 80523731904.09.FCBAFFC Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf13.hostedemail.com (Postfix) with ESMTP id 05ABE2001B for ; Thu, 2 Mar 2023 11:27:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DBbo45Zy; spf=pass (imf13.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677756430; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TJb7ZUgVLyd0BezCYruMgzCjIaGRbn8MEvGz3yq2uQ8=; b=JVzIQeuROd+kzvgRvGTH66JUBhjS1OuzzVXi84BUO/uxkvmBwcumXpK5U13FyQcbPWNEKh CJzRKZUHC8CZMLokLHgX0781qejlsGL3dBjAhp6sN6Ddeebcv5SuWmocRuNppzXNEJvtiH q1iOMgPcbkZyCBcZcrXo7eh/PE0JVsU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DBbo45Zy; spf=pass (imf13.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677756430; a=rsa-sha256; cv=none; b=3AZZmFxCgeBGsFdts9s04N6D56AoQTYbK+5vcg7AAAOOoBjjL5DawHOG5BqGq/A6bZPaK0 S+w/Lt9LBAKttxR28Z6qAkKJ8zE+Wic5J1DOdB4KyBxfmNQCYwgWj54Wup5mIjYWtZEE3q vhXLZ43u2eAg9CyzD+Avdl9JL3egZd0= Received: by mail-lj1-f170.google.com with SMTP id y14so17242687ljq.4 for ; Thu, 02 Mar 2023 03:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677756428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TJb7ZUgVLyd0BezCYruMgzCjIaGRbn8MEvGz3yq2uQ8=; b=DBbo45ZyhnENO2PQEeIoAWIfplHoenM9uv102K8FoBn5IlQ/F3IbS2pJVKCBQQl4Z3 cDacFzW6IqmfjlggpJyJ9u7ZveV4kUH8S4ZQ3eHeOuv3LnwPGSyq3prWTkijFNJLqgUz zdKG6Br34pnwCnp9yjJda2djJ3YPnYovU6dDQnnKHBmqOlW4a5QvIdcuEajrNiwBg/VX JDnor36TEOvosU86JgpMLKpRLVerkqcJEVFcyhKt+fiBpPpixQuTiCPymUf5JwpfPbEY N5QbTv1xuWXUNGYWNDkI02TUeGtk1y3PbKzaKRJHDD/2Z+VF6Zy5cx6vlgQjDHHNBxxW +GSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677756428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJb7ZUgVLyd0BezCYruMgzCjIaGRbn8MEvGz3yq2uQ8=; b=wmjbW1OzL1a/a6h+m5EpsyFWr75xJVwRjyX4mvcxKUA5gUrFouvqSBdp4RA/xCzd6T M4PjoFhGBmhKqWF7Q4CjxbA+NvMaKT6QYPlRh+h6RTwPjJ6VwtpscNEBBCjOtve2qeSr YQ9L7B86pMj0XJ6F0c4Q52mwZ/hPptdfddJ8g/KksIDchj00h8eDyiBAhwLdKhDLkGiF 899IushH8mxmxJufGTo83hfCFrJ0x5JgZH89X3OqDjg6IcLB2z2B9pw4DL1j3l8HsH5w 6DCWt7ALml7nvDPo3ueONJFrgJX9s/m1SAk0YWUw/IfWYuYovmt8ypVG+503q+yLe1uW heKA== X-Gm-Message-State: AO0yUKVJQmQXejHAUxUU26SL8SR+Pe6ltrqFzqsK9WZBPJuN4QURGzO6 nmZfuaz5VAZqJKhXaJjpO4w= X-Google-Smtp-Source: AK7set/LBpmR3Ohx8+StI9clR/JKrsDH2fb2JnDl7qKrYvJxXVkoui0Q2HhcZRo8LAVSqRFwnfVepQ== X-Received: by 2002:a2e:c42:0:b0:295:a024:f3e2 with SMTP id o2-20020a2e0c42000000b00295a024f3e2mr2796902ljd.5.1677756428052; Thu, 02 Mar 2023 03:27:08 -0800 (PST) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id be40-20020a05651c172800b002959b1162f0sm2057676ljb.96.2023.03.02.03.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 03:27:07 -0800 (PST) Date: Thu, 2 Mar 2023 13:27:05 +0200 From: Zhi Wang To: Dionna Amalie Glaze Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com Subject: Re: [PATCH RFC v8 54/56] x86/sev: Add KVM commands for instance certs Message-ID: <20230302132705.00001637@gmail.com> In-Reply-To: References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-55-michael.roth@amd.com> <20230302020245.00006f57@gmail.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 05ABE2001B X-Stat-Signature: 9q78jt1ty41xx96xnyz9zijy493k76th X-Rspam-User: X-HE-Tag: 1677756429-366627 X-HE-Meta: U2FsdGVkX192ED3afyho3i2xS7dvGt2L4oKTLRPkh2nXkQNDqoEIdlRv/0IEiUB0NxBCCN/CBmOX/nmaiIP14RaIQSqDWSL6Hf6pKxfNqqUS4jzttcvKRziH/QfBbQpxPa1T3SnMwHDh/rLJlCsuH/KPhVyni46B80LxYgcAbZb+gDebvBkz34lWUILOwwNo7oSZe9ZPsGP/VxohoxoMrZJ58nqo5Bg/HFV6tY8c3EKG+++KNS7IJPiTg+7RYyfQ8Iw6n6E4D1Twpt7s4d7FjXgel1bBitu3kIj1dUguwDnqm4iOlggFaccQ2sSGOA/PxA7jbydT09u5soi9rERxC+VMwJ8P3VFI5ObxhrSn2YVMwSgGIsx1Rp1ayCuLC1UrjT5OR51mLSUByzlMzSxN0JLPKKvLaO8GS9job3wT96aDQFiVk8pjYJyObjDjRidFXynXdyJEVCm70fJkYOyqyGOsjHBc0ZqQfeTOyjaRxsdJMZhIFyJ/l+MLXqQjDtp24FjTlWCGtwjdEuz/OesipDnccygYGFVz2mEwT3RJJnN1ODyaXgyvMM8U6PfBBRtK6jdu9e5aTs53z/7eQEUcX94NONJEJV+xd8B1ZXNCYnUQMmuvFrEr9leVwbcGAjmGgh6ARVPY3f8/imArFgmvYDULqC7aUgAU1xAqRJaEGA4tdKuKWKT6VYJ2JYb71s/IKOtsUdG3+BGXVwsIXUBFGwBymtmxdNtj1Vf6a6+dWI+y910T5yirrqjjUK1rFw3nWiIJ/9YzgM7xgciAB7EdAWTvyRyXTbYoADN5tlHBOUFNvHVF0BQXlCpkftVC1or8XX1GZjUapISprJcQ8KMm0b23Lugz32DNr6e3EeghdbPCVONGvAXHGkss8waSiiDaVBIz2chhGTH8vD3qfmV8+ZeH33Vp7gXvR6ytcsEJHK4DKrOnQLUxMVW3S9uRaITOXoD4J6fDjV41+0ptQ+a vGIH+KOl 8GVOaTUGYbpOsb0zjfYcahoAzibDjcsr6CTeA7xZbJ0NDbbtoMUX+p4mXHSID3G1k7QUANNBkDI3pwJ1e8bn7QQrXM6YV1Z8LVXLzxVnTFqRLKZWxdgui++rlvse0qT365HEcZr5ysHtgZtCIUloqWHBX/n38iis+Bj2PJ1pJXsPfzBNS3k9Ua1Ijy9OCA551w+DnTIyVxG0K2eJSUDICXArPILeoo6oHmYkv5DKDWvd5dJBC9s3msFwO9QlfSWOzsB+AcVxll6qY45TgC8xlBCLoMxZVQXan7RyNnXqtsJTzZwUDLp9nynRSBNzM83hYxDLVt/GucQPV9eERzNTb/FNDuLR1z8FdGe2URPjdGizoNbRw10O0K/xgnBJgbeIoXGHRLyHpuLN5J3tSbWS3bd34N8pon6TJoIiQ6IFGMLC494evUOnxZUUL00dpeb5KJRUTrLUxKPf7CR8ZsIsvqK9GVUvn6zi9Hucov4BwzJGBuuXGPWoGfPtVX0as0540kYov X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 1 Mar 2023 17:41:11 -0800 Dionna Amalie Glaze wrote: > > > @@ -2089,6 +2089,7 @@ static void *snp_context_create(struct kvm *kvm, struct kvm_sev_cmd *argp) > > > goto e_free; > > > > > > sev->snp_certs_data = certs_data; > > > + sev->snp_certs_len = 0; > > > > > > return context; > > > > > > > Better to move the fix to PATCH 45. > > > > This part isn't a fix, but part of the implementation since > snp_certs_len is added in this patch here > I see. My bad. Was thinking it was the snp_serts_len in the global sev as they has the same name. > > > diff --git a/arch/x86/kvm/svm/svm.h b/arch/x86/kvm/svm/svm.h > > > index 221b38d3c845..dced46559508 100644 > > > --- a/arch/x86/kvm/svm/svm.h > > > +++ b/arch/x86/kvm/svm/svm.h > > > @@ -94,6 +94,7 @@ struct kvm_sev_info { > > > u64 snp_init_flags; > > > void *snp_context; /* SNP guest context page */ > > > void *snp_certs_data; > > > + unsigned int snp_certs_len; /* Size of instance override for certs */ > > > struct mutex guest_req_lock; /* Lock for guest request handling */ > > > > > > u64 sev_features; /* Features set at VMSA creation */ > >