From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D8BC64EC4 for ; Thu, 9 Mar 2023 17:05:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05022280002; Thu, 9 Mar 2023 12:05:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 000CF280001; Thu, 9 Mar 2023 12:05:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0B49280002; Thu, 9 Mar 2023 12:05:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D1B95280001 for ; Thu, 9 Mar 2023 12:05:02 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A005E1C29F8 for ; Thu, 9 Mar 2023 17:05:02 +0000 (UTC) X-FDA: 80549984844.21.3739CD7 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf19.hostedemail.com (Postfix) with ESMTP id D55991A001C for ; Thu, 9 Mar 2023 17:05:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=judloLDD; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678381501; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HSgIsxTDQ4s8IseiaVBLQ3K8w1aWvzVhyrwDNvu0QZI=; b=32b3eljaFJ3D6YQPtgrfqaSSG4qxkkBceiw1e+HMPa5nDQ9QzZi1PDfjuHBCU79Gq8hNbB uNtDIrqZv2sVHdkqUWmyvv0F8upWXo0g4MUIuVyTtLfXX5ApB1N/Ds2YQwJ4qJhUa9V/wh yKoXlJVZRQznk3MeL4t+X7urojG1zAE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=dkim header.b=judloLDD; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 5.9.137.197 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678381501; a=rsa-sha256; cv=none; b=4201a+OTwqnRYwJCVpvOeTnQoN4pwKxgPN2yyKUW30iKTBjwWzricpYm5vQ8Rx0yc3YVwI DnmDXSKuCddHI3fjZ+kJtKgiOCB8s7hNJtT4fu2pWjKfgxpPJ5S2pvJnlMlPDTn0Hmdvdg XMbT10yzHzI7zjYZWXAiGufhl2Pfkfo= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6E93B1EC0464; Thu, 9 Mar 2023 18:04:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678381499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=HSgIsxTDQ4s8IseiaVBLQ3K8w1aWvzVhyrwDNvu0QZI=; b=judloLDDDKAm5Py0vvIdKjzrxN1TJ7Pw6nLKBeazATLMz4s66nMghn84IniZDxefI67pbB Yz9x5Pj/ivmAia1jOMbmjBtiAHwlDqmfTJK+pEBbRgzWg11olRKz91gz07dAnhOYmtz4cU eGfUjxM87Zhd5XXATTPr9WuyvwtxmLI= Date: Thu, 9 Mar 2023 18:04:59 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "Eranian, Stephane" , "kirill.shutemov@linux.intel.com" , "dave.hansen@linux.intel.com" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "akpm@linux-foundation.org" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "debug@rivosinc.com" , "x86@kernel.org" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v7 30/41] x86/shstk: Handle thread shadow stack Message-ID: <20230309170459.GGZAoRuxYy1zxwluev@fat_crate.local> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-31-rick.p.edgecombe@intel.com> <5b0ce47840bf2f6747ebf722053f6b3c1f99bb64.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5b0ce47840bf2f6747ebf722053f6b3c1f99bb64.camel@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D55991A001C X-Rspam-User: X-Stat-Signature: kpmru1dbphhp1kezp9cf3r1emnepkpjk X-HE-Tag: 1678381500-114448 X-HE-Meta: U2FsdGVkX1/8zQeLRwr68PTp4gbu4XCJcbB//YlS867IayEAGVlFKnrpMH+um3unPnoJAiHTkFoqvrrwGUJGrszUjzKK24by7VmBqXWDAN/18HN5xa8eLlonWZBlYZAPBscVrsFZggS2kYG5Um8QQPFxsNFqUgbmcX1bGrbMu1eVn2x/9Q5HA0qvouigcLaO7JaeKjG8uSXkUAZXdhECilp0XRcXMHu3aV0kWhUZwfw5e0IiK/RDnt8cdcDWc5HMaqj90Qw9h8KCtfUTaQ4rGgPSEruYGYOqCeGU3niJTyw6cGGf7JrKVh92EWUV3U9yBF5Yn5EYmRRSjPuQ7kJSgg+R2A/PTRZjXvACWm2Cg5mpm6laFpE+VvZO70AMKxWfVYsz/QhtPJmat/iZH7qG7wzZgyO+Wbo0HsctaBDHFsXDLhRmwE4XyFB/djci227xo6IRvUgMWp74b7z5si94mNG8xrwUAEXC51L/yNrFoN3++hv94ixxXy52zX9QB8BB0M2Q2xsOBActayIOQROgW76SN8vnT5uMjmxyOwVOl0aH3qfvnoUkPIB0QWNDYEu9Z0iO9egXG+f5JkKDwZtqFN90xF0nkVPRvEj/dp0CMvUmyHO0XCfLx26xEDjm0Sg7Od9mKyZWgK7CvoESc0OhEslRtzHwwzDbGefMqU7ownDYbshQ/l8hkmo6ewDLTYo6CcqYlWLPbPLZ+Ij1mXRpEUjlsqQQ0jXFi61QPMtCNoBPcd66EXpbKE0lnoviH9Ar+vtiUJ7RUst4jFLCWodNokUhPmWMm7xMPq3Jq6giE1iywu2sma9OVucpo2YcAocJRtn1m7uKBFEBYMbkG3cb0OkeOnyJbG2vOwjuTJIWP8CHXC98WlyxZSDvIQumQEbhekhjM8MKeQlfJ5e4U7xb2XSwkFgYmoCi+G/zhlmdX1a30f9PHA3PPCFovG9/7L/siZ9j77Tt0siPcmI8RQO bcnD4tVk tAN85cI5+6lcrQCeJaaoYKlu1dm2aGa9q82UmuNQN0Lzwmth4t/Ul7aaCG+oaOhSzVZ7NaNTpiOekaWcmo8oWvAoo6l8Ql2YBEnbu2J6a4Zk0X04iM6PBSUsnSf7529g1qc80/AvO0kSVfPyp22JgzysP7hlPdg2P+0u7z6VqvdeVKZhUNER4fNihRomzmnak5no9a0iXF5beB1V7XJZY0inN8ID2/7RVtkzaIVZyji25EifAiAYd/f0ECNVcv4c8bG04r4IKy71VfwNZfZqt4pjFLohIyMUQJBJgavAN+BRhy9sSzSeAmNFBQ6Zazs4ZlWoO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 04:59:52PM +0000, Edgecombe, Rick P wrote: > Ah, I see what you were saying now. It looks like it will work to me if > you think it is better stylistically. Yeah, having a function return an error *and* an I/O parameter at the same time is more complicated and error prone instead of when you have a single retval and only input parameters. I'd say. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette