From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11ECDC6FD1C for ; Thu, 9 Mar 2023 23:35:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A53A0280001; Thu, 9 Mar 2023 18:35:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A03586B0074; Thu, 9 Mar 2023 18:35:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CB52280001; Thu, 9 Mar 2023 18:35:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 756876B0072 for ; Thu, 9 Mar 2023 18:35:15 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F43FA09F2 for ; Thu, 9 Mar 2023 23:35:15 +0000 (UTC) X-FDA: 80550968190.12.C49062C Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf23.hostedemail.com (Postfix) with ESMTP id 8A67814000F for ; Thu, 9 Mar 2023 23:35:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=Semlql+h; spf=temperror (imf23.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="SPF/DKIM temp error" header.from=alien8.de (policy=temperror) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678404913; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mc6I+7znRrVDUZxl+wj7p4vTUU0tWw4JGu8kmW+lb6Q=; b=QMvn5uaUKAyyTGfscDD/SwpYR00RFwNuvneqO4KsEyLUhV98anMTvTj7nuObW9ZWlfJAy3 qA+feZiFk2043M2+xwYXFSzC2mmVLDuQ+0CrZtYaiHV5yOyejLbZa1HsG0bdTVgUl/Nw+h /h+5imstr8pdiz5zjX87YTfAYfRfM0c= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=alien8.de header.s=dkim header.b=Semlql+h; spf=temperror (imf23.hostedemail.com: error in processing during lookup of bp@alien8.de: DNS error) smtp.mailfrom=bp@alien8.de; dmarc=temperror reason="SPF/DKIM temp error" header.from=alien8.de (policy=temperror) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678404913; a=rsa-sha256; cv=none; b=gFzuvuLfhUiE7jDa7lIrP1++ZISAIHW1qKTC+jMDd8JzXKkUO2elfeAhZVMzHMN0iNYlIF kOK7VLPMpFBDMqflyXo+maETGoy5C9z2hZR6QpEuxVYEhWEP66ikRY/dcclvmc9R4s3o1I 0miKfH1IlK+eNqlA/Hj2hUKqUJJXZCE= Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 73AB01EC06C0; Fri, 10 Mar 2023 00:35:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1678404906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=mc6I+7znRrVDUZxl+wj7p4vTUU0tWw4JGu8kmW+lb6Q=; b=Semlql+hKRL0bn3X+wUWPEkKWryDpN6ryllb991Hk4mYRJLWTaWPXjMpZWJWHe07Iqu6Dp vx9CEKiZCYskAoldvuI+UMBaAuSp6A/VNnYkeovomed0WXeT0h9rqH0CuEii5pUWMdBzDw viTDD92tsD6WL+Y3QNB5XsuOSArmHvQ= Date: Fri, 10 Mar 2023 00:35:01 +0100 From: Borislav Petkov To: "Edgecombe, Rick P" Cc: "david@redhat.com" , "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "kcc@google.com" , "linux-arch@vger.kernel.org" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "Yang, Weijiang" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "tglx@linutronix.de" , "Schimpe, Christina" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "akpm@linux-foundation.org" , "debug@rivosinc.com" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "andrew.cooper3@citrix.com" , "mingo@redhat.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" Subject: Re: [PATCH v7 32/41] x86/shstk: Handle signals for shadow stack Message-ID: <20230309233501.GAZAptJTCLtEWLCVNu@fat_crate.local> References: <20230227222957.24501-1-rick.p.edgecombe@intel.com> <20230227222957.24501-33-rick.p.edgecombe@intel.com> <20faf06156782664690af6b4680c581640db53dd.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20faf06156782664690af6b4680c581640db53dd.camel@intel.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8A67814000F X-Stat-Signature: tr4njs81667dzz4ibonu85j9zin8yx7s X-Rspam-User: X-HE-Tag: 1678404908-755330 X-HE-Meta: U2FsdGVkX191/zFRwKOeyYTZV3H7xsvvitQqEIdbf025LQahKAmUggEgw6SBYwXiP32/x1IWSkYUmZLhZRO0TW6Q8qEqb4JseL7zHOYfJshWUl3QQorwVAx0jD3Dxm0ptnuRVEgO1PxljpXSvdGBxikbs0z06fstn8c10wsgYN9g0wzYcdVwonphkdsoWN8H64SHbkAvUMJn3HjCXe0YME+/ooP1Q0PASTu+fd7QPPbvoX+6tQd7CL50U/dr9BgIg236Rfte9hXB6wSO3oG3bnLVffZeDPEosNSLz1jv5uAsqtN7VmEJGE2zy7af/oJDT/TGoRluSRw7iFl+o3e1G1E2FErnqpRRI+wDloq8HC1kY4znqfWz1AyCe67e5KLvJIHYAPpDtiOq+CKhGJDM2HFnLqSOERqGj+Uoa9ElvG9ToJ3VuwbX1TvflEpz6neEj7UX55v5mJimNcA8BHSZUVuH9TBwAThcLWCf1t50Xyq1Zf2BrkdYcdZHaZsSyYCSOil1E2mUEvKDGmSWhndDDw6V9tKFgzE+Bq8s+uG/rsTE1yG6SauyfxIEvfFdJkU9shX4P/oFXJE6nZX3zcYxxtp2KQ5ybPK7SX7ZnHmCM7hb/xU4ScagD9EhxDqUWMojYX+B6L0GhFCvKoRtKvBzmAxFB2NnnvLf3a8VbcMN+odDvi1uOvRskPJyfXDCdnLKI3j7H0kPenWjFT3Kny6jQHGZOa2FL720NZGZ/xy5d5wJc/CKkQ1wfTdLxao5JyVZY6B30GtRia7H8F9RxslzWulfZXKeOGYpfhAuWbKAQyjCU7htnMcW3hBzqGrl3GNiOiAn7tTAy/zRxfI3wJWG6lkBhEpibAAxoAAiGWBKGgtn7CfVA1C5JZq1ZS5oehuO9aUJyLvqrjtT83UOz0X9LlG9MNBQrCKbf/m3Q2EZLyRyWGjOMenyY2fHUTNHtJcL1A+uiP87IT9UVtPY9HA MdPbQMn3 Rh3j7T7wLC4ZbIp0JMywY0VnLG2pyIn2KgwIVCOmS1TtTL1+QxbJXFboCIH1V02C68rj3r/QyDUmw94PyaCzphzJ/M6mVIHjBpoA1uQl7seocK73GvOWCAd9/hQPu8HQyEgy6h85FX3GW+mn3ggN+/tYTHh4XGSA29yf8e4GSh9rwv2+G5vr/PVdVr/AZJXcJ2WrdSZ1HTtRpWkyvNh+WeIWFIA97V0ArWnNXxzRoGJhhZZ4xwNqTkMG4PRXG0i/+NmOHeWLF5YiiMjwgVR79y9v2S2gXJ0i97Uf9NP83FKXKZjrf6inG80EgHROQXdQsDuucBYmZ8+zgJhV0bzNh7HlRvkv2OiuEzzrU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 09, 2023 at 05:16:42PM +0000, Edgecombe, Rick P wrote: > On Thu, 2023-03-09 at 18:02 +0100, Borislav Petkov wrote: > > On Mon, Feb 27, 2023 at 02:29:48PM -0800, Rick Edgecombe wrote: > > > From: Yu-cheng Yu > > > > > > When a signal is handled normally the context is pushed to the > > > stack > > > > s/normally // > > It is trying to say "When a signal is handled without shadow stack, the > context is pushed to the stack" Yeah, I see that. But "normally" is implicit in the "normal" case, without shadow stack. So you don't really need to say "normally". :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette