From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7562CC6FD1D for ; Fri, 17 Mar 2023 15:29:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7C756B007B; Fri, 17 Mar 2023 11:29:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2D096B007D; Fri, 17 Mar 2023 11:29:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91B546B007E; Fri, 17 Mar 2023 11:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 82B266B007B for ; Fri, 17 Mar 2023 11:29:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3ECDB161831 for ; Fri, 17 Mar 2023 15:29:47 +0000 (UTC) X-FDA: 80578775214.15.5BFEF3E Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by imf19.hostedemail.com (Postfix) with ESMTP id CF04C1A0010 for ; Fri, 17 Mar 2023 15:29:43 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679066985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XC1fosb33WU/8BsDkY2jNBfSP3NupWDSPZpj0p8oYbs=; b=jaRQxD2/xJ60POsuxqdZ7CcTR5SNyi7S3Mdlmx+oZY+J9ZSrjNXO3EMekll36XkVP6MrW+ fxh8MjTRvDw8SxelGcCZhwbOkk4o31HKrBbP5BipQTuGG35ZzhhM0djV5+jFuD0qp/0DYU 2xMFqgEwYE+4ru1eOZk+pRgqwbqqbXs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of tsbogend@alpha.franken.de designates 193.175.24.41 as permitted sender) smtp.mailfrom=tsbogend@alpha.franken.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679066985; a=rsa-sha256; cv=none; b=XagaHdQjTIp+onX4ayM5BZfgwyJAtmRpz/Aaw637r+wPW4nss72jkOBvAWuvrs5NN4N/je DZAFw1XCTzlgSslR9cRx326aiuQrJQMAKbWb0gypx15dgMALZYa9w3eBe2U6NT4ZWTis09 T3BczzjVltWxWwROOThqxNvg+fpAO7c= Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pdC1O-0004S1-00; Fri, 17 Mar 2023 16:29:34 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 203E8C1B05; Fri, 17 Mar 2023 16:29:20 +0100 (CET) Date: Fri, 17 Mar 2023 16:29:20 +0100 From: Thomas Bogendoerfer To: Matthew Wilcox Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v4 16/36] mips: Implement the new page table range API Message-ID: <20230317152920.GA11653@alpha.franken.de> References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-17-willy@infradead.org> <20230315105022.GA9850@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: zqkrw9acpbjtai9dzrn4738dcune7u85 X-Rspamd-Queue-Id: CF04C1A0010 X-HE-Tag: 1679066983-188684 X-HE-Meta: U2FsdGVkX19u/s+WHSJC7uAreE/mhGfxY9loc3oTq+PEQCJFFaF4b1oNowfMNVwCpKQmRxwImUk7leQVzZJp8KMgZd1orATydEjCNCUzdF/ciOYkzHju4IFh5wBJrti+z153cZ+ajTyCkQmeFZWEDI7C5AfQ2wGQqro184Gjo5Se3C7nNm3THaORutRe3nIJzAav891J2ZmsF1LsGyVcAGHKhjJKTqb50wce0v+jOEJ7w+ZShORRd/I56ym2hBEew911zRxJTecQ68Y/N3CE0XMANSpdLmAlxTSM2OAwZ8xKtH0ZKR4zdYBL7HfB2GOOh133MBl4A30poEBhzqUUKxqOTzX6B6mGIHVszKMxo76r8YaDcGb2C8gq0NeTa99mePs6lzT0fuTOV/iZ6uXzklz0HSlOehQdEw3pLBQ5flA0xxfY2+34APEpNJU7H9BbdsfsUYVwhmwgaMwdxeyR4dtRlJP50cRkBR9DFLVKJVuoivOqS2PCYrfC+UonCPbAs7y9VZp8V4bDt2RvOYsKuaxYSIHIYk6iZQRm8cbYlS2EorerxfYJXnElkUt3cFZSF9b7xmVt0eZZj06DqgNjdQVMofLNkRQWRxWSD+vHrwDgfrleDeTxfJ8iIIRcSAXN+gbIhhYUIeVktGAU4c8nnnbveh+C7a32UPpy8oAgPJLaGhhcfTO2/jdAW8IMymBnAD14bltEzOFI/MmSPslt9aA0OmMoeuhVtzvqEtqyGg7EOhWolPKi06A2dfEW8LE/b2xNgsiDEFSJW6DGipU/0aHzo6GDx1/HgV6XGly9uznE54s13S4GcWO0zF0RicTCcX4wRxr0sUauaHs5PHTBV4YeHuJeP+wkoK3pVYCfnywbnWiIl4PK7Z2A8J95ecYqVip6pVPa5zn1UHh8Hm+o9TXsrV5VfQr9Tp5ScXqPe75yR6hV4XbXCRGLv+olKRdUJNgtwaYAj7VImXcc1X0 uvhFut2T v3k45J4XfUHLyaih0klD/nV4BVs4d6JDbhQyprVBfnHi++D4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 15, 2023 at 08:33:21PM +0000, Matthew Wilcox wrote: > On Wed, Mar 15, 2023 at 11:50:22AM +0100, Thomas Bogendoerfer wrote: > > On Wed, Mar 15, 2023 at 05:14:24AM +0000, Matthew Wilcox (Oracle) wrote: > > > Rename _PFN_SHIFT to PFN_PTE_SHIFT. Convert a few places > > > to call set_pte() instead of set_pte_at(). Add set_ptes(), > > > update_mmu_cache_range(), flush_icache_pages() and flush_dcache_folio(). > > > > /local/tbogendoerfer/korg/linux/mm/memory.c: In function ‘set_pte_range’: > > /local/tbogendoerfer/korg/linux/mm/memory.c:4290:2: error: implicit declaration of function ‘update_mmu_cache_range’ [-Werror=implicit-function-declaration] > > update_mmu_cache_range(vma, addr, vmf->pte, nr); > > > > update_mmu_cache_range() is missing in this patch. > > Oops. And mips was one of the arches I did a test build for! > > Looks like we could try to gain some efficiency by passing 'nr' to > __update_tlb(), but as far as I can tell, that's only called for r3k and > r4k, so maybe it's not worth optimising at this point? hmm, not sure if that would help. R4k style TLB has two PTEs mapped per TLB entry. So by advancing per page __update_tlb() is called more often than needed. > Anyway, this add-on makes the mips build compile for me and I'll fold > it into v5. tested your v4 with the add-on on QEMU Malta and real hardware without problems so far. I'll give v5 another spin. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]