From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C8EC76195 for ; Mon, 20 Mar 2023 18:09:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B1AC6B0074; Mon, 20 Mar 2023 14:09:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83BD06B0078; Mon, 20 Mar 2023 14:09:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B31D6B007B; Mon, 20 Mar 2023 14:09:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 558476B0074 for ; Mon, 20 Mar 2023 14:09:31 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 223CC80E1B for ; Mon, 20 Mar 2023 18:09:31 +0000 (UTC) X-FDA: 80590064142.07.7FE6B3B Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2055.outbound.protection.outlook.com [40.107.244.55]) by imf01.hostedemail.com (Postfix) with ESMTP id 1F0C840021 for ; Mon, 20 Mar 2023 18:09:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=vxnpdECU; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf01.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.55 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679335768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gBqqtCCyNrjVVfmw0bqz563/qEySO7Z84R6+44BArg4=; b=KPy8fNktFeGTB38a1RbKpWvmQCyHl2ONA0yDpCAjzmsOI5JGtpm1QFxLmtPRhSBPwbem4d wNtFmXGZ1uSowAfLm6iN1FqKr08XpRhMiZyQdhV5kn/XFft2zruhkPH7DwjwvTDOX0DF/K x3ZfBOJUDrrqMW4UbHrtHVpdOhe2v4w= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=vxnpdECU; dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf01.hostedemail.com: domain of Michael.Roth@amd.com designates 40.107.244.55 as permitted sender) smtp.mailfrom=Michael.Roth@amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1679335768; a=rsa-sha256; cv=pass; b=UYKMt83odkt6kSNcMv0yNIDroq3XuwfUKDlZejT0xC2gDrevitpt9zd14AvYA7Y9Bz7cg3 JyKfJbwIPQuscCsoZ3ISaLenWKdnwhB86t24eg2MMlNfTyW7IIIWDIoKLojr0dSmzpOBwi IvObSkinnkCMToF1pdrbTmtgfGq1BaQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mDaZYYZ9D8A8XMznK7rgomK0Ol3F1v8yKPtHL8cq+Lyypk8LTLAp1hlDc09j2ZHQpPGmjTWs9+lRlSoECduGj68jw/mTPAeSyynh08IktIEQG5hjYchroB4tn1WjhhXlfM+LDNT/yiQzZ5WmUDyH14TRxfLRMmtv2vqLtQv91J/aWrOQyb/cBE9/zBbet0Dn/5S13SIhlF4emHgJwavcxR3uO/oeYDFuicnaxkXYKMkEo3IKsuMjNP583qiRAsfpn3ixJrZMHtKQGKdtuhAn8I0epJJrXHCflyVVwJEPmq+2zaEvXQQgeCTKh1yNInw3GRKc7tg0kNgNECP+Zu5EFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gBqqtCCyNrjVVfmw0bqz563/qEySO7Z84R6+44BArg4=; b=F/7qs86ON1ljUD6X+T0MPAZZufBRzwzdlHTa4k7W1MurxF5UwSPb8tP9/20v4zW6Cq1j+QXWjqp7b/6r1leEzdCo9thaVRVfFfylywFZSukLU4R1Z29wxzBYofoT8+V715YRsQC1uBhoZ6VpU/KP9slsxQfm3iKsvFv5BdC07nYG13+lhY+ArG0Iz2PK5KSNw/2c5ASwTZDQYcAwgSRgiHpN0aafupOnjsD/eAfEpABsJx1p0pWrzQOrSe+ixktnzfLmz7xMqvQwYrFQHIc9LyXARZUP/MBtq32S+iTfnPR6rx8mYpTy2HSpvV0mYFA8zd2weCtnfplWbJ/NnTHpRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gBqqtCCyNrjVVfmw0bqz563/qEySO7Z84R6+44BArg4=; b=vxnpdECUpxjXKP7tFcv/8b9VZnSQoVzHMyh0HDNlx5np3wxSihkqmtnlWvMgnpPhKqvSO7yGsIdxwOw6OwQIVPWW0FhEMLsR+oPJ2sARP1WeT9LFmIFVytsTcD//gqFsTc1pO45YT4biVqNQo5NEGs3WN8jpf9ev4h93xQ+Bx6s= Received: from BN9PR03CA0739.namprd03.prod.outlook.com (2603:10b6:408:110::24) by CY5PR12MB6202.namprd12.prod.outlook.com (2603:10b6:930:25::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 18:09:25 +0000 Received: from BN8NAM11FT110.eop-nam11.prod.protection.outlook.com (2603:10b6:408:110:cafe::a8) by BN9PR03CA0739.outlook.office365.com (2603:10b6:408:110::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend Transport; Mon, 20 Mar 2023 18:09:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT110.mail.protection.outlook.com (10.13.176.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 18:09:25 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 20 Mar 2023 13:09:24 -0500 Date: Mon, 20 Mar 2023 13:09:09 -0500 From: Michael Roth To: Isaku Yamahata CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH RFC v8 03/56] KVM: x86: Add platform hooks for private memory invalidations Message-ID: <20230320180909.gsffri3fdfdleewc@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-4-michael.roth@amd.com> <20230318051322.GF408922@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230318051322.GF408922@ls.amr.corp.intel.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT110:EE_|CY5PR12MB6202:EE_ X-MS-Office365-Filtering-Correlation-Id: 10fa67c9-8272-414d-2135-08db296e3d0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CAjiZp2+DdMErGjMGhW9oxqU39Qp8byZzx/+/ys8LIeIvgff6+5PyrJmaIO4CD0T7ue3UV0cUFr/ViRraB/yY8UQO1Ys7fNh/f/iADG/KMZ/4CryAQPkCF4IhC6+HNpkC2Zq9+KnamlhHpvQXYZ1RpKV52U350pQphuRZpm1aiu0zdyR0ux4I10gyzS+0uXy99zz4xTrGgjYRG5Lv/pLOFIaAzfwTU9vFlzU+PPAgeYPtIabtF9GHDETax204wN9BiimD/yVwgAP3lOiPsSeo3FbKlJFDiZV+xWwuRliy44iGKh2mHy7Lh/fuEsYCjmc3boSRar/WHrU6cBtgQuZiuKtnOBTsFmxvTbOfAnWhZpGonqImoN1hYIuXAVjciWyqHD4vH+Yd2NCq37NmSBDHEyUbj2njWIg0lj0tb/q+ueZ1eGNiSJaZHEcqcA4rp8hMq0T60/yY+iYT6zxwbpvgXpEdlNEALUSNmAYzfTXFthlPZAKN7WRHdmZ0JszRhn/vb3OBx374z+1m8i/gWFknHqIQPk+M5SoyrfMT5wEpNJ8MHzp2gODzUDWc8iVY9YoNsPjZCE4yPcKBuHCAFPIZzD88/z5n9jrdixPX5HfiBJdHBgFXWyRmqIiq7XqIwmSK1myy40Xa0c0a6A7ZsEE055bVHB5v8qij+NnA36NgNOIIjqZpFHkWmxxU/BE58Tniw2X4sa3LWhQxorYc1q2UblYRt6lM99c2sdF2QFWBMU= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199018)(36840700001)(40470700004)(46966006)(426003)(316002)(40480700001)(47076005)(44832011)(54906003)(70586007)(36860700001)(70206006)(36756003)(8936002)(8676002)(6916009)(4326008)(7416002)(7406005)(41300700001)(5660300002)(2906002)(478600001)(86362001)(40460700003)(81166007)(82740400003)(83380400001)(82310400005)(356005)(336012)(6666004)(2616005)(186003)(16526019)(1076003)(26005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2023 18:09:25.0065 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10fa67c9-8272-414d-2135-08db296e3d0e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT110.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6202 X-Rspamd-Queue-Id: 1F0C840021 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: sksfi15spybemm73wsx1jjgr1ghmdhk7 X-HE-Tag: 1679335767-697131 X-HE-Meta: U2FsdGVkX19vVtkfcYLAp3IaHCAIbyCR5d1i9O0hFljDHi8USyYmZ52kwI+xPuVOyiekp6g3mO88tK8A54XMLNhf89IywV457y4oEujQkWAet46Wao9WtmoN2GMhFGWuy/wvph1StDRILxlTkwIB94dfktZQkVZY+YXJXgzbgz4TaYXhsYaZCzyA6pyaIxvyL1u3Sxk10lbCoZlSjL3ypNO0898Cv5lMwMO+wbTMh+RjIA9GNNQbI6apWeNzl7wt0Q4evBMyU7w3c6CvGTWM4+MDPlXxi9VNf18+Y4JsKTP4ReHUab3lMhHQC/1QwNExafw41Nd7nzfpSekqhlbwICzvad00FVmW0WDY1tBR+tUe0TI9EbyciHxvse34R5U034SKYrap6UhcEYnR7xFygovJeqI0uVLRDHDr4QSmgzY7m+Yw/ALJNnTi8xF5OsjHuOMooLB4a2I31ox5blLORCdZtjmv6Icm+rPgDj4Y6droEpkhVPhyZYiTHoLzYuHMK86P4cyz33+3JMUxqSivA+6R+zI06uUpnmfQqO5VzGHXXKnhrip82bc1uVenzRIBatXY7096NzpDlyRkk4iXNp4otYZNZ/48RPyujCU4TSEGVlG3aHTHmu8GHyz36DRJylrhnoNQArl9kUZPszsv+3ZuBkgxFT9rpMSPGpsjY3ITBMSh+ZVwoqD7QsnWL8IVurw5ot4GXO9P6/7jfIdS2vEWcZ3ZTzxY/lcv+tBp6bXHOHUoNMeIVylhVhSfVw68rSPHd/QrUR59ph0faQZrscn+OH5Ts8JLjPXQDDTuCv/wCEKjnzzhDvYuTo2F4vDx+0p8mSWRgqfkC5emY85FtjugAw/Ih1polAtTykS0GZ33ym+Z5ICMNRCnFMS29iNF1gDb45N1IaoIErQttFm6Qq68Va7/zxmUJohzLv1HJxxLFh1wvCxTm9drXNZIuxvvsh+tZLgbaEw9lRxjRwU 7DmL6XLL U+gCb4iC4LjPMhbuH4uIbaXqHmwueDxckoJsLqTNApUBjm9f2PS14AKIp0COZ67DJB/3PKTPJUjIloPs86P1Ytj2AQywhB1nEohKgrUDdlA56nl+g9fKOMHL9oLvGMKRiqbQzpg+L1c+MauUO2U30TfwXk+co9quXL6zNFabHQ3FmLi6hJvncIhPAk4bUe4+b5duM+2SOMQSPmJ/FKcp+pwaEnmMo5bLheK9sIeLYdZvUqwAUKv5mWlzYJSTRZ7e4Mw444+E0rr8k/83oB18Qelp9msRAOeU6XXoIY9c361cTE+nElns/uotbmqPFMDhNTwracgXULPEQGBFnZmFpDydksZfytKbj8ESNLYaCZ2yx7LdjJ/ueYk6qlknpnsb1RBzsB2jM0XyRN4UolwGWQ2X7weBvUueldwLT+HOQnBoOojRGB+SAUtTJUQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 17, 2023 at 10:13:22PM -0700, Isaku Yamahata wrote: > On Mon, Feb 20, 2023 at 12:37:54PM -0600, > Michael Roth wrote: > > > In some cases, like with SEV-SNP, guest memory needs to be updated in a > > platform-specific manner before it can be safely freed back to the host. > > Add hooks to wire up handling of this sort to the invalidation notifiers > > for restricted memory. > > > > Also issue invalidations of all allocated pages during notifier/memslot > > unbinding so that the pages are not left in an unusable state when > > they eventually get freed back to the host upon FD release. > > I'm just curios. Could you please elaborate? > Unbind is happen only when memory slot is delete or vm is destroyed. In the > case of memory slot deletion, the gpa region is zapped via > kvm_arch_commit_memory_region(). In the case of VM destroy, we have > kvm_flush_shadow_all() which calls > kvm_arch_flush_shadow_all() =>kvm_mmu_zap_all(). Doesn't it work? The main thing here is unbind happens right before the restrictedmem pages are released back to the host, and for SNP we need to clear the associated RMP table entries to switch them from guest-owned to hypervisor-owned. It doesn't necessarily need to be a separate callback, but I'm not sure if it makes sense to squash that down into the various MMU zapping helpers. -Mike > > Thanks, > -- > Isaku Yamahata