From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786F6C76195 for ; Sat, 25 Mar 2023 00:52:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C93306B0071; Fri, 24 Mar 2023 20:52:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C437E6B0074; Fri, 24 Mar 2023 20:52:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE3AC6B0075; Fri, 24 Mar 2023 20:52:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9AD016B0071 for ; Fri, 24 Mar 2023 20:52:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 65D5C1A0B95 for ; Sat, 25 Mar 2023 00:52:05 +0000 (UTC) X-FDA: 80605593810.07.D08D8BB Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf22.hostedemail.com (Postfix) with ESMTP id 55FA4C0008 for ; Sat, 25 Mar 2023 00:52:02 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="S Vyu3+W"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Kwa9zywo; dmarc=none; spf=pass (imf22.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.29 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679705522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=263d8X9NDnlXPj9Gft3I5NwFp7vjifRWFXPErnNXYcg=; b=Sga89PglmBDgmPLmDHWVglinqS/l80GxaN7Xoy2pwe/Mta0eBMHZcQWvt5yJM5++SzzxDs 0zVuwBzhvNLXLaFlbghrEYj+PlfcVOfBuAxetlkU5UxNIonzP5Ag9zvxvbcfuTr2+34Gvq PnCfffrWk5Yv33fOA10m4RiuTdcceew= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm3 header.b="S Vyu3+W"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=Kwa9zywo; dmarc=none; spf=pass (imf22.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.29 as permitted sender) smtp.mailfrom=kirill@shutemov.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679705522; a=rsa-sha256; cv=none; b=cGtcxDmL7gF79587AhCuuqG7AVjgKeAekPU6wBU9CNbIdWznDGM2UNc/JfUw7r1pvbG0NS D7atdd5cwH21IbDRWQBUV7y2BBRnZbH/39BYJUciG15GysHgi5wRCuQ5bVLiyS2SNNP520 G57mRKRrNaZCJvvU4w7tO/xVP3rBTJQ= Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id AA04D5C00AB; Fri, 24 Mar 2023 20:52:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 24 Mar 2023 20:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1679705521; x= 1679791921; bh=263d8X9NDnlXPj9Gft3I5NwFp7vjifRWFXPErnNXYcg=; b=S Vyu3+WT1SQ/rpL2qc2AVcRZtC1GHV0VANuJwsnb7O6eD3ujY53Zq2C3RNp2VhjD9 kSJ1EJ+Zw8yt4dt4g3tdsF1epmgk+Y6dQqQgcvUGi2Qm+ja16GcM4FbDwObo6gtI pi04vLMwFg2BUmjNBkoYk22EYsqJa2AQac4Lu5WU+AHgsM+9gV29MBa4Zfq11uKe Cy80Bewh3fXKQ8hOB5sa9akOYIKgrGYGEpYbUpQDYkJfyKigqbDZuGUUy4PRV3H7 g9yEbctH5adS87bZ9xOH2G4HXbXRGkaPvNmwBaRyqIDV/UFqqbPhQNcpOq9xBlCi foSWP7R2Wwlzk7OJDskSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679705521; x=1679791921; bh=263d8X9NDnlXP j9Gft3I5NwFp7vjifRWFXPErnNXYcg=; b=Kwa9zywoQPN5tt82AYZ+Wg9Z9klHk 7RvusbiekcY51nEhKGK2jcIRMl+Rozu+uM2p5mQEVNXqvrqtsb7ApH7sJyLF7233 ZwYOmAPZS0IKtWacHr4094ha8LJn4jQOAu5avofXNR9tl0ewf7J/aZzYgGIXaj1R 9UXuVNSMj3xQxAGEAj8lBhd5dYv4CDUFe8xJ+uYDYqZzGUYpnmDz1r5AV26g7BYF IkQozErZ0/l8GfKLgFN/xYXIXSFqiFQO2xAKLcu8EmUpuHK1ssxJ2jiIy2X+eQrR pV1qTU4O1HdJBgP7IwY/9mSxS/LZc8mhtVU/btMEdix83nf6OgAJFqmjw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegjedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpeelgffhfeetlefhveffleevfffgtefffeelfedu udfhjeduteeggfeiheefteehjeenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirhhilhhl sehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Mar 2023 20:52:00 -0400 (EDT) Received: by box.shutemov.name (Postfix, from userid 1000) id 0EE5310A607; Sat, 25 Mar 2023 03:51:57 +0300 (+03) Date: Sat, 25 Mar 2023 03:51:57 +0300 From: "Kirill A. Shutemov" To: Borislav Petkov Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Dario Faggioli , Dave Hansen , Mike Rapoport , David Hildenbrand , Mel Gorman , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, aarcange@redhat.com, peterx@redhat.com, x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv8 06/14] efi/x86: Implement support for unaccepted memory Message-ID: <20230325005157.37b4alnuf6p6mh66@box.shutemov.name> References: <20221207014933.8435-1-kirill.shutemov@linux.intel.com> <20221207014933.8435-7-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 55FA4C0008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: dkczfgjb8yuqph1a7msuw55f35tzn81u X-HE-Tag: 1679705522-635280 X-HE-Meta: U2FsdGVkX1/Zdr3zwQmxF+IxdWzZXjBj1bVaCNBV7/L3jkEwMxXS8ClGAHAjWrgr8xb15MhmCDolho2ViWXqa2/86bzu5bslGJFqAz0UmkKlepbV7VekZinMgFrQFAEkJK5A8VKvIU/9b35hcY9K/uCSHDWX0IAkbwDdimdAeq1XhPQPYAATTWbuca5ffyRArWBkgFqQbJT6gsIgeJYO0ASFqMo1PJj3JZNfh63ioegJU9OzYZlx8yRwInSZ29zupto+U8NXhpcfqBUiE6zLGdrwjMMSD0X9fD/IVsP1pCoJF60Ufh2aW/Shqls8emi8KgVKCBufvRU4lMpUcMwftpIS+llkd0ZITCzVugzqXoarNaWUSkjhFHBoAzvqhj2nIda9DfEsu7euUzQa79n6bYmark/Zgyqu4KqfKDKuDRJ1CzGulHYAdhHCm0l63nFTL0xkdm3gZq3RxHEku4WDw1XRu4iWROt/FbcXX5TKaRoMcD83bGcCz17+olliGrR4VmTFlzhTx5qOoMHdIkUXBM9uj0l4QWOgs/55ydHoZyAME/a88PwLfS6h5KYE+R02UfL7F5Av3UPn+PlCmsXEorVO1J92Wv/2SgBOysYJi4+dOAVf9jZLQLiSsVCgNUIPjtRC5/Lqj2zS5MdjRtbH6WIKsfIJtC2PTPqKJZZCc82w9iuAA+Y8QvM7CR272dNxP4jiSPbN0olPJWXbivFWGv0CQ8CJRAVmEG46Iv8viR/sJBHK0C7o1JLF7UHxjfsAJ9XH8fcQKG+5XnAyolHBOh7o4mvIVSa1D6KM/r/zkaK+B/Bpt7BB6/tnwpEDFVz7Vr4/VNDBEbHlKU0Rvc9a7UoJq1OOXyd5af+LwFJh0pQ2ejdVPjrmmw14O7yFqDoWQe1zVweASURJrRdL88/3tBzHATtA7IMMrnyE1aJz2RQ1lmUu/vgMKANFVu79ZXps/hcMxulNvLQrOJ/lgA+ w3z+0Bhw ixV3KYf/r2/AXuRl6BbSARuRGtu9ZffwaInrtj3hMR8vRa2MQnoFon5qd4fT6w4AHjt+to4LvKjC11WQx7DXPUxbl6PIksYDORfAdFlCAZNo9ItVxzuiGCgjfTnSSmvPYci2v4W37hHPs0goKGuu6VGPHACppV/u8Xa1oXFkTkZsWgUIxOtffh+Z/uhDfTHreiLrj+5opGqt0e33WE5oOzU5KM62u4vmjblfGnpFF3PvnYxowwzY4masdWf8doa77/tcdA42UxFlnQ5qD6bXGFVG24MFbQuZy5teqcDvnoh59VbEuBcGIgI/efSs1BA7LB97sZUFJVg44voRVYRmhPNbh7HdWp2+YNQxRrWO0asbsnj56ZSLoFNB0zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 03, 2023 at 03:20:55PM +0100, Borislav Petkov wrote: > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig > > index 6787ed8dfacf..8aa8adf0bcb5 100644 > > --- a/drivers/firmware/efi/Kconfig > > +++ b/drivers/firmware/efi/Kconfig > > @@ -314,6 +314,20 @@ config EFI_COCO_SECRET > > virt/coco/efi_secret module to access the secrets, which in turn > > allows userspace programs to access the injected secrets. > > > > +config UNACCEPTED_MEMORY > > + bool > > + depends on EFI_STUB > > This still doesn't make a whole lotta sense. If I do "make menuconfig" I don't > see the help text because that bool doesn't have a string prompt. So who is that > help text for? It is a form of documentation for a developer. The same happens for other options. For instance, BOOT_VESA_SUPPORT or ARCH_HAS_CURRENT_STACK_POINTER. Yes, it is not visible user, but I still think it is helpful for a developer to understand what the option does. > Then, in the last patch you have > > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -888,6 +888,8 @@ config INTEL_TDX_GUEST > select ARCH_HAS_CC_PLATFORM > select X86_MEM_ENCRYPT > select X86_MCE > + select UNACCEPTED_MEMORY > + select EFI_STUB > > I guess you want to select UNACCEPTED_MEMORY only. I had to rework it as config INTEL_TDX_GUEST ... depends on EFI_STUB select UNACCEPTED_MEMORY Naked select UNACCEPTED_MEMORY doesn't work if EFI and EFI_STUB is disabled: WARNING: unmet direct dependencies detected for UNACCEPTED_MEMORY Depends on [n]: EFI [=n] && EFI_STUB [=n] Selected by [y]: - INTEL_TDX_GUEST [=y] && HYPERVISOR_GUEST [=y] && X86_64 [=y] && CPU_SUP_INTEL [=y] && X86_X2APIC [=y] IIUC, the alternative is to have selects all the way down the option tree. > > And I've already mentioned this whole mess: > > https://lore.kernel.org/r/Yt%2BnOeLMqRxjObbx@zn.tnic > > Please incorporate all review comments before sending a new version of > your patch. > > Ignoring review feedback is a very unfriendly thing to do: > > - if you agree with the feedback, you work it in in the next revision > > - if you don't agree, you *say* *why* you don't Sorry, it was not my intention. I misread your comment and focused on build issues around the option. -- Kiryl Shutsemau / Kirill A. Shutemov