From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B51C48BC3 for ; Tue, 20 Feb 2024 12:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C307B6B0075; Tue, 20 Feb 2024 07:43:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE0826B0078; Tue, 20 Feb 2024 07:43:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF7086B007B; Tue, 20 Feb 2024 07:43:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9ECA46B0075 for ; Tue, 20 Feb 2024 07:43:27 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 74533A06C9 for ; Tue, 20 Feb 2024 12:43:27 +0000 (UTC) X-FDA: 81812148054.24.B1CF0C7 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf19.hostedemail.com (Postfix) with ESMTP id 844121A0006 for ; Tue, 20 Feb 2024 12:43:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708433005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A5Qg9AD9QaJGHrmowQ3/i732QXFnUk1aude2RyMjZIo=; b=TGWGhUzGamOspsEXmjA89+Nq9IsHmhkwR6I5ImhO8J0FodpDWxnPTpEly+v31O67m2LzLm 1w+ORE/eMHaiWJX19rdKrGXbAppvdy1pAakK+YStUXMTtU+IMI71+ijO9G9HVuBevTZ8DX 4/8zlNWhfEa9bb/bqpjcEhfB48WDBqs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708433005; a=rsa-sha256; cv=none; b=4qDVsEoB6roHPRsVfC2Y/gvvIdmRSJOMdP10tamDRkf0V0nwr9zIbdQRqPFHiRMHgxYt9w jbbCVC3HbKsgSpNgy51lGQojOrAbTfXI+w2EkFP+9lf89Zj9t0CVdlBZzULNRHCmLiqxmt /vNVhUtj3poBQ+PHQjJ+NvQ9pTv5IFU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TfJqr1qWVz6D94n; Tue, 20 Feb 2024 20:39:04 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 26DA0140C98; Tue, 20 Feb 2024 20:43:21 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 20 Feb 2024 12:43:20 +0000 Date: Tue, 20 Feb 2024 12:43:19 +0000 From: Jonathan Cameron To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [RFC PATCH v6 07/12] cxl/memscrub: Register CXL device patrol scrub with scrub configure driver Message-ID: <20240220124319.00005be0@Huawei.com> In-Reply-To: <20240215111455.1462-8-shiju.jose@huawei.com> References: <20240215111455.1462-1-shiju.jose@huawei.com> <20240215111455.1462-8-shiju.jose@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-Stat-Signature: 58erchzcafeur1h1ai5wt33eoyx5md1r X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 844121A0006 X-Rspam-User: X-HE-Tag: 1708433005-834122 X-HE-Meta: U2FsdGVkX1+z7/wBYOu1TW+N/ZxY+Yzc7AkvOF0ucqnSczNUU89GihyDggL9WKSI2K/dyAqJ47iWeTa56tYfdBMP2bPacMLnWSPp/+vFrE6OulP6JmenmShqsl5XGZLu/v2phzXvDF0fv3DHOklTezEu2NY952ja5OU88uX0aqOTVXIJlrqtueqaYxJVtyQY+UTVx/lfsLzo5F4XNeiciWiYI3usL6u/+fs7CvkEI6edq9Q7uHDWyG58M8JUYQoKHsBohWPgRwOtZMe3gup7y1XQliLksA7+lzr8TEEbnj2VYL5Lpqo63TXxB/jjR9hnRo9mPHp+uha5vXBbkwUlxh99rIzcqqhKgJBDPpx16c9M7pbTvNGy/jqTd29IcaETqVoESIB2d5Rp1JSfSRfNjyqVn1ajbaLiBQ7V512TQ9pUYTnMOUwqxL2TOazNmZ0lvyA0FA04Q49LZClEDi5CIoQMpRykVNwcxIVfPwysCW3Z47D3jw3GDoJnwLM2JNE8vDezgnELz3qw3xEW/2yxB5Yq1I6T+yU9CELG3pU5tCtAYRnITHRNd/j7QcTgvnK/ysH2PiJv6GNFdyz8jJBEDnPpze+QIYUHm5DqW7lw0PoYvDaUQKNBrM+yQiPzEU8eXrq5CJXJOWJbeYx4bHlw50dTDRJplJ6Oaq30FXiwiKKec0TVDPu2HSjiWcpYmOSGbytW7MNNUCyDt6h1czDbwUuF7ojIBorw76nXC1qTNrhK2Ict6qFfd0Iy7H29qSVDwYCDiSSI1PpaARozw+/02UVA8tcPGYHggJQCs8l7HC5wv0oPwVJV5qoSb0GicxskHQgC/lQBYS4saeKi/RMit5IGDlJ0hEeQJ2gDQoL02mLSqqVjXYmDOcWawWfYsyR/zxh8eIGr4rE+iQjj7R+w/5SnC/QRWe4/uhiB6bY6b41Lb0zFTymaDsXPahvolpKYrl+Ow6qt2DIgX2iqlZn Vlw/Wz2l YZmJSxnMfsPocFTKNKOQGFqQBP14WAasiqcGqlMb3zzpLJQmiMVDQEkXB0FMzj7Hd/zTADAmfTcm7IZ1pYNRLI9KW3NTQlHp5RjkwLZlN3SK19ge5ghCfSNR8AKPB+fyN1TkDiNnFxoWBD/uzx3BnZBEAtOqjJFKI8G4LC31JyChvQ58aAuo9ae3mu+nrrhN1MV3Y+gvO9AKOGllUAeTUB+VQ1fwETLuQxSlr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 15 Feb 2024 19:14:49 +0800 wrote: > From: Shiju Jose > > Register with the scrub configure driver to expose the sysfs attributes > to the user for configuring the CXL device memory patrol scrub. Add the > callback functions to support configuring the CXL memory device patrol > scrub. > > Signed-off-by: Shiju Jose Trivial comment inline. > diff --git a/drivers/cxl/core/memscrub.c b/drivers/cxl/core/memscrub.c > index a3a371c5aa7b..a1fb40f8307f 100644 > --- a/drivers/cxl/core/memscrub.c > +++ b/drivers/cxl/core/memscrub.c > @@ -6,14 +6,19 @@ > + > +/** > + * cxl_mem_patrol_scrub_is_visible() - Callback to return attribute visibility > + * @dev: Pointer to scrub device > + * @attr: Scrub attribute > + * @region_id: ID of the memory region > + * > + * Returns: 0 on success, an error otherwise > + */ > +static umode_t cxl_mem_patrol_scrub_is_visible(struct device *dev, > + u32 attr_id, int region_id) > +{ > + const struct cxl_patrol_scrub_context *cxl_ps_ctx = dev_get_drvdata(dev); > + > + if (attr_id == scrub_rate_available || > + attr_id == scrub_rate) { > + if (!cxl_ps_ctx->scrub_cycle_changeable) > + return 0; > + } > + > + switch (attr_id) { > + case scrub_rate_available: > + return 0444; Usual trick on these is to write back their default values if we support them. If we can make this function take that as well then this bcomes return mode; for all those supported. > + case scrub_enable: > + case scrub_rate: > + return 0644; > + default: > + return 0; > + } > +} > +