From: Peng Zhang <zhangpeng362@huawei.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Cc: <akpm@linux-foundation.org>, <dennisszhou@gmail.com>,
<shakeelb@google.com>, <jack@suse.cz>, <surenb@google.com>,
<kent.overstreet@linux.dev>, <mhocko@suse.cz>, <vbabka@suse.cz>,
<yuzhao@google.com>, <yu.ma@intel.com>,
<wangkefeng.wang@huawei.com>, <sunnanyong@huawei.com>,
<zhangpeng362@huawei.com>
Subject: [RFC PATCH v2 0/2] mm: convert mm's rss stats to use atomic mode
Date: Thu, 18 Apr 2024 22:20:06 +0800 [thread overview]
Message-ID: <20240418142008.2775308-1-zhangpeng362@huawei.com> (raw)
From: ZhangPeng <zhangpeng362@huawei.com>
Since commit f1a7941243c1 ("mm: convert mm's rss stats into
percpu_counter"), the rss_stats have converted into percpu_counter,
which convert the error margin from (nr_threads * 64) to approximately
(nr_cpus ^ 2). However, the new percpu allocation in mm_init() causes a
performance regression on fork/exec/shell. Even after commit 14ef95be6f55
("kernel/fork: group allocation/free of per-cpu counters for mm struct"),
the performance of fork/exec/shell is still poor compared to previous
kernel versions.
To mitigate performance regression, we delay the allocation of percpu
memory for rss_stats. Therefore, we convert mm's rss stats to use
percpu_counter atomic mode. For single-thread processes, rss_stat is in
atomic mode, which reduces the memory consumption and performance
regression caused by using percpu. For multiple-thread processes,
rss_stat is switched to the percpu mode to reduce the error margin.
We convert rss_stats from atomic mode to percpu mode only when the
second thread is created.
After lmbench test, we can get 2% ~ 4% performance improvement
for lmbench fork_proc/exec_proc/shell_proc and 6.7% performance
improvement for lmbench page_fault (before batch mode[1]).
The test results are as follows:
base base+revert base+this patch
fork_proc 416.3ms 400.0ms (3.9%) 398.6ms (4.2%)
exec_proc 2095.9ms 2061.1ms (1.7%) 2047.7ms (2.3%)
shell_proc 3028.2ms 2954.7ms (2.4%) 2961.2ms (2.2%)
page_fault 0.3603ms 0.3358ms (6.8%) 0.3361ms (6.7%)
[1] https://lore.kernel.org/all/20240412064751.119015-1-wangkefeng.wang@huawei.com/
ChangeLog:
v2->v1:
- Convert rss_stats from atomic mode to percpu mode only when
the second thread is created per Jan Kara.
- Compared with v1, the performance data may be different due to
different test machines.
ZhangPeng (2):
percpu_counter: introduce atomic mode for percpu_counter
mm: convert mm's rss stats to use atomic mode
include/linux/mm.h | 50 +++++++++++++++++++++++++++++-----
include/linux/percpu_counter.h | 43 +++++++++++++++++++++++++++--
include/trace/events/kmem.h | 4 +--
kernel/fork.c | 18 +++++++-----
lib/percpu_counter.c | 31 +++++++++++++++++++--
5 files changed, 125 insertions(+), 21 deletions(-)
--
2.25.1
next reply other threads:[~2024-04-18 14:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 14:20 Peng Zhang [this message]
2024-04-18 14:20 ` [RFC PATCH v2 1/2] percpu_counter: introduce atomic mode for percpu_counter Peng Zhang
2024-04-18 19:40 ` Andrew Morton
2024-04-19 2:55 ` zhangpeng (AS)
2024-04-26 8:11 ` Dennis Zhou
2024-04-29 7:45 ` zhangpeng (AS)
2024-04-18 14:20 ` [RFC PATCH v2 2/2] mm: convert mm's rss stats to use atomic mode Peng Zhang
2024-04-19 2:30 ` Rongwei Wang
2024-04-19 3:32 ` zhangpeng (AS)
2024-04-20 3:13 ` Rongwei Wang
2024-04-20 8:44 ` zhangpeng (AS)
2024-05-16 11:50 ` Kairui Song
2024-05-16 15:14 ` Mateusz Guzik
2024-05-17 3:29 ` Kairui Song
2024-05-17 18:08 ` Mateusz Guzik
2024-05-19 14:13 ` Dennis Zhou
2024-04-24 4:29 ` [RFC PATCH v2 0/2] " zhangpeng (AS)
2024-04-24 4:51 ` Dennis Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418142008.2775308-1-zhangpeng362@huawei.com \
--to=zhangpeng362@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=dennisszhou@gmail.com \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=shakeelb@google.com \
--cc=sunnanyong@huawei.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=yu.ma@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).