From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27F9C433E7 for ; Mon, 19 Oct 2020 07:15:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 83BD022243 for ; Mon, 19 Oct 2020 07:15:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83BD022243 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=h3c.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 948376B0068; Mon, 19 Oct 2020 03:15:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F90E6B006C; Mon, 19 Oct 2020 03:15:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80F546B006E; Mon, 19 Oct 2020 03:15:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0091.hostedemail.com [216.40.44.91]) by kanga.kvack.org (Postfix) with ESMTP id 539436B0068 for ; Mon, 19 Oct 2020 03:15:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E4E44180AD811 for ; Mon, 19 Oct 2020 07:15:02 +0000 (UTC) X-FDA: 77387813244.29.scene66_1d0d59c27235 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id C166B18086CC7 for ; Mon, 19 Oct 2020 07:15:01 +0000 (UTC) X-HE-Tag: scene66_1d0d59c27235 X-Filterd-Recvd-Size: 3684 Received: from h3cspam02-ex.h3c.com (smtp.h3c.com [60.191.123.50]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 07:15:00 +0000 (UTC) Received: from DAG2EX01-BASE.srv.huawei-3com.com ([10.8.0.64]) by h3cspam02-ex.h3c.com with ESMTPS id 09J7EToK036675 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Oct 2020 15:14:29 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) by DAG2EX01-BASE.srv.huawei-3com.com (10.8.0.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 19 Oct 2020 15:14:31 +0800 Received: from DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074]) by DAG2EX03-BASE.srv.huawei-3com.com ([fe80::5d18:e01c:bbbd:c074%7]) with mapi id 15.01.2106.002; Mon, 19 Oct 2020 15:14:31 +0800 From: Tianxianting To: Michal Hocko CC: "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "kuba@kernel.org" , "alexei.starovoitov@gmail.com" Subject: RE: [PATCH] mm: Make allocator take care of memoryless numa node Thread-Topic: [PATCH] mm: Make allocator take care of memoryless numa node Thread-Index: AQHWoHLpCFmBht8fWEyQ1LSKDhVJgamTi1oAgAnlFDCAAJVdAIAAh0lA Date: Mon, 19 Oct 2020 07:14:31 +0000 Message-ID: <20b7b8ae56894985a1ac0187426bc248@h3c.com> References: <20201012082739.15661-1-tian.xianting@h3c.com> <20201012150554.GE29725@dhcp22.suse.cz> <10ae851702e346369db44e1ec9c830fb@h3c.com> <20201019070644.GB27114@dhcp22.suse.cz> In-Reply-To: <20201019070644.GB27114@dhcp22.suse.cz> Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.99.141.128] x-sender-location: DAG2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-DNSRBL: X-MAIL:h3cspam02-ex.h3c.com 09J7EToK036675 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Michal, Yes, it is the commit bffed457160ab. Sorry I forgot to paste it in my previ= ous reply. -----Original Message----- From: Michal Hocko [mailto:mhocko@suse.com]=20 Sent: Monday, October 19, 2020 3:07 PM To: tianxianting (RD) Cc: cl@linux.com; penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@l= ge.com; akpm@linux-foundation.org; linux-mm@kvack.org; linux-kernel@vger.ke= rnel.org; kuba@kernel.org; alexei.starovoitov@gmail.com Subject: Re: [PATCH] mm: Make allocator take care of memoryless numa node On Sun 18-10-20 14:18:37, Tianxianting wrote: > Thanks for the comments > I found in current code, there are two places to call > local_memory_node(node) before calling kzalloc_node(), I think we can=20 > remove them? I am not sure which code you are talking about. git grep shows me 2 places = in blk-mq code (e.g. bffed457160ab) and that looks quite bogus to me. Bring= that up with the respective maintainer and Raghavendra. The changelog doesn't really describe any problem, if there is any. But fro= m the allocator semantic point of view memory less nodes are to be expected= and the allocator should fallback to the proper node. As long as __GFP_THI= SNODE is not enforced of course. -- Michal Hocko SUSE Labs