From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92D60C432BE for ; Wed, 18 Aug 2021 16:35:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CC9A6104F for ; Wed, 18 Aug 2021 16:35:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2CC9A6104F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BE8946B006C; Wed, 18 Aug 2021 12:35:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B98718D0001; Wed, 18 Aug 2021 12:35:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60236B0073; Wed, 18 Aug 2021 12:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 8850A6B006C for ; Wed, 18 Aug 2021 12:35:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 17C9C820FEDB for ; Wed, 18 Aug 2021 16:35:10 +0000 (UTC) X-FDA: 78488751180.06.F42E39C Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) by imf04.hostedemail.com (Postfix) with ESMTP id 93DD35003D72 for ; Wed, 18 Aug 2021 16:35:09 +0000 (UTC) Received: by mail-oo1-f48.google.com with SMTP id h7-20020a4ab4470000b0290263c143bcb2so871061ooo.7 for ; Wed, 18 Aug 2021 09:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=FsOxk8xEX3Y2k9eBNIFeNmSd4j8BBkPPy3JPmJxj3/A=; b=U6Cdj7fZ/XePCbSUaZ7pv7n0S7sZkSrrOrA9PbU1L8v/HM8wLDGFAtzaqmhZeRCQga j1SiL+lfuclQI80WNGXNb0vfYzs3GYQj/RJ4tWupVUBJHspqZqwi9kU88AP6qTfMHIDg /vIsALWorZO51q+BwrYTeQspOrHLJ5bBrTfawtFk3TR1fTrpcuMJTjXy2KumNBCw3k3X bIIAVYo2uhL/IO/3MbQK6Wh0OQd+7F+Rb9lhAvbbSrQa4EvJwpTW+rgsD/KHC5i+Jk8A ffiUGP1m/lge6y90sUevzKZJtzTSL9d2yvVoskChXQCqkKBDR2kx5Fxpapho1Hi2TfG9 wvQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=FsOxk8xEX3Y2k9eBNIFeNmSd4j8BBkPPy3JPmJxj3/A=; b=ECai2M82ZSKMkjSPwSeqg9D1Z3kOBIK5/Ysz9CROAWRrWlbgfIaV3i7I1C6EH8MRgD 4pQuFwqCCYtEKQZkJ5ob8pJ2LCAOBImuC0ZyPKkB9RJ4r4MdUNg74cL6tRticus7Bm9j U7LAaEnkowUKaFNsBCmj8JhWdmstDHXXjG+9ffl245yIVia+PQzbK0Xx4dt7fFgK15w2 cV8dIb2KfuBpv2uPAJYdp+u/5iB2tptyKIC16sOiC3hUOI9ZP1Qo0uW6c1TV3jmLAaWK KnosJ9fR+Gmy6JZG2ABazWhrB3P1ONZogqdo1It0725dvQaurPshwhEJ0VXq9bSNOuMM K6bQ== X-Gm-Message-State: AOAM531bqEwCUdzVPihar3KIO7Lq/cyvnGqNgpOAploNF7/mlE/g3gbC V97EFo2qkSY6PsSWBPfNRbr+yg== X-Google-Smtp-Source: ABdhPJxVQCjOlNDLHatSHn/5DyaB1NIFWcKsb6VB8oS9/r0EckuXMuKL0P7R99uExi1pgZo6aBpaYQ== X-Received: by 2002:a4a:3393:: with SMTP id q141mr1269993ooq.48.1629304508535; Wed, 18 Aug 2021 09:35:08 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id k21sm98571ots.53.2021.08.18.09.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 09:35:07 -0700 (PDT) Date: Wed, 18 Aug 2021 09:34:51 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: "Matthew Wilcox (Oracle)" cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm: Remove bogus VM_BUG_ON In-Reply-To: <20210818144932.940640-1-willy@infradead.org> Message-ID: <2197941-297c-f820-aa57-fb5167794fb1@google.com> References: <20210818144932.940640-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=U6Cdj7fZ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of hughd@google.com designates 209.85.161.48 as permitted sender) smtp.mailfrom=hughd@google.com X-Stat-Signature: if4jxijkatcqk3ooxubf5xbyxdnznx5n X-Rspamd-Queue-Id: 93DD35003D72 X-Rspamd-Server: rspam05 X-HE-Tag: 1629304509-251247 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 18 Aug 2021, Matthew Wilcox (Oracle) wrote: > It is not safe to check page->index without holding the page lock. > It can be changed if the page is moved between the swap cache and the > page cache for a shmem file, for example. There is a VM_BUG_ON below > which checks page->index is correct after taking the page lock. > > Cc: stable@vger.kernel.org > Fixes: 5c211ba29deb ("mm: add and use find_lock_entries") I don't mind that VM_BUG_ON_PAGE() being removed, but question whether this Fixes anything, and needs to go to stable. Or maybe it's just that the shmem example is wrong - moving shmem from page to swap cache does not change page->index. Or maybe you have later changes in your tree which change that and do require this. Otherwise, I'll have to worry why my testing has missed it for six months. Hugh > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/filemap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index d1458ecf2f51..34de0b14aaa9 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2033,17 +2033,16 @@ unsigned find_lock_entries(struct address_space *mapping, pgoff_t start, > XA_STATE(xas, &mapping->i_pages, start); > struct page *page; > > rcu_read_lock(); > while ((page = find_get_entry(&xas, end, XA_PRESENT))) { > if (!xa_is_value(page)) { > if (page->index < start) > goto put; > - VM_BUG_ON_PAGE(page->index != xas.xa_index, page); > if (page->index + thp_nr_pages(page) - 1 > end) > goto put; > if (!trylock_page(page)) > goto put; > if (page->mapping != mapping || PageWriteback(page)) > goto unlock; > VM_BUG_ON_PAGE(!thp_contains(page, xas.xa_index), > page); > -- > 2.30.2