From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D09D3C433EF for ; Mon, 7 Feb 2022 14:41:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D2846B0074; Mon, 7 Feb 2022 09:41:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481816B0075; Mon, 7 Feb 2022 09:41:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 321A96B0078; Mon, 7 Feb 2022 09:41:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 1F99B6B0074 for ; Mon, 7 Feb 2022 09:41:33 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D0081181C77DE for ; Mon, 7 Feb 2022 14:41:32 +0000 (UTC) X-FDA: 79116247224.17.9477382 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 50C47120004 for ; Mon, 7 Feb 2022 14:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644244891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U9/EMlgIN9QXIzc+zISwktBd/gJFAPg2HMGjyGTDEMA=; b=aiPepKf2MMZcIuZwpsrKqPUYNaHolapraVzYqTqHIarTlN49A4iDpZT2Ce/qbRhm2WXASl WUWCdrD0DCNI8xft1CIgprqmYqpT9Phz67VmtPtJHAPkTYu+sqwOLy0C9sWzxYIWh/6kmF h3Us9pbU8s1tFUtofEACS7Fr6bH8m14= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-RPU_4oaiPSufPeWZpwTgKA-1; Mon, 07 Feb 2022 09:41:23 -0500 X-MC-Unique: RPU_4oaiPSufPeWZpwTgKA-1 Received: by mail-ed1-f72.google.com with SMTP id q11-20020a5085cb000000b0040f7eceaf7aso1270409edh.14 for ; Mon, 07 Feb 2022 06:41:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=U9/EMlgIN9QXIzc+zISwktBd/gJFAPg2HMGjyGTDEMA=; b=NdNRyEB7S9EDdONReaoj/u3Wm9AIjrtRS/DfaXOP6Xq6Xfw4R23S10avmx21FSeOra pkuMAI0fGvSuscBygB5isMtXpsrZT/3JH4evxnWFS8R8qhMnF3/HDQhEqoUXD02yP9IE T9vQYEF/OaB5wcTIMit7bIRtddy5OAFiX4jcO1WpQkedGkObe+L8hFOEWhNmNGZpXvb7 VrEPGEwQ/4fzYW4gBeErUoiUYGG92uqblSVrvfeEbHv/iy8nECU+PegaMpKRk3cS+MlE 7DTBTZhJwsXGJYKYngpdpjUBmOXikRZlvHt1ruTyOhrjmE2WM+ulAxnuKPi00+E3HlIv rAsg== X-Gm-Message-State: AOAM531oeQWplLLtAmlIuxdcmD7BaC+4h1EzGb3J1wnj1gH5Pp42WAfs CRey8upVT9loui1tf9NeE3GXec2Z4poLx534HTu4wgPltoBq5iXmxEox6Zjr5595PBU3UYwtEeT Fzx3t55iHDBU= X-Received: by 2002:a17:907:2d14:: with SMTP id gs20mr38342ejc.149.1644244882615; Mon, 07 Feb 2022 06:41:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJz4IMukBv8fxsbw6O/G7HxMpzkkml2E+JB1htfZ/eDniqAe1gLNoBCTjInbUP2QXv6052x03g== X-Received: by 2002:a17:907:2d14:: with SMTP id gs20mr38320ejc.149.1644244882287; Mon, 07 Feb 2022 06:41:22 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6300:a751:d742:1f76:8639? (p200300cbc7096300a751d7421f768639.dip0.t-ipconnect.de. [2003:cb:c709:6300:a751:d742:1f76:8639]) by smtp.gmail.com with ESMTPSA id j1sm390581ejx.123.2022.02.07.06.41.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Feb 2022 06:41:21 -0800 (PST) Message-ID: <21cec396-9d6a-03b7-716d-2a84c79eeb73@redhat.com> Date: Mon, 7 Feb 2022 15:41:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 1/4] mm/memory_hotplug: remove obsolete comment of __add_pages To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220207133643.23427-1-linmiaohe@huawei.com> <20220207133643.23427-2-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220207133643.23427-2-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 50C47120004 X-Stat-Signature: phh4xx8fpekqaox81cxnijp5rikdjtc3 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aiPepKf2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf29.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1644244892-599450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.02.22 14:36, Miaohe Lin wrote: > Since commit f1dd2cd13c4b ("mm, memory_hotplug: do not associate hotadded > memory to zones until online"), there is no need to pass in the zone. > > Signed-off-by: Miaohe Lin > --- > mm/memory_hotplug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index a4f69d399929..cbc67c27e0dd 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -296,10 +296,7 @@ struct page *pfn_to_online_page(unsigned long pfn) > EXPORT_SYMBOL_GPL(pfn_to_online_page); > > /* > - * Reasonably generic function for adding memory. It is > - * expected that archs that support memory hotplug will > - * call this function after deciding the zone to which to > - * add the new pages. > + * Reasonably generic function for adding memory. > */ > int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages, > struct mhp_params *params) I'd suggest just removing the comment completely. -- Thanks, David / dhildenb