From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7488CC2BA83 for ; Wed, 12 Feb 2020 06:35:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38F23206DB for ; Wed, 12 Feb 2020 06:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="gFtlJ2xh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38F23206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCE9B6B03E0; Wed, 12 Feb 2020 01:35:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7FDE6B03E1; Wed, 12 Feb 2020 01:35:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94DC6B03E2; Wed, 12 Feb 2020 01:35:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 902ED6B03E0 for ; Wed, 12 Feb 2020 01:35:37 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 92B22181AEF10 for ; Wed, 12 Feb 2020 06:35:36 +0000 (UTC) X-FDA: 76480513872.03.coat54_30df9e2d0fa30 X-HE-Tag: coat54_30df9e2d0fa30 X-Filterd-Recvd-Size: 4605 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 06:35:35 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48HVJN3wSdz9v06n; Wed, 12 Feb 2020 07:35:32 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=gFtlJ2xh; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id PvBBu-t-JaUP; Wed, 12 Feb 2020 07:35:32 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48HVJN2lyTz9v06f; Wed, 12 Feb 2020 07:35:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581489332; bh=mlBXvnRSGUCMJcLvyWdPUsSnuUQABm7mYvYTkvnlvKQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=gFtlJ2xhwbWh4Vdp/x6dY5YLM1BIT7PaMh3LwZ3vY6YtDgtifOwEessIltwhksQ5J Pil+ErH8sbKpTy4eVbENdNudj4LU302HjybNQV8MqKMPPxbTTw1DWFoJrCMJpCcc5B GUKsSkzRdsVdvXTkWfVdMAJ4kPxs7L1ZgloAr9cI= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 37B568B7FF; Wed, 12 Feb 2020 07:35:33 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id mOVzraGcf1N3; Wed, 12 Feb 2020 07:35:33 +0100 (CET) Received: from [172.25.230.102] (po15451.idsi0.si.c-s.fr [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0D1FD8B75B; Wed, 12 Feb 2020 07:35:33 +0100 (CET) Subject: Re: [PATCH v6 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support To: Daniel Axtens , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com Cc: Michael Ellerman References: <20200212054724.7708-1-dja@axtens.net> <20200212054724.7708-5-dja@axtens.net> From: Christophe Leroy Message-ID: <224745f3-db66-fe46-1459-d1d41867b4f3@c-s.fr> Date: Wed, 12 Feb 2020 07:35:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200212054724.7708-5-dja@axtens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 12/02/2020 =C3=A0 06:47, Daniel Axtens a =C3=A9crit=C2=A0: > diff --git a/arch/powerpc/include/asm/kasan.h b/arch/powerpc/include/as= m/kasan.h > index fbff9ff9032e..2911fdd3a6a0 100644 > --- a/arch/powerpc/include/asm/kasan.h > +++ b/arch/powerpc/include/asm/kasan.h > @@ -2,6 +2,8 @@ > #ifndef __ASM_KASAN_H > #define __ASM_KASAN_H > =20 > +#include > + > #ifdef CONFIG_KASAN > #define _GLOBAL_KASAN(fn) _GLOBAL(__##fn) > #define _GLOBAL_TOC_KASAN(fn) _GLOBAL_TOC(__##fn) > @@ -14,29 +16,41 @@ > =20 > #ifndef __ASSEMBLY__ > =20 > -#include > - > #define KASAN_SHADOW_SCALE_SHIFT 3 > =20 > #define KASAN_SHADOW_START (KASAN_SHADOW_OFFSET + \ > (PAGE_OFFSET >> KASAN_SHADOW_SCALE_SHIFT)) > =20 > +#ifdef CONFIG_KASAN_SHADOW_OFFSET > #define KASAN_SHADOW_OFFSET ASM_CONST(CONFIG_KASAN_SHADOW_OFFSET) > +#endif > =20 > +#ifdef CONFIG_PPC32 > #define KASAN_SHADOW_END 0UL > =20 > -#define KASAN_SHADOW_SIZE (KASAN_SHADOW_END - KASAN_SHADOW_START) > +#ifdef CONFIG_KASAN > +void kasan_late_init(void); > +#else > +static inline void kasan_late_init(void) { } > +#endif > + > +#endif > + > +#ifdef CONFIG_PPC_BOOK3S_64 > +#define KASAN_SHADOW_END (KASAN_SHADOW_OFFSET + \ > + (RADIX_VMEMMAP_END >> KASAN_SHADOW_SCALE_SHIFT)) > + > +static inline void kasan_late_init(void) { } > +#endif > =20 > #ifdef CONFIG_KASAN > void kasan_early_init(void); > void kasan_mmu_init(void); > void kasan_init(void); > -void kasan_late_init(void); > #else > static inline void kasan_init(void) { } > static inline void kasan_mmu_init(void) { } > -static inline void kasan_late_init(void) { } > #endif Why modify all this kasan_late_init() stuff ? This function is only called from kasan init_32.c, it is never called by=20 PPC64, so you should not need to modify anything at all. Christophe