From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A09C4338F for ; Wed, 11 Aug 2021 12:30:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0E7E6101E for ; Wed, 11 Aug 2021 12:30:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A0E7E6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1959D6B0071; Wed, 11 Aug 2021 08:30:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1460F8D0003; Wed, 11 Aug 2021 08:30:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 033FB8D0002; Wed, 11 Aug 2021 08:30:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E272D6B0071 for ; Wed, 11 Aug 2021 08:30:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 947521BCBE for ; Wed, 11 Aug 2021 12:30:23 +0000 (UTC) X-FDA: 78462732726.22.F7A7A92 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf07.hostedemail.com (Postfix) with ESMTP id E2FF41000F5F for ; Wed, 11 Aug 2021 12:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628685022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=++F32s6NyzrMcJ6QkU/iMFSAu/4raHLUOF3ZnxBpv3o=; b=SVQqj9R3wIkn5O1onyrBI1z8DMDkEFUJ/sRrOFbJ9oxDCv8xkAPIf2JqprWe2DAFZCO/g2 yG+gTGk1QpNp0eHctqUmOJOTrhj5pESgzkBNZ43MdSP7EXEIAxfuIgnco6l1rZ8s8Lmz6h Of0g4OVjuViFyDqBwEDUBKE1MjhjIS4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-V34PEIdXOKO4kGMbz2BpBg-1; Wed, 11 Aug 2021 08:30:18 -0400 X-MC-Unique: V34PEIdXOKO4kGMbz2BpBg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54F8F1009E39; Wed, 11 Aug 2021 12:30:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18988620DE; Wed, 11 Aug 2021 12:30:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-80-willy@infradead.org> References: <20210715033704.692967-80-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 079/138] mm/filemap: Add readahead_folio() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2384707.1628685015.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 11 Aug 2021 13:30:15 +0100 Message-ID: <2384708.1628685015@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E2FF41000F5F Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SVQqj9R3; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf07.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: ukouy669bqoofn8nenj5g8xucrr14i3o X-HE-Tag: 1628685022-295956 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > +/** > + * readahead_folio - Get the next folio to read. > + * @ractl: The current readahead request. > + * > + * Context: The folio is locked. The caller should unlock the folio on= ce > + * all I/O to that folio has completed. > + * Return: A pointer to the next folio, or %NULL if we are done. > + */ > +static inline struct folio *readahead_folio(struct readahead_control *r= actl) > +{ > + struct folio *folio =3D __readahead_folio(ractl); > = > - return page; > + folio_put(folio); This will oops if __readahead_folio() returns NULL. > + return folio; > }