From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303DEC636CA for ; Wed, 21 Jul 2021 13:25:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DB46561246 for ; Wed, 21 Jul 2021 13:25:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB46561246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 942F76B0036; Wed, 21 Jul 2021 09:25:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E15D6B0073; Wed, 21 Jul 2021 09:25:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 659946B0074; Wed, 21 Jul 2021 09:25:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id 4409C6B0070 for ; Wed, 21 Jul 2021 09:25:00 -0400 (EDT) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve05.hostedemail.com (Postfix) with ESMTP id 8C7F318391D60 for ; Wed, 21 Jul 2021 10:58:48 +0000 (UTC) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2C08F1AA9A for ; Wed, 21 Jul 2021 10:58:48 +0000 (UTC) X-FDA: 78386297136.29.8A9FC2F Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id B184B3000D89 for ; Wed, 21 Jul 2021 10:58:47 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DAA7631B; Wed, 21 Jul 2021 03:58:46 -0700 (PDT) Received: from [10.163.64.235] (unknown [10.163.64.235]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3935E3F99C; Wed, 21 Jul 2021 03:58:42 -0700 (PDT) Subject: Re: [PATCH v3 01/12] mm/debug_vm_pgtable: Introduce struct pgtable_debug_args From: Anshuman Khandual To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com, Christophe Leroy , Gerald Schaefer , Qian Cai , "Aneesh Kumar K.V" References: <20210719130613.334901-1-gshan@redhat.com> <20210719130613.334901-2-gshan@redhat.com> <280a5740-b5dc-4b78-3a38-67e5adbb0afd@redhat.com> Message-ID: <23bb5363-fd36-5161-0ba2-da1efc3e3018@arm.com> Date: Wed, 21 Jul 2021 16:29:33 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: hj1sinx4whetxhkxtaiyqjocrmthmk3u X-Rspamd-Queue-Id: B184B3000D89 X-Rspamd-Server: rspam01 X-HE-Tag: 1626865127-22708 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/21/21 4:09 PM, Anshuman Khandual wrote: >=20 > On 7/21/21 3:50 PM, Gavin Shan wrote: >> Hi Anshuman, >> >> On 7/21/21 3:44 PM, Anshuman Khandual wrote: >>> On 7/19/21 6:36 PM, Gavin Shan wrote: >>>> In debug_vm_pgtable(), there are many local variables introduced to >>>> track the needed information and they are passed to the functions fo= r >>>> various test cases. It'd better to introduce a struct as place holde= r >>>> for these information. With it, what the functions for various test >>>> cases need is the struct, to simplify the code. It also makes code >>>> easier to be maintained. >>>> >>>> Besides, set_xxx_at() could access the data on the corresponding pag= es >>>> in the page table modifying tests. So the accessed pages in the test= s >>>> should have been allocated from buddy. Otherwise, we're accessing pa= ges >>>> that aren't owned by us. This causes issues like page flag corruptio= n. >>>> >>>> This introduces "struct pgtable_debug_args". The struct is initializ= ed >>>> and destroyed, but the information in the struct isn't used yet. The= y >>>> will be used in subsequent patches. >>>> >>>> Signed-off-by: Gavin Shan >>>> --- >>>> =C2=A0 mm/debug_vm_pgtable.c | 197 +++++++++++++++++++++++++++++++++= ++++++++- >>>> =C2=A0 1 file changed, 196 insertions(+), 1 deletion(-) >>>> >> I saw you've finished the review on PATCH[v3 01/12] and PATCH[v3 02/12= ]. >> I will wait to integrate your comments to v4 until you finish the revi= ew >> on all patches in v3 series > Yes, please do wait for the complete review and test before going for V= 4. > Also please add the following emails on copy next time, so that we migh= t > have some more reviews here. Thank you. >=20 > + Christophe Leroy > + Gerald Schaefer This one instead. Gerald Schaefer