From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-acpi@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()"
Date: Wed, 31 Jul 2019 15:18:42 +0200 [thread overview]
Message-ID: <23f28590-7765-bcd9-15f2-94e985b64218@redhat.com> (raw)
In-Reply-To: <20190731131408.GP9330@dhcp22.suse.cz>
On 31.07.19 15:14, Michal Hocko wrote:
> On Wed 31-07-19 15:02:49, David Hildenbrand wrote:
>> On 31.07.19 14:53, Michal Hocko wrote:
>>> On Wed 31-07-19 14:32:01, David Hildenbrand wrote:
>>>> Let's document why we take the lock here. If we're going to overhaul
>>>> memory hotplug locking, we'll have to touch many places - this comment
>>>> will help to clairfy why it was added here.
>>>
>>> And how exactly is "lock for consistency" comment going to help the poor
>>> soul touching that code? How do people know that it is safe to remove it?
>>> I am not going to repeat my arguments how/why I hate "locking for
>>> consistency" (or fun or whatever but a real synchronization reasons)
>>> but if you want to help then just explicitly state what should done to
>>> remove this lock.
>>>
>>
>> I know that you have a different opinion here. To remove the lock,
>> add_memory() locking has to be changed *completely* to the point where
>> we can drop the lock from the documentation of the function (*whoever
>> knows what we have to exactly change* - and I don't have time to do that
>> *right now*).
>
> Not really. To remove a lock in this particular path it would be
> sufficient to add
> /*
> * Although __add_memory used down the road is documented to
> * require lock_device_hotplug, it is not necessary here because
> * this is an early code when userspace or any other code path
> * cannot trigger hotplug operations.
> */
Okay, let me phrase it like this: Are you 100% (!) sure that we don't
need the lock here. I am not - I only know what I documented back then
and what I found out - could be that we are forgetting something else
the lock protects.
As I already said, I am fine with adding such a comment instead. But I
am not convinced that the absence of the lock is 100% safe. (I am 99.99%
sure ;) ).
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-07-31 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 12:32 [PATCH v1] drivers/acpi/scan.c: Fixup "acquire device_hotplug_lock in acpi_scan_init()" David Hildenbrand
2019-07-31 12:53 ` Michal Hocko
2019-07-31 13:02 ` David Hildenbrand
2019-07-31 13:14 ` Michal Hocko
2019-07-31 13:18 ` David Hildenbrand [this message]
2019-07-31 13:33 ` Michal Hocko
2019-07-31 13:37 ` David Hildenbrand
2019-07-31 13:44 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f28590-7765-bcd9-15f2-94e985b64218@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).