From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WZEt=C7=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 255E1C4727D
	for <linux-mm@archiver.kernel.org>; Tue, 22 Sep 2020 00:08:44 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 859A223A6C
	for <linux-mm@archiver.kernel.org>; Tue, 22 Sep 2020 00:08:43 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="SYPWmsd+"
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 859A223A6C
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id C238590000B; Mon, 21 Sep 2020 20:08:42 -0400 (EDT)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id BD581900004; Mon, 21 Sep 2020 20:08:42 -0400 (EDT)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id AEA4C90000B; Mon, 21 Sep 2020 20:08:42 -0400 (EDT)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24])
	by kanga.kvack.org (Postfix) with ESMTP id 95D72900004
	for <linux-mm@kvack.org>; Mon, 21 Sep 2020 20:08:42 -0400 (EDT)
Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay03.hostedemail.com (Postfix) with ESMTP id 5EA928249980
	for <linux-mm@kvack.org>; Tue, 22 Sep 2020 00:08:42 +0000 (UTC)
X-FDA: 77288761284.25.cry21_3408c7a27149
Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251])
	by smtpin25.hostedemail.com (Postfix) with ESMTP id 3A9B91804E3A0
	for <linux-mm@kvack.org>; Tue, 22 Sep 2020 00:08:42 +0000 (UTC)
X-HE-Tag: cry21_3408c7a27149
X-Filterd-Recvd-Size: 3690
Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65])
	by imf08.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Tue, 22 Sep 2020 00:08:41 +0000 (UTC)
Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
	id <B5f69407b0000>; Mon, 21 Sep 2020 17:08:27 -0700
Received: from [10.2.52.174] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 22 Sep
 2020 00:08:39 +0000
Subject: Re: [PATCH 4/5] mm: Do early cow for pinned pages during fork() for
 ptes
To: Jann Horn <jannh@google.com>
CC: Peter Xu <peterx@redhat.com>, Linux-MM <linux-mm@kvack.org>, kernel list
	<linux-kernel@vger.kernel.org>, Linus Torvalds
	<torvalds@linux-foundation.org>, Michal Hocko <mhocko@suse.com>, "Kirill
 Shutemov" <kirill@shutemov.name>, Oleg Nesterov <oleg@redhat.com>, "Kirill
 Tkhai" <ktkhai@virtuozzo.com>, Hugh Dickins <hughd@google.com>, "Leon
 Romanovsky" <leonro@nvidia.com>, Jan Kara <jack@suse.cz>, Christoph Hellwig
	<hch@lst.de>, Andrew Morton <akpm@linux-foundation.org>, Jason Gunthorpe
	<jgg@ziepe.ca>, Andrea Arcangeli <aarcange@redhat.com>
References: <20200921211744.24758-1-peterx@redhat.com>
 <20200921212028.25184-1-peterx@redhat.com>
 <CAG48ez3frkqQNHbE5bEB6rwYdbyoAA3B9FQZo=HKkUzWCM4H0Q@mail.gmail.com>
 <07bc5f59-74ae-73e8-2616-f11712c27b58@nvidia.com>
 <CAG48ez1Y0==PxR_h6PoRAcxTABM5o0FRR4ow+z7V3W52xNYm_w@mail.gmail.com>
From: John Hubbard <jhubbard@nvidia.com>
Message-ID: <24037577-0b96-4d8c-9487-8e788fbc29eb@nvidia.com>
Date: Mon, 21 Sep 2020 17:08:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAG48ez1Y0==PxR_h6PoRAcxTABM5o0FRR4ow+z7V3W52xNYm_w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
	t=1600733307; bh=pICGIgAAbiHAuske7W1id4qK5tmRw17lO8+nrtcOwW4=;
	h=Subject:To:CC:References:From:Message-ID:Date:User-Agent:
	 MIME-Version:In-Reply-To:Content-Type:Content-Language:
	 Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy;
	b=SYPWmsd+dUkTOoJG4eRvvYWKKvK78cSn5KzELaZzoRknrDMUJmzPBs3udYNmixYtO
	 gtwRnx454MPX3QSm/RpBoEa+02m5cCdMMh4ORJqCW3fBXuZsWduJ3rzxHDrK67mp3r
	 4NFix4SbBUX8JshseEBi9Kz4CQYgpOOSNuZBVNBEYFTT9MmRV8za/w4ZyORDH0iODD
	 j/oFnSj071MnxkodIXgXLL2kL7kAZgvqNdqnlAbUYiOssatNfGHczbK0DtjszrQXp1
	 090E3B5dRl4ir5GLltzEsi4UuXg8X5uIasw9I8EB0zJ1Ek1izP9rVYZ1zzSquXnYEy
	 gmRo3eTHLZmOA==
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

On 9/21/20 3:27 PM, Jann Horn wrote:
> On Tue, Sep 22, 2020 at 12:18 AM John Hubbard <jhubbard@nvidia.com> wrote:
>> On 9/21/20 2:55 PM, Jann Horn wrote:
>>> On Mon, Sep 21, 2020 at 11:20 PM Peter Xu <peterx@redhat.com> wrote:
>> ...
> Ah... the documentation you linked implies that FOLL_WRITE should more
> or less imply FOLL_PIN? I didn't realize that.
> 

hmmm, that does seem like a pretty close approximation. It's certainly
true that if we were only doing reads, and also never marking pages
dirty, that the file system writeback code would be OK.

For completeness we should add: even just reading a page is still a
problem, if one also marks the page as dirty (which is inconsistent and
wrong, but still). That's because the file system code can then break,
during writeback in particular.


thanks,
-- 
John Hubbard
NVIDIA