From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D86BCC48BD1 for ; Wed, 9 Jun 2021 10:29:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BCEB601FC for ; Wed, 9 Jun 2021 10:29:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCEB601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BE7F6B0036; Wed, 9 Jun 2021 06:29:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06F486B006E; Wed, 9 Jun 2021 06:29:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E036D6B0070; Wed, 9 Jun 2021 06:29:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id AD1766B0036 for ; Wed, 9 Jun 2021 06:29:50 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3CF4B181AEF23 for ; Wed, 9 Jun 2021 10:29:50 +0000 (UTC) X-FDA: 78233814540.04.E22DD1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 9CAEDA000151 for ; Wed, 9 Jun 2021 10:29:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623234589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AJKYvOGfDayI4ypz9NAHeg8C4iNhTE3Xb47rb4M/evg=; b=iIdlpVCchbbkxBRywuUDJlDowGg9GdpTNo5wrI33rKD4x1KEDb6POAqKcXdtuFz/4K0u3U 90c6XqWR3KAmunMB9x/3e9Z3/jleBKZCiJDpE4xPL+5NPWfzNplsPe0JKLrP5S20kh2E2Z RdNW3lowlwm5h9iZ7Ht09rOh1yzcko0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-N7hIhxHQP-uuewuZVYrt7g-1; Wed, 09 Jun 2021 06:29:48 -0400 X-MC-Unique: N7hIhxHQP-uuewuZVYrt7g-1 Received: by mail-wr1-f72.google.com with SMTP id n2-20020adfb7420000b029010e47b59f31so10481062wre.9 for ; Wed, 09 Jun 2021 03:29:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=AJKYvOGfDayI4ypz9NAHeg8C4iNhTE3Xb47rb4M/evg=; b=AdErDOq+uWFwI4E/4zpL1Ft2f+fp5S7QmEGKLVx3XM2fdy+yTj3QHGhQSC1veEItz6 iarZjwHXNPWyQJ8tWPrgKe4OPHkqBft8ao1okqs6/Xsjy+r5aw3VREua2zydS0k57AqE zYA/qIUdPZXzBHSwub4Re3ogi/6PNIdEbx9zTZvGgCKvd18iLFoLyhXD3R0arw0DVew7 aQJQI0UVSiNpVo52vDdfy1DCY+lG8xWuEPDY78hvTQpBBEGW4Egdd1znWjVjlwuXvYHI VHAhOMGGSf2YL/RFYtYdgnUJlJfQQEyj1wVIUxhhAsMz3jwi4gsEBdq4hAQ4vmV+HwCt TXLA== X-Gm-Message-State: AOAM531NG72XS5IAuWr9ah+v0ylFRwIjFh3f2J9YAUZPDozXUObl351Q 3KBtGte9Ro7I47iydWggvIwBqSZ0be5uzKL0MEixldoU+JMcAJcNplzmMaY488HzPHfHyDgf+9A xG7XxtpAWi9I= X-Received: by 2002:a7b:c7cd:: with SMTP id z13mr26158567wmk.54.1623234586775; Wed, 09 Jun 2021 03:29:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCfBKsc2hGpGgzPI6TcBFUmWxmoZcYpHa6oSIzEs8X7cR/V+42wF1QK1U6zdDyobK3zOUdiQ== X-Received: by 2002:a7b:c7cd:: with SMTP id z13mr26158555wmk.54.1623234586577; Wed, 09 Jun 2021 03:29:46 -0700 (PDT) Received: from [192.168.3.132] (p5b0c611d.dip0.t-ipconnect.de. [91.12.97.29]) by smtp.gmail.com with ESMTPSA id y8sm5616010wmi.45.2021.06.09.03.29.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 03:29:46 -0700 (PDT) Subject: Re: [PATCH] mm/page_alloc: fix counting of managed_pages To: Liu Shixin , Andrew Morton , yangerkun , Kefeng Wang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210527125707.3760259-1-liushixin2@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <24751c12-b43e-7860-015b-09d204e6e397@redhat.com> Date: Wed, 9 Jun 2021 12:29:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210527125707.3760259-1-liushixin2@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iIdlpVCc; spf=none (imf24.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: mssoo3koh1hb7b9yziumme88ugb8nuro X-Rspamd-Queue-Id: 9CAEDA000151 X-Rspamd-Server: rspam06 X-HE-Tag: 1623234585-139505 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 27.05.21 14:57, Liu Shixin wrote: > The commit f63661566fad (mm/page_alloc.c: clear out zone->lowmem_reserve[] > if the zone is empty) clear out zone->lowmem_reserve[] if zone is empty. > But when zone is not empty and sysctl_lowmem_reserve_ratio[i] is set to zero, > zone_managed_pages(zone) is not counted in the managed_pages either. This is > inconsistent with the description of lowmen_reserve, so fix it. > > Fixes: f63661566fad ("mm/page_alloc.c: clear out zone->lowmem_reserve[] if the zone is empty") > Reported-by: yangerkun > Signed-off-by: Liu Shixin > --- > mm/page_alloc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index aaa1655cf682..49a2efce5a84 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8061,14 +8061,14 @@ static void setup_per_zone_lowmem_reserve(void) > unsigned long managed_pages = 0; > > for (j = i + 1; j < MAX_NR_ZONES; j++) { > - if (clear) { > - zone->lowmem_reserve[j] = 0; > - } else { > - struct zone *upper_zone = &pgdat->node_zones[j]; > + struct zone *upper_zone = &pgdat->node_zones[j]; > + > + managed_pages += zone_managed_pages(upper_zone); > > - managed_pages += zone_managed_pages(upper_zone); > + if (clear) > + zone->lowmem_reserve[j] = 0; > + else > zone->lowmem_reserve[j] = managed_pages / ratio; > - } > } > } > } > Acked-by: David Hildenbrand -- Thanks, David / dhildenb