From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D82BC433B4 for ; Mon, 3 May 2021 08:07:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E093E6121E for ; Mon, 3 May 2021 08:07:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E093E6121E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 271A86B0036; Mon, 3 May 2021 04:07:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FAEC6B006E; Mon, 3 May 2021 04:07:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 025D56B0070; Mon, 3 May 2021 04:07:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id D71D16B0036 for ; Mon, 3 May 2021 04:07:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8C3D08249980 for ; Mon, 3 May 2021 08:07:06 +0000 (UTC) X-FDA: 78099189252.09.F78C24C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D0F5190009EF for ; Mon, 3 May 2021 08:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620029225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lQ3DC7AtOQDLcIS5zcoeo9H4pxzVMTr3J/iLQuTR5t4=; b=NSJnrhdvykM8Ym//8lkb3B/CbF8jLgJIlfG7QMRIvmUAvdzVA4VHxjAeBKgMfLjyi8qq7U t6j06Fj28E7J/Bs55E+o+DCr+3ledwfdeu5w6PiyWbb+sfhDn9LLSWT0izy6sHLpXr6O8n kGtqDJcz2N/7sgVpWQzQ0CkcQVzrUBU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-521-LuCdQepUP8OoZxl680LPDw-1; Mon, 03 May 2021 04:07:03 -0400 X-MC-Unique: LuCdQepUP8OoZxl680LPDw-1 Received: by mail-wm1-f69.google.com with SMTP id y184-20020a1ce1c10000b0290143299f39d7so2152467wmg.4 for ; Mon, 03 May 2021 01:07:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lQ3DC7AtOQDLcIS5zcoeo9H4pxzVMTr3J/iLQuTR5t4=; b=f/88DyD3GW3Vt/MFWOvX6xjWhgOyVylxaZwdBh3DbLYWefZXpEzfpEtn5rww35VQ96 Ynx9klP44JcPfFDitxt94dU4Rhk0+fZWeq0rJJ4VrY61rLY7l60WUGu/Snskg7K4lyML 9P+Q4Hlt9dUeNohu2fbG2NtBxHjnpUMhGtSKiPit2n4mRcLaQcX1rJXlCCsu/xtD/Dgq tZadxngBI4t4lpjUEOygWsR5RVtf07GBDVK9/NvmHpiZUSmFTzifI4pSxODRIYqHQRrv izQ4Rp08Cc6zVbPiT9w6T0RPg/N2Gyi/vUHVcRge0qPkp0pAIWv+drL+BxLaBA3BR4nv pOuQ== X-Gm-Message-State: AOAM533sQwYnLMK+WRWO8X/SzzRZm+tuHclsI5P5JVkylXuEnxKvdqsJ 7fMVl0Y9jraehPq2gYMEJw0WPh3iVerED4qD9/RcJhk6RSK/Nzke0GggUrgipIGUW/FjpyVMNdL M7UHx9YfMoOMvVmyz54lejTMDdsBKr49htUtcgrpVTuSNhQwbpCoBaUUao1s= X-Received: by 2002:a5d:53c9:: with SMTP id a9mr23514600wrw.108.1620029222819; Mon, 03 May 2021 01:07:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztudGlR+1pwFh0JGWAmGAGZpGgLxmVHb9G+bDK9iqTp0teBnknMNyF222oyWVrdGbBg32OIQ== X-Received: by 2002:a5d:53c9:: with SMTP id a9mr23514565wrw.108.1620029222505; Mon, 03 May 2021 01:07:02 -0700 (PDT) Received: from [192.168.3.132] (p5b0c649f.dip0.t-ipconnect.de. [91.12.100.159]) by smtp.gmail.com with ESMTPSA id f6sm13386613wru.72.2021.05.03.01.07.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 01:07:02 -0700 (PDT) Subject: Re: arm32: panic in move_freepages (Was [PATCH v2 0/4] arm64: drop pfn_valid_within() and simplify pfn_valid()) To: Mike Rapoport , Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, Andrew Morton , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <2d879629-3059-fd42-428f-4b7c2a73d698@huawei.com> <259d14df-a713-72e7-4ccb-c06a8ee31e13@huawei.com> <6ad2956c-70ae-c423-ed7d-88e94c88060f@huawei.com> <0cb013e4-1157-f2fa-96ec-e69e60833f72@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <24b37c01-fc75-d459-6e61-d67e8f0cf043@redhat.com> Date: Mon, 3 May 2021 10:07:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NSJnrhdv; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf19.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D0F5190009EF X-Stat-Signature: 9kutpdauhu48wp44uk4zf5mrh9fpup41 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620029194-177759 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.05.21 08:26, Mike Rapoport wrote: > On Fri, Apr 30, 2021 at 07:24:37PM +0800, Kefeng Wang wrote: >> >> >> On 2021/4/30 17:51, Mike Rapoport wrote: >>> On Thu, Apr 29, 2021 at 06:22:55PM +0800, Kefeng Wang wrote: >>>> >>>> On 2021/4/29 14:57, Mike Rapoport wrote: >>>> >>>>>>> Do you use SPARSMEM? If yes, what is your section size? >>>>>>> What is the value if CONFIG_FORCE_MAX_ZONEORDER in your configura= tion? >>>>>> Yes, >>>>>> >>>>>> CONFIG_SPARSEMEM=3Dy >>>>>> >>>>>> CONFIG_SPARSEMEM_STATIC=3Dy >>>>>> >>>>>> CONFIG_FORCE_MAX_ZONEORDER =3D 11 >>>>>> >>>>>> CONFIG_PAGE_OFFSET=3D0xC0000000 >>>>>> CONFIG_HAVE_ARCH_PFN_VALID=3Dy >>>>>> CONFIG_HIGHMEM=3Dy >>>>>> #define SECTION_SIZE_BITS 26 >>>>>> #define MAX_PHYSADDR_BITS 32 >>>>>> #define MAX_PHYSMEM_BITS 32 >>>> >>>> >>>> With the patch,=C2=A0 the addr is aligned, but the panic still occur= red, >>> >>> Is this the same panic at move_freepages() for range [de600, de7ff]? >>> >>> Do you enable CONFIG_ARM_LPAE? >> >> no, the CONFIG_ARM_LPAE is not set, and yes with same panic at >> move_freepages at >> >> start_pfn/end_pfn [de600, de7ff], [de600000, de7ff000] : pfn =3Dde600= , page >> =3Def3cc000, page-flags =3D ffffffff, pfn2phy =3D de600000 >> >>>> __free_memory_core, range: 0xb0200000 - 0xc0000000, pfn: b0200 - b02= 00 >>>> __free_memory_core, range: 0xcc000000 - 0xdca00000, pfn: cc000 - b02= 00 >>>> __free_memory_core, range: 0xde700000 - 0xdea00000, pfn: de700 - b02= 00 >=20 > Hmm, [de600, de7ff] is not added to the free lists which is correct. Bu= t > then it's unclear how the page for de600 gets to move_freepages()... >=20 > Can't say I have any bright ideas to try here... Are we missing some checks (e.g., PageReserved()) that=20 pfn_valid_within() would have "caught" before? --=20 Thanks, David / dhildenb