From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F13FC07E9D for ; Thu, 29 Sep 2022 04:05:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DBC18D0001; Thu, 29 Sep 2022 00:05:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78B2F6B0078; Thu, 29 Sep 2022 00:05:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6519F8D0001; Thu, 29 Sep 2022 00:05:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 55EB26B0075 for ; Thu, 29 Sep 2022 00:05:39 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1EBEDAB658 for ; Thu, 29 Sep 2022 04:05:39 +0000 (UTC) X-FDA: 79963783998.20.D4FD4ED Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf13.hostedemail.com (Postfix) with ESMTP id 0678C20006 for ; Thu, 29 Sep 2022 04:05:36 +0000 (UTC) Received: from [10.20.42.170] (unknown [10.20.42.170]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxkOCNGTVjBqEjAA--.2174S3; Thu, 29 Sep 2022 12:05:33 +0800 (CST) Message-ID: <24f6df23-82cc-1290-e015-cba2a284e060@loongson.cn> Date: Thu, 29 Sep 2022 12:05:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: Qi Zheng , David Hildenbrand , akpm@linux-foundation.org, muchun.song@linux.dev, =?UTF-8?B?6ZmI5Y2O5omN?= Cc: chris@zankel.net, jcmvbkbc@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song References: <20220926115621.13849-1-zhengqi.arch@bytedance.com> From: maobibo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8CxkOCNGTVjBqEjAA--.2174S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Ary8CrWkuF4rCr48uFWfXwb_yoW8Kw1kpr 97CF1DtFWYqr18Cr1Iqr1kuryFqw1UJa4UXry7ta4UXrnFqwn2grWUWr4q9w4UJrs5J3WU Xr4jqr13ZF4UZr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9l14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCY02Avz4vE-syl42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664424338; a=rsa-sha256; cv=none; b=bjZv6Vs967vf0+5sCsdb3LUWFM3jgRw6olcKQYqNP9eAl5S7v3UHmoF9J9jSP306NT87Xl kS8tkew4H6tcTEgADtoRe1DxagUy7J6eqRHJeApWvejvb8mHnRszwFu7oNfsNncFI4kPy+ SLNWW5AcgXJD5Pe0rzmIoDHyDmkBBcQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664424338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QCspGMp0022suaFgO44ds7VEZWeaHzs02Ptd90HCUwA=; b=a6CmJiDWgGWPOwPX10ASYQYDUR9ksJyW881BvZulsTaGCI9eboLFCgvVRjeDSj94jGczEk sVtwG8JteFAUSHYaMcQcUWeAMvIzeYLjKPjUCAbUvOoWkBbv38KMNiVbgLqT5a+OF0dIr1 iyOaHsGIFI7k1Q+acPPd3KNP+OMGDb4= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0678C20006 X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of maobibo@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=maobibo@loongson.cn X-Stat-Signature: pca5cf5584ng63sqcz3mn1q68e1rnjhr X-HE-Tag: 1664424336-447842 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/29 11:47, Qi Zheng 写道: > > > On 2022/9/29 11:27, maobibo wrote: >> 在 2022/9/29 11:07, Qi Zheng 写道: >>> >>> >>> On 2022/9/26 22:34, David Hildenbrand wrote: >>>> On 26.09.22 13:56, Qi Zheng wrote: >>>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>>>> if PTE entry exists") said, we should update local TLB only on the >>>>> second thread. So in the do_anonymous_page() here, we should use >>>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>>>> >>>>> Signed-off-by: Qi Zheng >>>>> Reviewed-by: Muchun Song >>>>> --- >>>>> v1: https://lore.kernel.org/lkml/20220924053239.91661-1-zhengqi.arch@bytedance.com/ >>>>> >>>>> Changelog in v1 -> v2: >>>>>    - change the subject and commit message (David) >>>>> >>>>>    mm/memory.c | 2 +- >>>>>    1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/mm/memory.c b/mm/memory.c >>>>> index 118e5f023597..9e11c783ba0e 100644 >>>>> --- a/mm/memory.c >>>>> +++ b/mm/memory.c >>>>> @@ -4122,7 +4122,7 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) >>>>>        vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, vmf->address, >>>>>                &vmf->ptl); >>>>>        if (!pte_none(*vmf->pte)) { >>>>> -        update_mmu_cache(vma, vmf->address, vmf->pte); >>>>> +        update_mmu_tlb(vma, vmf->address, vmf->pte); >>>>>            goto release; >>>>>        } >>>> >>>> >>>> Staring at 7df676974359, it indeed looks like an accidental use [nothing else in that patch uses update_mmu_cache]. >>>> >>>> So it looks good to me, but a confirmation from Bibo Mao might be good. >>> >>> Thanks, and Hi Bibo, any comments here? :) >> >> update_mmu_tlb is defined as empty on loongarch, maybe some lines should >> be added in file arch/loongarch/include/asm/pgtable.h like this: > > Seems like a bug? Because there are many other places where > update_mmu_tlb() is called. > >> >> +#define __HAVE_ARCH_UPDATE_MMU_TLB >> +#define update_mmu_tlb  update_mmu_cache > > If so, I can make the above as a separate fix patch. It sounds good to me. Huacai, do you have any comments? regards bibo, mao > > Thanks, > Qi > >> >> regards >> bibo mao >>> >>>> >>> >> >