From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8FAEC433DF for ; Tue, 26 May 2020 10:34:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B19C32089D for ; Tue, 26 May 2020 10:34:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B19C32089D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 461648009E; Tue, 26 May 2020 06:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4121580061; Tue, 26 May 2020 06:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34EA28009E; Tue, 26 May 2020 06:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 1C03880061 for ; Tue, 26 May 2020 06:34:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D3C14181AC9BF for ; Tue, 26 May 2020 10:34:21 +0000 (UTC) X-FDA: 76858510722.06.mark03_26116e96ea426 X-HE-Tag: mark03_26116e96ea426 X-Filterd-Recvd-Size: 1698 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 May 2020 10:34:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 98A59ACAC; Tue, 26 May 2020 10:34:22 +0000 (UTC) Subject: Re: [PATCH v3 14/19] mm: memcg/slab: deprecate memcg_kmem_get_cache() To: Roman Gushchin , Andrew Morton Cc: Johannes Weiner , Michal Hocko , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org References: <20200422204708.2176080-1-guro@fb.com> <20200422204708.2176080-15-guro@fb.com> From: Vlastimil Babka Message-ID: <25aaef88-ebad-0f11-14b8-fcfd1bb8ff2a@suse.cz> Date: Tue, 26 May 2020 12:34:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200422204708.2176080-15-guro@fb.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: "deprecate" means it still exist but shouldn't get new callers, no? maybe just "remove" or "inline ... into its caller" On 4/22/20 10:47 PM, Roman Gushchin wrote: > The memcg_kmem_get_cache() function became really trivial, so > let's just inline it into the single call point: > memcg_slab_pre_alloc_hook(). > > It will make the code less bulky and can also help the compiler > to generate a better code. > > Signed-off-by: Roman Gushchin Reviewed-by: Vlastimil Babka