From: Guenter Roeck <linux@roeck-us.net>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH] mm: Provide consistent declaration for num_poisoned_pages
Date: Mon, 26 Feb 2018 18:13:57 -0800 [thread overview]
Message-ID: <262450c2-778a-fb12-1af3-aa52d03121c8@roeck-us.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1802261556420.236524@chino.kir.corp.google.com>
On 02/26/2018 03:57 PM, David Rientjes wrote:
> On Mon, 26 Feb 2018, Guenter Roeck wrote:
>
>> clang reports the following compile warning.
>>
>> In file included from mm/vmscan.c:56:
>> ./include/linux/swapops.h:327:22: warning:
>> section attribute is specified on redeclared variable [-Wsection]
>> extern atomic_long_t num_poisoned_pages __read_mostly;
>> ^
>> ./include/linux/mm.h:2585:22: note: previous declaration is here
>> extern atomic_long_t num_poisoned_pages;
>> ^
>>
>> Let's use __read_mostly everywhere.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> Cc: Matthias Kaehlcke <mka@chromium.org>
>> ---
>> include/linux/mm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/mm.h b/include/linux/mm.h
>> index ad06d42adb1a..bd4bd59f02c1 100644
>> --- a/include/linux/mm.h
>> +++ b/include/linux/mm.h
>> @@ -2582,7 +2582,7 @@ extern int get_hwpoison_page(struct page *page);
>> extern int sysctl_memory_failure_early_kill;
>> extern int sysctl_memory_failure_recovery;
>> extern void shake_page(struct page *p, int access);
>> -extern atomic_long_t num_poisoned_pages;
>> +extern atomic_long_t num_poisoned_pages __read_mostly;
>> extern int soft_offline_page(struct page *page, int flags);
>>
>>
>
> No objection to the patch, of course, but I'm wondering if it's (1) the
> only such clang compile warning for mm/, and (2) if the re-declaration in
It is the only one I recall seeing in mm/ while testing the clang/retpoline
changes with ToT clang 7.0.0, but then I didn't pay too close attention.
> mm.h could be avoided by including swapops.h?
>
Another alternative would be to remove the extern fom swapops.h and have
swapops.h include mm.h instead. I chose the least invasive change since
I didn't want to risk breaking some other build (after all, maybe there
was a reason for declaring num_poisoned_pages in two include files).
Guenter
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2018-02-27 2:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 23:09 [PATCH] mm: Provide consistent declaration for num_poisoned_pages Guenter Roeck
2018-02-26 23:57 ` David Rientjes
2018-02-27 2:13 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262450c2-778a-fb12-1af3-aa52d03121c8@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mka@chromium.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).