From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7F7C5519F for ; Fri, 27 Nov 2020 17:13:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 235A522245 for ; Fri, 27 Nov 2020 17:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 235A522245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 985E86B0036; Fri, 27 Nov 2020 12:13:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 936FE6B005C; Fri, 27 Nov 2020 12:13:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84B3E6B0072; Fri, 27 Nov 2020 12:13:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 6C1946B0036 for ; Fri, 27 Nov 2020 12:13:28 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 30546180AD82F for ; Fri, 27 Nov 2020 17:13:28 +0000 (UTC) X-FDA: 77530844496.16.ocean47_07021a527389 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 101CC100E6903 for ; Fri, 27 Nov 2020 17:13:28 +0000 (UTC) X-HE-Tag: ocean47_07021a527389 X-Filterd-Recvd-Size: 2443 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Nov 2020 17:13:27 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 08897AC0C; Fri, 27 Nov 2020 17:13:26 +0000 (UTC) Subject: Re: [PATCH -next] mm/page_alloc: Mark some symbols with static keyword To: Zou Wei , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1605517365-65858-1-git-send-email-zou_wei@huawei.com> From: Vlastimil Babka Message-ID: <27899673-2d79-2a26-fc66-d2ecce9cb1b3@suse.cz> Date: Fri, 27 Nov 2020 18:13:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <1605517365-65858-1-git-send-email-zou_wei@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/16/20 10:02 AM, Zou Wei wrote: > Fix the following sparse warnings: > > mm/page_alloc.c:3040:6: warning: symbol '__drain_all_pages' was not declared. Should it be static? > mm/page_alloc.c:6349:6: warning: symbol '__zone_set_pageset_high_and_batch' was not declared. Should it be static? > > Signed-off-by: Zou Wei Acked-by: Vlastimil Babka > --- > mm/page_alloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 63d8d8b..e7548344 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -3037,7 +3037,7 @@ static void drain_local_pages_wq(struct work_struct *work) > * that need the guarantee that every CPU has drained can disable the > * optimizing racy check. > */ > -void __drain_all_pages(struct zone *zone, bool force_all_cpus) > +static void __drain_all_pages(struct zone *zone, bool force_all_cpus) > { > int cpu; > > @@ -6346,7 +6346,7 @@ static void pageset_init(struct per_cpu_pageset *p) > pcp->batch = BOOT_PAGESET_BATCH; > } > > -void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high, > +static void __zone_set_pageset_high_and_batch(struct zone *zone, unsigned long high, > unsigned long batch) > { > struct per_cpu_pageset *p; >