From: kuan.ying lee <kuan-ying.lee@mediatek.com>
To: Marco Elver <elver@google.com>
Cc: Nicholas Tang <nicholas.tang@mediatek.com>,
Andrew Yang <andrew.yang@mediatek.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
"Andrey Ryabinin" <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Chinwen Chang <chinwen.chang@mediatek.com>,
Andrew Morton <akpm@linux-foundation.org>,
<kasan-dev@googlegroups.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<kuan-ying.lee@mediatek.com>
Subject: Re: [PATCH v2 2/2] kasan, slub: reset tag when printing address
Date: Wed, 4 Aug 2021 16:59:42 +0800 [thread overview]
Message-ID: <27f393ad9a926a96bfb9291b21cdd2a86ada2d4d.camel@mediatek.com> (raw)
In-Reply-To: <CANpmjNMAw=rcp_V+G_vjRjArj+09AkOxtC+wUNs-e1RRvfQm6w@mail.gmail.com>
On Wed, 2021-08-04 at 10:41 +0200, Marco Elver wrote:
> On Wed, 4 Aug 2021 at 10:23, Kuan-Ying Lee <
> Kuan-Ying.Lee@mediatek.com> wrote:
> >
> > The address still includes the tags when it is printed.
> > With hardware tag-based kasan enabled, we will get a
> > false positive KASAN issue when we access metadata.
> >
> > Reset the tag before we access the metadata.
> >
> > Fixes: aa1ef4d7b3f6 ("kasan, mm: reset tags when accessing
> > metadata")
> > Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
> > Suggested-by: Marco Elver <elver@google.com>
>
> Note, in this case Suggested-by is inappropriate, because I did not
> suggest the change in any way (you already had it in v1). I just
> commented on the fact that it's missing a Fixes so stable can pick it
> up and some clarification.
>
> Reviewed-by: Marco Elver <elver@google.com>
Got it.
I will remove it on v3.
Thanks.
>
> > ---
> > mm/slub.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/slub.c b/mm/slub.c
> > index b6c5205252eb..f77d8cd79ef7 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> > @@ -576,8 +576,8 @@ static void print_section(char *level, char
> > *text, u8 *addr,
> > unsigned int length)
> > {
> > metadata_access_enable();
> > - print_hex_dump(level, kasan_reset_tag(text),
> > DUMP_PREFIX_ADDRESS,
> > - 16, 1, addr, length, 1);
> > + print_hex_dump(level, text, DUMP_PREFIX_ADDRESS,
> > + 16, 1, kasan_reset_tag((void *)addr),
> > length, 1);
> > metadata_access_disable();
> > }
> >
> > --
> > 2.18.0
prev parent reply other threads:[~2021-08-04 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 8:22 [PATCH v2 0/2] kasan: reset tag when accessing invalid data Kuan-Ying Lee
2021-08-04 8:22 ` [PATCH v2 1/2] kasan, kmemleak: reset tags when scanning block Kuan-Ying Lee
2021-08-04 8:22 ` [PATCH v2 2/2] kasan, slub: reset tag when printing address Kuan-Ying Lee
2021-08-04 8:41 ` Marco Elver
2021-08-04 8:59 ` kuan.ying lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f393ad9a926a96bfb9291b21cdd2a86ada2d4d.camel@mediatek.com \
--to=kuan-ying.lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.yang@mediatek.com \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chinwen.chang@mediatek.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=nicholas.tang@mediatek.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).