From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: dhowells@redhat.com,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [GIT PULL] cachefiles, afs: mm wait fixes
Date: Wed, 24 Mar 2021 08:21:21 +0000 [thread overview]
Message-ID: <2813194.1616574081@warthog.procyon.org.uk> (raw)
Hi Linus,
Could you pull these patches from Matthew Wilcox to fix page
waiting-related issues in cachefiles and afs as extracted from his folio
series[1]:
(1) In cachefiles, remove the use of the wait_bit_key struct to access
something that's actually in wait_page_key format. The proper struct
is now available in the header, so that should be used instead.
(2) Add a proper wait function for waiting killably on the page writeback
flag. This includes a recent bugfix[2] that's not in the afs code.
(3) In afs, use the function added in (2) rather than using
wait_on_page_bit_killable() which doesn't provide the aforementioned
bugfix.
Notes:
- I've included these together since they are an excerpt from a patch
series of Willy's, but I can send the first separately from the other
two if you'd prefer since they touch different modules.
- The cachefiles patch could be deferred to the next merge window as
whichever compiler is used probably *should* generate the same code for
both structs, even with struct randomisation turned on.
- AuriStor (auristor.com) have added certain of my branches to their
automated AFS testing, hence the Tested-by kafs-testing@auristor.com tag
on the patches in this set. Is this the best way to represent this?
David
Link: https://lore.kernel.org/r/20210320054104.1300774-1-willy@infradead.org[1]
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c2407cf7d22d0c0d94cf20342b3b8f06f1d904e7 [2]
Link: https://lore.kernel.org/r/20210323120829.GC1719932@casper.infradead.org/ # v1
---
The following changes since commit 0d02ec6b3136c73c09e7859f0d0e4e2c4c07b49b:
Linux 5.12-rc4 (2021-03-21 14:56:43 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tags/afs-cachefiles-fixes-20210323
for you to fetch changes up to 75b69799610c2b909a18e709c402923ea61aedc0:
afs: Use wait_on_page_writeback_killable (2021-03-23 20:54:37 +0000)
----------------------------------------------------------------
cachefiles, afs: mm wait fixes
----------------------------------------------------------------
Matthew Wilcox (Oracle) (3):
fs/cachefiles: Remove wait_bit_key layout dependency
mm/writeback: Add wait_on_page_writeback_killable
afs: Use wait_on_page_writeback_killable
fs/afs/write.c | 3 +--
fs/cachefiles/rdwr.c | 7 +++----
include/linux/pagemap.h | 2 +-
mm/page-writeback.c | 16 ++++++++++++++++
4 files changed, 21 insertions(+), 7 deletions(-)
next reply other threads:[~2021-03-24 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 8:21 David Howells [this message]
2021-03-24 17:27 ` [GIT PULL] cachefiles, afs: mm wait fixes Linus Torvalds
2021-03-24 18:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2813194.1616574081@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).