From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA49AC2D0CF for ; Tue, 24 Dec 2019 09:28:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6A25A206CB for ; Tue, 24 Dec 2019 09:28:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B9EkRlsF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A25A206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CE4EF8E0005; Tue, 24 Dec 2019 04:28:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C95968E0001; Tue, 24 Dec 2019 04:28:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5D2B8E0005; Tue, 24 Dec 2019 04:28:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 9D96E8E0001 for ; Tue, 24 Dec 2019 04:28:26 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 148118249980 for ; Tue, 24 Dec 2019 09:28:26 +0000 (UTC) X-FDA: 76299509412.13.meat89_66a3a10cef54f X-HE-Tag: meat89_66a3a10cef54f X-Filterd-Recvd-Size: 6546 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Dec 2019 09:28:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577179704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9io39MapNxb9iVLyPk4R6ZIbMC7c4yRkMWk9UfOh+Yw=; b=B9EkRlsFgU4Ik3goT5iuDtWUP6xRn1DxOVZ9cvBliUMyakqEkBSK029Gr7ulQaP3Kkhl35 zySFMEf/kt2zCygQcVgtLP+JoJbdxZ1GAE5q9IGxSkbblJHlAH5sOlMFFBwMqjuPVUtFvL flDlIE50lqhSJDoK0Pwnbc10E7GH2NE= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-338-IJeH9B3lNGyJEda1CLohXg-1; Tue, 24 Dec 2019 04:28:23 -0500 Received: by mail-wr1-f70.google.com with SMTP id f10so958077wro.14 for ; Tue, 24 Dec 2019 01:28:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=sdq63IePYHAZah7URn5zkx4Y6XBmFNMvwu4Q1uK3z8k=; b=eGASyUe+zK9RwNHJqrvWYcBW16htnqVEfcAwZCUAFrphUUpW7DK/TeSWBcFLes2jPe bwPR8I0giG+3eNj9SRqZ2+8Mk/TcvVNf4G71wcHhxrsqMi/9enT/OWDOVnAOGoHFquJ2 AqNUHvBs5fqlruqYu4FbTrUmS2pBoLZhgYsmqKfGWpWyUQ6essdBnaXBDPOPMZkNkDS7 8AfAPjiLgdgY9tvIbriLqycO243Ynzw/gydFtluU3YSGB4Ll96OwyDehV/4W2zaUa+ub XERHboQ7ijJFHqSfFPqO5TOTXriA4PzKwpBo66bZnv4FHZzX9SyeRdGGgX/xUUqGaRUx aawA== X-Gm-Message-State: APjAAAX+DNb1NZhudbyApilSb5ESoSo0y9b01/qaVaoHbcpyGvs7QQc6 Zl9wYVwh/Ftpb4afrNmkz1BPYp3vKbAnkQBInqdM0QnqQaDXnH0JbZ6k/nbSEyem5uNOD9HxeL+ aqBXMsjMv7js= X-Received: by 2002:a5d:4b47:: with SMTP id w7mr35990751wrs.276.1577179701915; Tue, 24 Dec 2019 01:28:21 -0800 (PST) X-Google-Smtp-Source: APXvYqw9/TSLj5c5X1JnE2/hzqVf4qICkFRn7uD3XRturCTmvjkz0LR8yv7IDInsAtlJzkhhu/UF3g== X-Received: by 2002:a5d:4b47:: with SMTP id w7mr35990685wrs.276.1577179701626; Tue, 24 Dec 2019 01:28:21 -0800 (PST) Received: from ?IPv6:2003:d8:2f31:4c00:d9fc:8de:fc42:5adc? (p200300D82F314C00D9FC08DEFC425ADC.dip0.t-ipconnect.de. [2003:d8:2f31:4c00:d9fc:8de:fc42:5adc]) by smtp.gmail.com with ESMTPSA id s3sm2070447wmh.25.2019.12.24.01.28.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Dec 2019 01:28:21 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory Date: Tue, 24 Dec 2019 10:28:20 +0100 Message-Id: <2828152B-D0EB-4802-A304-4A90CA5C4B6C@redhat.com> References: <91ED8152-61FC-4E87-9F7B-44CD05C77279@linux.alibaba.com> Cc: David Hildenbrand , LKML , Linux MM , virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Michal Hocko , Andrew Morton , "Michael S . Tsirkin" , Sebastien Boeuf , Samuel Ortiz , Robert Bradford , Luiz Capitulino , Alexander Duyck , Alexander Potapenko , Alexander Viro , Anshuman Khandual , Anthony Yznaga , Dan Williams , Dave Young , Igor Mammedov , Jason Wang , Johannes Weiner , Juergen Gross , Konrad Rzeszutek Wilk , Len Brown , Mel Gorman , Michal Hocko , Mike Rapoport , Oscar Salvador , Oscar Salvador , Pavel Tatashin , Pavel Tatashin , Pingfan Liu , Qian Cai , "Rafael J. Wysocki" , Stefan Hajnoczi , Vlastimil Babka , Wei Yang In-Reply-To: <91ED8152-61FC-4E87-9F7B-44CD05C77279@linux.alibaba.com> To: teawater X-Mailer: iPhone Mail (17C54) X-MC-Unique: IJeH9B3lNGyJEda1CLohXg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 24.12.2019 um 08:04 schrieb teawater : >=20 > =EF=BB=BFHi David, >=20 > Thanks for your work. >=20 > I Got following build fail if X86_64_ACPI_NUMA is n with rfc3 and rfc4: > make -j8 bzImage > GEN Makefile > DESCEND objtool > CALL /home/teawater/kernel/linux-upstream3/scripts/atomic/check-atomi= cs.sh > CALL /home/teawater/kernel/linux-upstream3/scripts/checksyscalls.sh > CHK include/generated/compile.h > CC drivers/virtio/virtio_mem.o > /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c: In fun= ction =E2=80=98virtio_mem_translate_node_id=E2=80=99: > /home/teawater/kernel/linux-upstream3/drivers/virtio/virtio_mem.c:478:10:= error: implicit declaration of function =E2=80=98pxm_to_node=E2=80=99 [-We= rror=3Dimplicit-function-declaration] > node =3D pxm_to_node(node_id); > ^~~~~~~~~~~ > cc1: some warnings being treated as errors > /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:265: recipe = for target 'drivers/virtio/virtio_mem.o' failed > make[3]: *** [drivers/virtio/virtio_mem.o] Error 1 > /home/teawater/kernel/linux-upstream3/scripts/Makefile.build:503: recipe = for target 'drivers/virtio' failed > make[2]: *** [drivers/virtio] Error 2 > /home/teawater/kernel/linux-upstream3/Makefile:1649: recipe for target 'd= rivers' failed > make[1]: *** [drivers] Error 2 > /home/teawater/kernel/linux-upstream3/Makefile:179: recipe for target 'su= b-make' failed > make: *** [sub-make] Error 2 >=20 Thanks Hui, So it has to be wrapped in an ifdef, thanks! Cheers!